Publish DEPS for 76.0.3809.36
Incrementing VERSION to 76.0.3809.36
TBR=govind@chromium.org
Change-Id: Ic6414efee17abd214227e75f5d258e544cd2cc98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666589
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#440}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[remoting][Android] Fix broken app version code
The CRD Android app version code had been fallback to "1" in official
build for some reason. This CL explicitly sets the version code to
`chrome_version_code` to be consistent with what we had been using.
(cherry picked from commit 619b073720da4129830da6be728f89897dbeb6de)
Bug: 976461
Change-Id: Id801c01da274eb307dcc316d4e76dd18d391b686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666129
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#670258}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666311
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#439}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Log zero state omnibox result click with assistant integration.
(cherry picked from commit 3496815959da0a69968c1fb1b8f8a8aa6b9cc12e)
Bug: 973669
Change-Id: I99b100e0c8fab0d2829668bd1efd8bda7abf5045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657034
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668902}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666509
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#438}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Updating XTBs based on .GRDs from branch 3809
TBR=meacer@chromium.org
Change-Id: I13d57c14e466e96508ded3f59bc1701d25ae26e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665853
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#437}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.35
TBR=govind@chromium.org
Change-Id: I5c74809dad54d49fd25073b9085e9756c8ec33bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665770
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#436}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge to M76] Tighten filesystem: requests to use stronger CanCommitURL security checks.
This CL strenthens security checks in FileSystemEntryURLLoader to
block requests for filesystem: URLs if the requested URL is not
commitable in the current process. When site isolation is on, this
will prevent one origin from fetching filesystem resources belonging
to another origin.
Note that this will also block web sites from requesting arbitrary
extension filesystem URLs that lead to downloads, which is an
intentional change discussed on 964245. An existing test in
ProcessManagerBrowserTest is updated accordingly.
TBR=alexmos@chromium.org
(cherry picked from commit d8fb84f4bb703bd314c62be2bfbe876330bea1d3)
Bug: 964245
Change-Id: I09023cc884278efef0bb4d16e584b2c5f1a5fd5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635876
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667356}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665556
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#435}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Feed] Switch to DeferredStartupHandler.
(cherry picked from commit 7e0507a6e1fbc88dbff570572738c7a58442b6d2)
Bug: 968213
Change-Id: I5270ccb000096f0517cb7c15ff14055a1bfb8471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649176
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667271}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665729
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#434}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Chromeshine] Stop using the page-provided canonical URL
This means we won't handle AMP pages that don't use SXG(signed exchanges).
Trusting the canonical URL blindly has potential privacy risks. Trusting only
Google-provided AMP urls is also the wrong solution; we want to rely on the
long term solution that is SXG.
(cherry picked from commit 0e604b323671c3be03fbf0836f7c26b54ca89955)
Bug: 961814
Change-Id: Ib3544e8c478a3a9089d8c7414f7ea42bb65b8794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659511
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669854}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665651
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#433}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Feed] Add a parameterized artificial delay legacy NTP.
(cherry picked from commit 6e988a738d51630cef1492c1a959821404bef5ab)
Bug: 968217
Change-Id: I97f4470edcf170a94e084ab208046be2024633b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646973
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668453}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665474
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#432}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Disallow partial swaps for linux based on gl_version_string
This was missed in https://chromium-review.googlesource.com/c/chromium/src/+/1601182
(cherry picked from commit e6a0cdf0b7045e7f9029cce287bcc539052ef79a)
Bug: 973216,941670,957541,948640
Change-Id: I3d2002c38fe09d87c9a3db951dfc2ab112319caf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662528
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Auto-Submit: Jonathan Backer <backer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669701}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665648
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#431}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Introduce JPEG thumbnails for Grid Tab Switcher
The thumbnails shown in the Grid Tab Switcher (GTS) were decoded from
the ETC1 format, downsampled, and then transferred through the JNI
boundary. This is not the most efficient way.
This CL introduces JPEG thumbnails, which would be saved at the same
time ETC1 thumbnails are saved, if GTS is enabled. The GTS would
directly read and decode the JPEG files from the Java side.
(cherry picked from commit eac0768882bbf2c6d0e32966beb194e374afce23)
Bug: 971939
Change-Id: Iaf21ea2170afbb7b0385570459f4566715786ca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648963
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667302}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663939
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#430}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Log performance of Tab-to-Grid transition animations
Log the performance statistics on all non-stable channels to easily
track it for development.
(cherry picked from commit 60b464696469abf83cebf0f1b14ca2f07ebb3d8a)
Bug: 971802
Change-Id: I0e3ac3e86bf5637dad23b4281b82ee1067a660b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644540
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666868}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665201
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#429}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SendTabToSelf] Fix omnibox bubble device icon color in dark mode
Gets icon color from the native theme color.
(cherry picked from commit ce257be965be15085b1009bfc74458f272527ce5)
Bug: 972831
Change-Id: I156cc7335fcc5a28d291097cc35e1573b35e627f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659589
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669363}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663739
Cr-Commit-Position: refs/branch-heads/3809@{#428}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[merge m76] Switch default HDR color space back to SCRGB linear
We switched to HDR10 color space with RGB10A2 backbuffers to workaround
a DWM/driver bug when Chrome is fullscreen. It looks like that bug was
present in RS3 but has been fixed in RS5. MS has recommended not using
HDR10 color space in general so we'll switch back to SCRGB linear with
RGBAF16 backbuffers.
This CL also allows choosing HDR10 color space in chrome://flags for
testing or as a workaround.
(cherry picked from commit 71e474a84342725845b5e05aed9c941cfa1ac88c)
Bug: 937108
Change-Id: I2b97afc0a302b687d672217f085897e7de7f290a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646540
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667846}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665230
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#427}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Remove Dump without crash from payments::JourneyLogger::~JourneyLogger
(cherry picked from commit af0bf36ff24a2e052b19950e0ee8d64255fb7f92)
Bug: 969232
Change-Id: Ib8ea1980afca485e01f70b67fb5c0b8a1379ce38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658762
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669212}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665469
Cr-Commit-Position: refs/branch-heads/3809@{#426}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Adds OffscreenCanvas font cache
TBR=juanmihd
(cherry picked from commit e95f64ac637c24f93fa9e90305ab1f33fffcd6b2)
Bug: 974784
Change-Id: If371ab5e710285be81bd2623f5a03e71db1fe12d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660413
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669682}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665470
Cr-Commit-Position: refs/branch-heads/3809@{#425}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Follow-up to reparenting fix in 1662993 to fix broken compile
Bug: 948907
Change-Id: I3be5defa07f3ac4b6981534b1b262dfc769e0194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665033
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#424}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Do not treat changed nodes as reparented unless they really are
Inconsistent reparenting logic in AXTree leads to old AXNodes being
used for blink events, even though they no longer own their data.
Specifically: when a node is simultaneously removed and changed,
it is being treated as a reparented node, which causes the
node to lose data ownership. In addition, subtree callbacks are
used instead of node deletion callbacks, which leads to
BrowserAccessibilityManager not removing the nodes from its
id cache, and trying to still fire blink events on the dead nodes.
(cherry picked from commit da5f567705a8f0daa47921002c4326d9fb3a30e8)
Bug: 948907
Change-Id: If12fa1f0ae217a446f50453180b63dc94819517b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652247
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668929}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662993
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#423}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix memory leak in TabGridViewHolder
http://crrev.com/c/1595128 (Release thumbnail when TabGridView is
recycled) tried to fix the memory leak in TabGridView, but
http://crrev.com/c/1595292 (Fix memory leak in RoundedCornerImageView)
didn't fully fix the memory leak in RoundedCornerImageView (see
issue 969245), so the memory leak issue in Grid Tab Switcher (GTS)
turned out to be still there.
This CL avoids using setImageResource(0) in GTS, and uses
setImageDrawable(null) along with specified fill color instead.
TBR=dtrainor@chromium.org
(cherry picked from commit 5fd063948aa151756ad1599e57bce9c5e9c8f77f)
Bug: 970073
Change-Id: Iec97ea2b9ec2925f34a4077e4a7069973e2a2b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642161
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666183}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660050
Cr-Commit-Position: refs/branch-heads/3809@{#422}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Merge M76: "Disable VP9.2 hardware decoding on Windows RS3."
There seem to be multiple issues with VP9.2 decoding on RS3. NVIDIA has
disabled support in RS3 for some Windows issue in such a way that the
MFT falls back to software decoding without notifying us.
I was unable to find a way to generate the GUID list of supported DXVA
modes like "dxdiag" does (which somehow doesn't include the VP9.2 GUID:
DXVA2_ModeVP9_VLD_10bit_Profile2).
Since we can't test for it, just disable it since it's usage is rare.
BUG=937108
TEST=tmathmeyer on 1709 w/ patch.
R=sunnyps
(cherry picked from commit c58afb4edf091a936a28e3e064794e65e138562a)
Change-Id: Id97475b22e322c6fbe347be1ab995d3865418914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642034
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669041}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664975
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#421}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Merge M76: "Use DXGI_FORMAT_P010 when querying VP9 10 bit D3D11 support."
DXGI_FORMAT_NV12 is not supported (despite CheckVideoDecoderFormat()
saying it is). We must test using DXGI_FORMAT_P010.
BUG=937108
TEST=GetVideoDecoderConfigCount() > 0.
R=sunnyps
(cherry picked from commit 0d34c44bf3dffb64d11094cb4b029111e991c08f)
Change-Id: I04fd47c49b7d79541ef423b7570965ec6cb72d82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637944
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665375}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663187
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#420}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Mixed Content Experiment: Added metric for opt-outs
(cherry picked from commit 4f374ef6f0413c457cd58caaff1a104013caface)
Bug: 973664
Change-Id: I97fab27401a1b9905005d60609fc34ff0b6f1724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656812
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668954}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663181
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#419}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Prefer launching WebApks for view intents in touchless mode.
(cherry picked from commit d9971f3089d2d6ef73494bd092d0c92d343a9019)
Bug: 968574
Change-Id: Ie952f411c10da45d7757bf235fca68c00fd6847a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652205
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669307}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664876
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#418}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Allow WebApk validation to be disabled.
(cherry picked from commit a8182dbf1a1ec23edbd9df0bfe3bf23d8f02eef8)
Bug: 968574
Change-Id: I96875044ddbad07269eae316102c3ed6cb266e70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651506
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667964}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664874
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#417}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Improves the InfobarModal height calculation.
- Removes fixed height padding.
- Adds the navigation bar height to the Modal height. Renames
infobarModalContentHeight to infobarModalHeight to reflect this.
TBR=sczs@chromium.org
(cherry picked from commit 5de0ee99edf98bd3cb11d73fe081d38096a0ad17)
Bug: 973229
Change-Id: I668794957dc5eb1690481c7c65c3f810c75380e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657228
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668857}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663178
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#416}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Change DCHECKs to CHECKs for debugging crbug.com/974639
This reverts commit 0f75b5b58517efd9d84c76c75f3f344803c8875c.
Reason for revert: For debugging crbug.com/974639.
Original change's description:
> Change CHECKs for debugging crbug.com/816810 to DCHECK
>
> Bug: 816810
> Change-Id: I7d3a9062f940cf0b16350c9cd2d7cae3d95ef152
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553807
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#647896}
TBR=pdr@chromium.org, wangxianzhu@chromium.org
(cherry picked from commit 1ef807417fa5d1e7a7eb727a9e5a1634d0fd96eb)
Bug: 974639
Change-Id: I29aa03beff64b97a36ea0aa727e478310994eeb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662503
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669849}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663687
Cr-Commit-Position: refs/branch-heads/3809@{#415}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Fixes Password Messages metrics.
TBR=sczs@chromium.org
(cherry picked from commit a20f627720fc7807bca766dba8dda0e258bf0f55)
Bug: 974364
Change-Id: I985bbe45fbef1c6ab91e65a5c554e05eef17c3a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660804
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669691}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664653
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#414}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix UnsatisfiedLinkError caused by early histogram recording.
In cases where Omnibox interaction executes a complete cycle (from highlight to
navigate / close) before native code completes loading, we trip UnsatisfiedLinkError
causing application to crash.
This fix ensures we only attempt to record metrics if we know the Native is initialized.
(cherry picked from commit fe9e3c599fdc176e8ed5f45718aabd3c2a93b952)
BUG: 971626
Change-Id: Ic0ef632d6da993516170b943ae20e5cda427fd94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662840
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#669863}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663057
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#413}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Do not send resource loading hints down if coinflip holdback is true
(cherry picked from commit f0efd272c3f4cbd2dc34c84aebfd04fc7402116f)
Bug: 973599
Change-Id: I6fab755385d27e5203ba216f9185e94a16c123ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657168
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669120}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664041
Cr-Commit-Position: refs/branch-heads/3809@{#412}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Removes the InfobarBanner as an A11y element after dismissal
This is a followup to https://crrev.com/c/1654408. After adding the
banner as an A11y element, we also need to remove it once it has been
dismissed.
TBR=sczs@chromium.org
(cherry picked from commit 2a8b104e42fa00c075a2c47897b9da67af8cecb9)
Bug: 973262
Change-Id: I1d2a3a3e2504e651db35407b4e6194212ca4d525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658708
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668940}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664040
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#411}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Makes the InfobarBanner non Modal for A11y purposes.
After the banner is presented we configure it so its an A11y element of
the presenting VC for VoiceOver. This way we can select the banner or
any other views while it's being presented.
TBR=sczs@chromium.org
(cherry picked from commit 9da96727712414122ae1fbfc7966d93877847457)
Bug: 973262, 911864
Change-Id: I3665226891499efec404cccc17701357606dd4c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654408
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668266}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664871
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#410}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Reland "Fix module install"
This is a reland of 801cc00b4ec48cfcfbbd48a441d59d48892f7c48 that calls
ModuleInstaller on the correct thread.
Original change's description:
> Fix module install
>
> Previously, we created a SplitInstallManager _before_ calling
> SplitCompat.install(-), which breaks the module install flow on Android
> pre-Q.
>
> Bug: b/133669491
> Change-Id: I0b317732ed364a592047eeb7387c74dd1ea1b258
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646903
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#668416}
(cherry picked from commit a5d34eb5307d88db26e2b33e1668e35b09fb222b)
Bug: b/133669491
Bug: 966870
Change-Id: I16ae3dcbdd2217fa186371cd1db7b5f57caf9484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661798
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669785}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662927
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#409}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[scroll-snap] Fix bug where snap area was not being removed
Previously we would first check that as area is not a viewport defining
element (VDE) before potentially removing it from its snap container.
The problem is that VDE can change over the lifetime of a document for
example it can initially be HTML and later BODY. This means that it is
possible for the existing logic to consider BODY as a snap area first
and add it to a container but don't consider it a valid snap area at
a later point and thus miss removing it from the map.
The fix simply removes the VDE check for snap areas. We don't really
need to limit VDE being a snap area. We still keep limitation for VDE
becoming a snap container but there removal logic operates regardless so
it is safe.
(cherry picked from commit 86c95f06d09497cb3ac6810f0900ad58b2ab324f)
Bug: 972434
Change-Id: I6d87f8df53f59c58b8302ed7b536b3f6783d98f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657754
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669128}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664477
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#408}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Truncate menu titles to 1 line.
(cherry picked from commit 0af9798589baa2069dcde37437af706934e4e1f9)
Bug: 967694
Change-Id: I17f8696a3dd4d8ea60f1c22c85aec626dd824f35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632589
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668858}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663935
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#407}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Management WebUI: Remove overview section details
The overview detailed section string contained misleading text and had
which has to be removed until a better alternative is found.
Visuals:
Account managed: http://screen/HxbAjSKBFC3
Account + Device managed multiple domains: http://screen/rfrth5atE3b
Account + Device managed same domains: http://screen/6XCAYGnGbRm
Device managed: http://screen/hA5y65Zjp9c
(cherry picked from commit 33f75bc37eab9aecd2ff5b69d193e64ec27fdc0c)
Bug: 971263
Change-Id: I5b2a66c4d6484024a60049b59dd78b0dfd287c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645932
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666413}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648701
Reviewed-by: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#406}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
android: Pin Chrome's code in finishNativeInitialization().
Previously, code pinning was done right after library load. At this time, the
feature system may not be initialized, making this racy and not reliable. Move
code pinning to a point where both features and field trials are known to be
available.
(cherry picked from commit ae2490702675c99ec6737a40bd7c6e6813dafe73)
Bug: 929926
Change-Id: Ibfb8ecfa5ac5d50adc2c7ce0943f2aa6d660aea8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651741
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668319}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664080
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#405}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
base/android: Pin ordered code when the platorm supports it.
This asks the framework to pin the ordered section of Chrome's code in memory
when the platform supports it. Reflection is required, as this is not in the
platform SDK, and is not available everywhere.
(cherry picked from commit 28d8071a26fe932f3269e20eef0c24a52cca81b0)
Bug: 929926
Change-Id: I21a26f42eee9054559b32d2e014d8a7c476f3b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632689
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667927}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663509
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#404}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
webrtc-internals: include blacklisted standard stats in the dump
include RTCIceCandidate and other stats blacklisted for display in the webrtc-internals dump.
Test plan:
- make a call while having webrtc-internals open
- download dump
- search dump for RTCIceCandidate stats
- import on https://fippo.github.io/webrtc-dump-importer/, check reconstructed stats
BUG=968953
(cherry picked from commit 3168f20344e7d3af15cf85c35725e5682b4e3835)
Change-Id: If316774777b073f2c97a3437d01c471e1536efde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639417
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668792}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663497
Cr-Commit-Position: refs/branch-heads/3809@{#403}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Make the arrow button a "pop up button".
Bug: 972069
(cherry picked from commit 84ea898bb78a30becd44511b7b519b86d8458e05)
Change-Id: I82974918a917865640701892baa7c779b8f4dd86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649140
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Edin Kadric <edinkadric@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#667465}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660842
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#402}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ipc] Replace CHECK(false) with NOTREACHED() in ReadValue()
(cherry picked from commit 271086b4555dd6738d3cdcab409ffaa0c8884ed1)
Bug: 971948
Change-Id: I60d81e2f54c43f757ef17641642f2d9701e885ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657910
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668909}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664132
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#401}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Move break_token_ to NGPhysicalContainerFragment from NGPhysicalFragment
This patch moves |NGPhysicalFragment::break_token_| member to
|NGPhysicalContainerFragment| to reduce size of |NGPhysicalTextFragment| since
|NGPhysicalTextFragment| never has break token.
(cherry picked from commit 4386eb056f61e7b335842145acd1b38f5eb8f1b0)
TBR=yosin@chromium.org
Bug: 962108
Change-Id: I7ab6525b2ae72efb3c6e82e1a45b1f5ba2f99678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662921
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#400}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Allocate vector of NGOutOfFlowPositionedDescendant in NGPhysicalContainerFragment only unless empty
This patch changes |NGPhysicalContainerFragment| to allocate vector of
|NGOutOfFlowPositionedDescendant| only if it is not empty for reducing memory
usage.
(cherry picked from commit 763c671366e1af42d9893af0910b682a7f11a4c7)
TBR=yosin@chromium.org
Bug: 962108
Change-Id: Icf16825100ea6de9e1443b3a2ad6f2b10786f873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663555
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#399}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Reland: Disable install event.prompt() after user has already installed the site
Before this CL we would only disable prompt() if the user installs the site
via the menu or the web app banner. This updates the web app omnibox install
button to also disable prompt() from being called.
Without disabling prompt() the site can re-prompt the user to install
which results in the browser crashing.
Note: This CL is a "quick fix" to resolve the browser crash in a mergeable
CL. A set of follow up CLs will change AppBannerManager to listen to web app
install events and clear the prompt() handle that way instead.
This is a reland of:
https://chromium-review.googlesource.com/c/chromium/src/+/1640742
The previous CL's test hit an MSAN error where the test class was being cast
as a sibling class erroneously. This CL moves the tests to
AppBannerManagerDesktopBrowserTest so the test class can subclass the existing
AppBannerManagerDesktop and avoid a sibling cast.
See reland diff:
https://chromium-review.googlesource.com/c/chromium/src/+/1653789/1..8
(cherry picked from commit 1e3a18a3eb3ae1b49a215422e2778f7ae8779741)
Bug: 956810
Change-Id: I31a3c4a6d6ae78a6a629d47119a89a4118efb702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653789
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668655}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662953
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#398}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Allocate memory for borders and padding members of NGPhysicalBoxFragment if needed
This patch changes memory layout of |NGPhysicalBoxFragment| based on value of
borders and padding as
- No borders and no padding
|NGPhysicalBoxFragment|, children[]
- having both borders no padding
|NGPhysicalBoxFragment|, children[], borders, padding
- borders and no padding
|NGPhysicalBoxFragment|, children[], borders
- no borders and padding
|NGPhysicalBoxFragment|, children[], padding
for reducing memory usage, since borders and padding are frequently zero.
(cherry picked from commit 8318aa75176654769ece376cd71fd9fc5deef823)
TBR=yosin@chromium.org
Bug: 962108
Change-Id: I215f6570b9982745609546bcfef5fc3ef0cf5186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663554
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#397}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Send addl RenderFrameMetadata if WebContentsAccessibilityAndroid set
When accessibility is in use we need per-frame scroll offset updates on
Android. This previously occurred with per-frame CompositorFrameMetadata
but is missing with selective RenderFrameMetadata.
This change causes us to always send RenderFrameMetadata for root scroll
offset changes if WebContentsAccessibilityAndroid is set.
TBR=ericrk@chromium.org
(cherry picked from commit 8c7ab9f25db763aed5cbf12ac0208f022a7269d4)
Bug: 964849, 967552
Change-Id: If310649ceccd2cc4b7f0d4110415dce5e8a7ce39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646092
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669379}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663399
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#396}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.34
TBR=mmoss@chromium.org
Change-Id: Ie5ecb1c0895b91da4dd8b09b472c0f84208dd68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663381
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#395}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Signin][Android] Add continue url to Logout request
Adds GaiaAuthFetcher::StartLogOutWithBlankContinueURL that specifies
a blank page as a continue URL for Logout requests. This continue URL
is necessary as sometimes Gaia redirects Logout requests to large pages
that exceed 1MB body limit for SimpleURLLoader::DownloadToString.
(cherry picked from commit 3d8eb95ae203c94c2455c542450a2371360cdf18)
Bug: b/134618807, 975887
Change-Id: Ie4d57ac959f8936077f98fce6a288ebf41122fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656488
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669836}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663492
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#394}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Cors]URLLoaderFactory: Don't allow changing Host header on redirects.
(cherry picked from commit d31383577e0517843c8059dec9b87469bf30900f)
Bug: 973103
Change-Id: I463adfa133267b879e81875ee3252cc5fea684fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655732
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668849}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663354
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#393}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Don't pass the return value of CString::data() to a TRACE_EVENT
(cherry picked from commit 50c7391c22737e14a73e127e7ff027c62efb1286)
Bug: 964768
Change-Id: I59c2384cda133f97730e88a266bba542aeaaa828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637864
Reviewed-by: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665185}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663353
Cr-Commit-Position: refs/branch-heads/3809@{#392}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SendTabToSelf] Fix "empty device list" issue
Previously an empty device list would be shown when there is no valid
remote device but multiple devices are synced. i.e. All remote synced
devices are using Chrome with version earlier than M-75.
Now we will hide the entry points when there is no valid device.
(cherry picked from commit 431b4befa6e1cfda28f92893259cf764cc2f21db)
Bug: 970896
Change-Id: I64c1d58210c7ac30d1b455ea77d8aaccf6fecb27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652372
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669059}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662973
Cr-Commit-Position: refs/branch-heads/3809@{#391}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SendTabToSelf] UI changes of omnibox icon
- Highlight the icon when showing the bubble.
- Change the icon to a bigger size.
(cherry picked from commit 4708ae72494f65545abd0c08da59c7cafc289af1)
Bug: 970900
Change-Id: If1f5519eafb3f49fca35862024003992ad2cfc7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656433
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668707}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663316
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#390}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Mash cleanup: remove more methods from mojom::LoginScreen.
ShowErrorMessage and ClearErrors are deleted, as they've remained
unimplemented for over a year.
SetShowGuestButtonInOobe and SetShowParentAccessButton are renamed
and moved to LoginScreen.
SetShowParentAccessDialog is removed as part of the public API
since it is never called from Chrome.
TBR=estade@chromium.org, tsepez@chromium.org
(cherry picked from commit 98b718ecc8def82441310abbb79e4608b011d9b2)
Bug: 958206
Change-Id: Ibde235d3dd1013a33855874247231613d0fd4da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639459
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665577}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662506
Cr-Commit-Position: refs/branch-heads/3809@{#389}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Updating XTBs based on .GRDs from branch 3809
TBR=meacer@chromium.org
Change-Id: Ibfec6b42b06036d163fd99606af6e09192c0e637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663113
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#388}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Reland "IconOrFavicon metrics"
This is a reland of 75dcccff6a622163b10fabdc2edc1c746bfa4c9a
Original change's description:
> IconOrFavicon metrics
>
> (cherry picked from commit 666018f9e8a02ef6966ac1d63b9560fecc90956d)
>
> Bug: 960469
> Change-Id: I50845a7d20bd5b2e2a19f94c9e4d48cd1200ee6d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650793
> Commit-Queue: Ender <ender@google.com>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660692
> Reviewed-by: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3809@{#366}
> Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Bug: 960469
Change-Id: Ie7b86e060cc5dd264c8f54681c0d8e26fdd5a1d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663313
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#387}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add block button to popup block infobar for touchless
TBR=mdjones@chromium.org
(cherry picked from commit 54617c54b73c4fe9264d94822a022a2dd23978f3)
Bug: 971278
Change-Id: Ia9cbff98874774b17b2326cda3a6e491dc8486eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645896
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Auto-Submit: Matthew Jones <mdjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666774}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663012
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#386}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Merge to release branch: Overflow beyond padding box fix
Merge-Approved-76 by abdulsyed@google.com
(cherry picked from commit e8ce0c9f115f670eb3d1dd180ac0c033b7bc115e)
Bug: 972047
Change-Id: Ia8d3e666076a5acd9b12b869dffb9db1e37e76c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663038
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Abdul Syed <abdulsyed@google.com>
Cr-Commit-Position: refs/branch-heads/3809@{#385}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[m76] webauth: fix a AuthenticatorRequestDialogView regression
CL:1562215 allowed the WebAuthn UI to be hidden mid request while e.g.
the native Touch ID or Windows WebAuthn UIs are shown.
AuthenticatorRequestDialogModel determines whether for the current step,
the UI should be visible or hidden. AuthenticatorRequestDialogView in
turn would read that information for every step change and call
Widget::Show() or Widget::Hide() accordingly.
This caused a bug with the dialogs modal-ness. The dialog is supposed to
be modal to its tab, which is ensured by calling
constrained_window::ShowWebModalDialogViews() with the tab's top-level
WebContents. However, calling Show() on the dialog's widget while the
parent tab is in background will make it appear as a child to the
then-current tab.
It appears that the visibility of a web-modal dialog is controlled by
WebContentsModalDialogManager, which is a WebContentsObserver to the
WebContents that the dialog is modal to. It observes the WebContents
becoming shown/hidden and in turn shows/hides its managed dialogs
accordingly. AuthenticatorRequestDialogView calling Show() on its widget
seems to interfere with that.
As a workaround, make AuthenticatorRequestDialogView also observe its
WebContents' visibility and have it not call Widget::Show() while the
WebContents is hidden; then catch up once the WebContents becomes
visible again.
(cherry picked from commit f85e659b61f9551b65cf5b2f2c20aa2c53b307ce)
Bug: 969153
Change-Id: I15655b60604c5dfe7f536ae6f7cb3ffafead514d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654235
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668921}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663348
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/branch-heads/3809@{#384}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[LayoutNG] Fix focus ring on inline layer elements
A followup to cbiesinger's
https://chromium-review.googlesource.com/c/chromium/src/+/1653864
Fixes more cases.
(cherry picked from commit b1a54567210cc5641556b870dd50fd27b035998c)
Bug: 968019
Change-Id: Ie379fa5e2672c0c2ed0302eb7d40c4460262c00b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658657
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669050}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663310
Cr-Commit-Position: refs/branch-heads/3809@{#383}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[layoutng] Don't double-add offset for outlines
(cherry picked from commit d80a97c1b99d47981588b32a02f019b4b09059ab)
Bug: 968019
Change-Id: Ib739657be21ea1f8f973f88c51fdda29585ac64e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653864
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668308}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663308
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#382}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Revert "IconOrFavicon metrics"
This reverts commit 75dcccff6a622163b10fabdc2edc1c746bfa4c9a.
Reason for revert: Breaks Android Beta build, crbug 976051
Original change's description:
> IconOrFavicon metrics
>
> (cherry picked from commit 666018f9e8a02ef6966ac1d63b9560fecc90956d)
>
> Bug: 960469
> Change-Id: I50845a7d20bd5b2e2a19f94c9e4d48cd1200ee6d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650793
> Commit-Queue: Ender <ender@google.com>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660692
> Reviewed-by: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3809@{#366}
> Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
TBR=skym@chromium.org,ender@google.com
Change-Id: If884512c7d461fefbf58eb40ed37519caf1fc3de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 960469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663055
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#381}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Show currently selected match on the bottom of the screen
This change will move the position of a newly selected match to
the bottom of the screen as opposed to the top so that it does not
get covered up by any webpage toolbar on AMP pages.
(cherry picked from commit bbec82e94521cb3934b1c1a194e3725e6c5c2c9c)
Change-Id: I95fa390c2ebb4fccc12e5609234e28a440aabca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653845
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668565}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663031
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#380}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
CrOS: Speculative fix for AppListView crash during Tablet transition
It seems like the button is being pressed during the transition, but
before the AppListView is constructed. In tablet mode we assume that the
AppListView exists, but it is not neccesarily true at the beginning.
(cherry picked from commit df8f5bb7882323336c41b487b3e8124bd87aa4b5)
Bug: 969844
Change-Id: I332abe4e7d330bccad7d9c51c3cd3d49fa683513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659353
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669298}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663051
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#379}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Signin] Pass externalCcResult to multilogin requests
Pass externalCcResult in the multilogin params to make sure it correctly
sets cookies for secondary domains.
This had conflicts with https://crrev.com/c/1624189 that were resolved
manually.
TBR=msarda@chromium.org
(cherry picked from commit 0aec7c82277205ddd4bf8e8a3a6604fe186d5019)
Bug: 971393, b/133516269
Change-Id: Iab7d6779e8137fd677e19929113464aa3acd9be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658572
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669320}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662416
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#378}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Chromeshine] Create PageViewObserver for CCT at task root
We usually don't want to observe custom tab browsing, since it should be
attributed to the app that opens the custom tab. The exception is when
the custom tab is at the root of the task, e.g. when links are opened
from the "-1 screen."
(cherry picked from commit 067a6581ae468209436c38d5bccb266519aa5013)
Bug: 973232
Change-Id: I22b5cad63d56f60cf43adbadfcdd03ba8e964212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652666
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669304}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662850
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#377}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix regression with misaligned button in printer settings make/model dialog.
- Regression was introduced when PPD label div was added.
- Fix is to align item with flex.
- Removed min-height for this css style as it was never used.
(cherry picked from commit c8c36ba93962722af7c31e4d8ef5361b9b763969)
Bug: 972003
Test: End to End Manual
Change-Id: I347e5dcf233e320aed843ede13d10ca46e71b5d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656736
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668966}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662819
Cr-Commit-Position: refs/branch-heads/3809@{#376}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SpatNav]: Make {cursor: pointer} trees focus candidates
Background:
Some web apps use one "catch all"-click handler, often put
on <body> or a container <div>, to react on clicks within
certain areas of the page. These web pages expect clicks
(or touches) and are not designed with key[board] users in
mind (they lack tabindex).
These pages' clickables, for example <div>s that look like
buttons, are often styled with {cursor: pointer}.
Problem:
These web pages are inaccessible for keyboard-only users.
Solution:
Enable SpatNav on these web apps by adding {cursor: pointer}
sub trees' tip to the list of navigation candidates.
Spec discussion:
https://github.com/w3c/csswg-drafts/issues/3395
Note:
snav-imagemap-area-not-focusable.html found a bug in
Chrome's UA CSS. We used to style *all* <area>s as
clickables, with {cursor: pointer}, even those without a
href-attribute. I fixed this in crrev.com/c/1653009.
(cherry picked from commit 308a30020307ae3925507536c48e5450c55b21f2)
Bug: 961927
Change-Id: I7baa2ba6f5f36ebc23b072d677edc66acfb2a70b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632231
Commit-Queue: Hugo Holgersson <hholgersson@fb.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669193}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662868
Cr-Commit-Position: refs/branch-heads/3809@{#375}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix for nullptr crash in SpatNav
No test since I don't know how to setup this situation. However, it's
safe to just avoid scrolling in this case.
(cherry picked from commit 3438927c32a922d35ea49c340fbbdb4c0c36bca9)
Bug: 970164
Change-Id: Icbae6b631e2f80e9e6493825fefb0f10fab974f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645792
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667579}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662835
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#374}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Audio Focus] Fix crash on multiple abandon
We might call AbandonAudioFocus multiple times which
could cause a crash if there is no session.
BUG=971827
(cherry picked from commit 7fa2f944d4115778871f19a1c3197dcbf35d7982)
Change-Id: I71fd9c50314b38215326043f9e67109685d29c8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658769
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668919}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661807
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#373}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Further qualify low end graphics optimizations
These can result in visual artifacts, so we should only
apply them where the memory impact is worth the
tradeoff.
(cherry picked from commit 7a847a8327a1e22dc83107dda61a50a3ca729682)
Bug: 974241
Change-Id: I771f0e919956eb3f677623989d7ac23bbb0ecc0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659940
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669338}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662832
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#372}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix multi line render text elision with newline characters.
This fixes multi line elision for text that contains newline
characters. This had the following two issues:
1) RenderText::Elide renders the given text on a single line.
This is fixed by only passing in a single line when eliding the text in
RenderText::UpdateDisplayText.
2) The HarfBuzzLineBreaker keeps track of the min and max ascent.
This needs to ignore newline characters in multiline modes as they are
not drawn.
(cherry picked from commit 78785c2d677e46a7dcde8a0e8708c5c67f5e3890)
Bug: 972997
Change-Id: Ie7f6d84d61000595eaa53a660caff7b98b0fb17c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649778
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668440}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662557
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#371}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[m76] Cross-Origin-Resource-Policy shouldn't apply to Save-Page-As.
This CL makes sure that download requests initiated by
content::SaveFileManager::SaveURL use
network::mojom::FetchRequestMode::kNavigate mode (rather than the
default kNoCors mode).
TBR=lukasza@chromium.org
(cherry picked from commit d84fd3d687cccbd66e0996e08a3623721532c9ec)
Bug: 974312
Change-Id: Ica57a78ca96d7a76e95e87c8f6c0b4db74f3de94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660882
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669410}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662735
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#370}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Mash cleanup: remove more functions from mojom::LoginScreen
TBR=estade@chromium.org, tsepez@chromium.org
(cherry picked from commit 481f244592236367330cb53f4fe5092f378110a5)
Bug: 958206
Change-Id: I66b1924d9ab0d49047a7ee3fe8d1b696b74ed726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637865
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665171}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661666
Cr-Commit-Position: refs/branch-heads/3809@{#369}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[GID] Add RecordUserAction to account users tapping on Identity Disc
I'm adding Toolbar_IdentityDiscClicked action.
BUG=973629
R=twellington@chromium.org
(cherry picked from commit 4e0368b2d1d99c9a7fcab14859ce8e519ed1fe6b)
Change-Id: I592a0ad6a3359372718aeda69c5ef44525397984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656073
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669377}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661667
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#368}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Introduces a workaround for a hung that occurs when using autofill with accessibility
When Chromium automatically places an autofill suggestion in a text field, the value attribute of the text field does not update immediately.
Even though the value update should have been sent to the renderer, the accessibility tree on the browser doesn't update as soon as the autofill suggestion has been committed.
As a result, on Windows and Linux ATK, the text field's hypertext is empty, because it is retrieved directly from the text field's value.
However, the user-agent shadow DOM inside the text field contains a static text object with the autofill suggestion that has just been committed, whose hypertext is not empty.
When computing a parent equivalent position from an AXPosition after the static text object that represents the autofill suggestion, a position that is in the text field is correctly returned.
However, that position's text offset now holds a seemingly invalid value, because according to the hypertext of the text field, the field should contain no text.
This breaks all the comparison operators in AXPosition, because the above results in an infinit loop in the CompareTo method.
The proper fix is to update the hypertext of the text field in AXPlatformNodeBase to include the text of any autofill suggestion, (committed or uncommitted).
Alternatively the value attribute should be updated as soon as an autofill suggestion is committed.
However, both of this fixes are risky for M75.
A workaround has been introduced that tries to detect invalid text offsets in AXPosition::CreateParentPosition, and return a position at the start of the text node instead.
R=aleventhal@chromium.org, frpoole@microsoft.com
(cherry picked from commit d4b62c604f890e756a1cd71b2f3ec1816f1753d2)
Bug: 973722
Change-Id: I3786ee0cf9f0e9d83efc15c14702f242a8ba7851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661548
Auto-Submit: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669506}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660845
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#367}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
IconOrFavicon metrics
(cherry picked from commit 666018f9e8a02ef6966ac1d63b9560fecc90956d)
Bug: 960469
Change-Id: I50845a7d20bd5b2e2a19f94c9e4d48cd1200ee6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650793
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660692
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#366}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Override IsInputLocaleCJK() in InputMethodWinTSF.
We should return true in InputMethodWinTSF::IsInputLocaleCJK() if
current active input language is Chinese, Japanese and Korean.
TBR=siliu@microsoft.com
(cherry picked from commit 9ff13081c1766eac6edc574d3af12e72519e8091)
Bug: 965319
Change-Id: Iac359a9d435efc16760e0b5f28da58aa0615054b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637921
Commit-Queue: Siye Liu <siliu@microsoft.com>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669065}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662501
Reviewed-by: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#365}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add null check to main frame check in samesite deprecation messages
There seems to be a race condition where cookies are called to be
stored or sent on a page that somehow navigates to a interstitial page,
causing WebContents::FromRenderFrameHost to return a null pointer that
is then dereferenced. Because we definitely don't need messages from
interstitial pages (and console messages shouldn't be sent after the
page has navigated away anyways), simply returning early would be
expected behaviour anyways.
(cherry picked from commit 0485879974204691438021c15bf7e7df9ba03edc)
Bug: 973574
Change-Id: I4777e36baf7737bcd4d73d36840fa671e34a2ed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658688
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669331}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662729
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#364}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Use IMM32 instead of TSF on Win10 RS2 and below.
This is a workaround for a bug in Windows Input Service. The bug is
fixed from Win10 version RS3 and above. It takes time for the fix to be
serviced for all downlevel Windows platforms. Alternatively, we can use
IMM32 instead of TSF on all affected platforms so that users won't hit
the crash immediately after this change.
TBR=siliu@microsoft.com
(cherry picked from commit a16b6d1ec9239abf2c497db5595c1f7ca9ed9ffe)
Bug: 973329
Change-Id: I16d28091cf7699fa0563a610cc47d08989bc7951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660961
Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Commit-Queue: Siye Liu <siliu@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#669525}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662023
Reviewed-by: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#363}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Merge 3809: [LayoutNG] Fix float + nbsp to create a break opportunity
Floats should create break opportunities, and
|NGLineBreaker::Rewind()| assumes this. However, |nbsp|
after floats suppressed the break opportunity, which caused
NGLineBreaker to loop infinitely under certain conditions.
This patch fixes floats to allow break after them.
Note the new behavior is the same as Gecko.
(cherry picked from commit 7b1e6a920eb103abedf45c95f5d86dda52d8713c)
Bug: 972421
Change-Id: Ie8c1d7927c5c282078a20f90941398149ea702a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653171
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668681}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660076
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#362}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add a "kill switch" Finch flag for backdrop-filter
This enables a user-visible flag for backdrop-filter, so that
Finch can be used to disable it in the field if needed.
(cherry picked from commit c166cf1cb6c33471500b3ee7cda2c5f375c980d7)
Change-Id: Ieb6388b1f2f4f3daebc81d2775c816a423f5642b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658992
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669313}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662632
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#361}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix the use of RENDERER_SKIA_VK where it isn't supported
Prior to this CL, the build was broken for Windows Arm64 and
Windows x86, and Jumbo/non-Jumbo builds. See comment at [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1660122
(cherry picked from commit 9d54112ed3ba48ca4d10f2fc3c7a8acd381799be)
Change-Id: I2cc0a84dd94f119c11a556c9670c261ca3086e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660958
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669408}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662631
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#360}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Set link highlight effect to target opacity.
When the link highlight animation finishes, there is a race to remove
the link highlight node before it is renderered at full opacity. If the
finished function is not called in time we see the highlight blink.
Avoid this by setting the effect node to the end opacity.
(cherry picked from commit d03ff4b86983089940d824c98fd11b002c54752b)
Bug: 974160
Change-Id: I597629ee7457cc3bd77493ea87ed29e2916855fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661159
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669431}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661479
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#359}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Flip PiP and NightMode back.
Copy-pasta error made prefers-color-scheme always return dark on
Android.
(cherry picked from commit d97d1c48d92cfa7f6a93f54e730308ce1171a4c2)
Bug: 973768
Change-Id: I1af1a18405155c409e8b9752ba7f86cc97918472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657834
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668832}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662414
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#358}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Remove downstream NQE monitoring
This is no longer used and can be removed.
(cherry picked from commit e7918bac25137dcd0771e1df0ebeaf6bcd753603)
Bug: 974298
Change-Id: I485dffcc549e202bde603af75613e0803bb12f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660701
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669353}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661763
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#357}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Don't draw layer in kDstIn blend mode in resourceless software draw mode
Resourceless software draw mode doesn't support non-kSrcOver blend mode
if source is not a render surface. We should not draw in the case
because the fallback to kSrcOver would result a black mask on the
destination.
TBR=wangxianzhu@chromium.org
(cherry picked from commit 8540de427cab80ac0bf07ef57bae612e1b87d69c)
Bug: 973697
Change-Id: Ieaa9e612fe09512e925337ec131ced7594d64627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661289
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669512}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661979
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#356}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
ServiceWorker: Make fallback path respect OOR-CORS feature flag.
ServiceWorker subresource fallback currently has a work-around for CORS
requests. Because CORS has been implemented in blink in the past the
code had to message back into blink in order correctly perform CORS
on the fallback request. This create performance problems.
This CL skips this fallback workaround if the out-of-renderer CORS
(OOR-CORS) feature is enabled.
(cherry picked from commit f4a5443444cea0e368e895448239faa0d61ede49)
Bug: 973633
Change-Id: If8a3510291639fda359fd425c2e08173f2a87cf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658868
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669091}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660286
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#355}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Remove early exit from LayerTreeHost::AnimateLayers for BGPT
Running LayerTreeHost::AnimateLayers from the main thread is necessary
in order for the main thread KeyframeModels to progress from
WAITING_FOR_TARGET_AVAILABILITY to STARTING. Failing to advance to this
state results in the cc KeyframeModels never being removed as the
animation is still considered current and needing to affect the
pending tree.
(cherry picked from commit 93fe205c2143050ee45027cb1a3e926905373067)
Bug: 762717,962346
Change-Id: Ia559c0a7e3c73e12cc883e64fb4adb284a924418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1256422
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669075}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660638
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#354}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Expose getTouchlessUiCoordinator from ChromeActivity
To be used by a downstream followup patch.
(cherry picked from commit 87a195f99482e93293935e630e2514baa5b856bf)
Bug: 974244
Change-Id: If225088e5dcd5401eeba4717b06702a36319efc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659981
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669681}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661978
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#353}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge to M76] [ThreadPool] Add thread annotations to TaskTracker::shutdown_event_ and fix missing lock.
Extracted from https://chromium-review.googlesource.com/c/chromium/src/+/1655093
since we should merge the missing lock to M76.
TBR=etiennep@chromium.org
(cherry picked from commit 1b0545fab9ed0c2cdbb0d23b0f39dff8d320f08f)
Bug: 698140, 839091
Change-Id: I46e102eeb7b12743393c066b0bb2e184f982124b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655988
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669119}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660813
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#352}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
ui/gl: Ping watchdog thread for slow GL operations from skia.
Add progress reporter pings for more slow ops in skia GL bindings. This
is based on comparing crashes between GPU and OOP raster experiment on
mac.
R=piman@chromium.org
(cherry picked from commit fdfe99289485e1e0715689a70646541785b02761)
Bug: 969623
Change-Id: Ife1e3398635d3e47ef09f2b1f8890cb2853e0ff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641806
Commit-Queue: Khushal <khushalsagar@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665754}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660812
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#351}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
ui/gl: Ping GPU watchdog thread during strike deletion.
Ping the watchdog thread for Gpu_main during strike deletion to avoid
hangs on mac.
R=piman@chromium.org
(cherry picked from commit 39641b9ee613ec96fa55b423dcad85ee7baa237d)
Bug: 969623
Change-Id: I36faa00db502e1b1cf0bbda262e5aaadd96f2cbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641602
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665660}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662598
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#350}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
gpu: Detect consecutive surface initialization failures on Android.
If we fail to initialize the GLSurface associated with an ANativeWindow
the error is propagated to the browser so we can retry with a new
window. Add tracking to detect consecutive failures with this retry
to avoid a perpetual retry loop.
R=boliu@chromium.org, ericrk@chromium.org
(cherry picked from commit a7888b8e05a614c646460569bd3b6d93319066c8)
Bug: 972667
Change-Id: Ieaf0a7c7454f12ffbfa068e7c17c452857776ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654233
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668479}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662497
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#349}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Ensure spat nav doesn't use an enter key press that was already used.
Some elements click on down or press, and spat nav clicks on up, so if
the down or press for an enter key event were handled, we shouldn't also
handle the up as a click.
(cherry picked from commit cdd0902ffcf59a4ecea78dc81d5a7751c37e30c7)
Bug: 973520
Change-Id: I2017da39b97d205e5dab4fa39c5b05e666e8677a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656014
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669314}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662495
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#348}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Re-enable MESA_framebuffer_flip_y extension
BUG=964010
(cherry picked from commit bb06cb374591bb848cb5cae6815a2456c2df911f)
Change-Id: Ie096562c2363e72518c368d546f1d8ef4f92655a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656451
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668629}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661456
Cr-Commit-Position: refs/branch-heads/3809@{#347}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Skip recodring UMA stats if the WindowResizer is destroyed during drag.
Resizer can be destroyed during drag when the dragging window is attached to the browser.
Exact repro step is still unknown though. I've tried various scenario but the bounds'
size was always same as original bounds' size.
(cherry picked from commit abae051fa676f620766e2cb1d15674cd2e6719ad)
Bug: 970911
Test: None. Repro step is unknown and this is speculative fix.
Change-Id: I92c8ad1307ae14f1c0d2cad8b77678da3b61690e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658679
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669376}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662536
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#346}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Revert "Move break_token_ to NGPhysicalContainerFragment from NGPhysicalFragment"
This reverts commit 4386eb056f61e7b335842145acd1b38f5eb8f1b0.
Reason for revert: Breaks beta builds, crbug 974731
Original change's description:
> Move break_token_ to NGPhysicalContainerFragment from NGPhysicalFragment
>
> This patch moves |NGPhysicalFragment::break_token_| member to
> |NGPhysicalContainerFragment| to reduce size of |NGPhysicalTextFragment| since
> |NGPhysicalTextFragment| never has break token.
>
> TBR=yosin@chromium.org
>
> Bug: 962108
> Change-Id: I9f86c413c01932dfaed5d55933b490deaddbde1a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662095
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3809@{#336}
> Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
TBR=yosin@chromium.org
Change-Id: I89b7d0af4ec1799b132b66277a98659086d683c7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 962108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661372
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#345}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Revert "Allocate vector of NGOutOfFlowPositionedDescendant in NGPhysicalContainerFragment only unless empty"
This reverts commit 4d4db721329b19642d3d5ff06f084352817a5762.
Reason for revert: Breaks beta builds, crbug 974731
Original change's description:
> Allocate vector of NGOutOfFlowPositionedDescendant in NGPhysicalContainerFragment only unless empty
>
> This patch changes |NGPhysicalContainerFragment| to allocate vector of
> |NGOutOfFlowPositionedDescendant| only if it is not empty for reducing memory
> usage.
>
> TBR=yosin@chromium.org
> Bug: 962108
>
> Change-Id: If807348f4f9842e138a7fe3ae3491094e510ea73
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661320
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3809@{#337}
> Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
TBR=yosin@chromium.org
Change-Id: I24603da25e9510a7ac8c7686965a0bc8f6518cbe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 962108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661663
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#344}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Revert "Allocate memory for borders and padding members of NGPhysicalBoxFragment if needed"
This reverts commit d91d4f3cdb39fc6157a1a05b8353110ecce8c5d4.
Reason for revert:Breaks beta builds, crbug 974731
Original change's description:
> Allocate memory for borders and padding members of NGPhysicalBoxFragment if needed
>
> This patch changes memory layout of |NGPhysicalBoxFragment| based on value of
> borders and padding as
> - No borders and no padding
> |NGPhysicalBoxFragment|, children[]
> - having both borders no padding
> |NGPhysicalBoxFragment|, children[], borders, padding
> - borders and no padding
> |NGPhysicalBoxFragment|, children[], borders
> - no borders and padding
> |NGPhysicalBoxFragment|, children[], padding
> for reducing memory usage, since borders and padding are frequently zero.
>
> (cherry picked from commit 8318aa75176654769ece376cd71fd9fc5deef823)
>
> TBR=yosin@chromium.org
>
> Bug: 962108
> Change-Id: I2af0ed3a3c3f111d2d4cd567073ebcba628c7279
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662094
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3809@{#335}
> Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
TBR=yosin@chromium.org
Change-Id: I99119543d16950d287ba0497b5850c91e9c1cb5c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 962108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661662
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#343}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Merge 3809: [LayoutNG] Fix selection rect to unite text and line
When LayoutNG tries to extend the selection rect to the line
height, the height is set to the line height instead of being
united. It made the selection rect smaller when the line has
smaller height than the text.
This patch fixes to unite.
(cherry picked from commit 15155458fc6f1d089356e1729fc8a41bd25fb546)
Bug: 973302
Change-Id: I6a2ef38b0f682cc7d3f91858ecbcaf4a88ec819c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657879
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668983}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660075
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#342}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Feed] Record whether viewed and opened articles are offline.
(cherry picked from commit e40a9f41ccc5f102ccf47b4267137900bc24f664)
Bug: 968593
Change-Id: I36e7e7b891e3a72492bee147444531b480107928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656248
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669405}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661661
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#341}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Feed] Initialize Feed after parameterized delay.
(cherry picked from commit 88a133daeeba2de8da5fcaa2492373acde9fdf60)
Bug: 968611
Change-Id: I1816950bef9db9b6b85203035cf62fc708f7e467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644012
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666492}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660281
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#340}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix CCA create black video thumbnail bug
Bug: 936589
Test: The thumbnail can be created and shown correctly under all capture
modes.
(cherry picked from commit 67fa9ba68c0d514b156956a58b10413513dce6d4)
Change-Id: I5cd963d60bc7f03916a945a41e3e33ba05def660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657514
Reviewed-by: Sheng-hao Tsao <shenghao@chromium.org>
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668715}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662107
Reviewed-by: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#339}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
OOR-CORS: Remove required headers even from cors_exempt_headers
Header removals for members in cors_exempt_headers are handled
in the network delegate API layer if NetworkService is not enabled.
But once NetworkService is enabled, it is handled at an upper layer
module than NetworkService.
It still works because NetworkService does not see the exempt
headers on redirects. But once OOR-CORS is also enabled together,
CorsURLLoader will make another request with the original
network::ResourceRequest for cross-origin redirects, and it
results in cors_exempt_headers being merged again into the new
request headers for the redirect.
To avoid this issue, we need to remove required headers from the
cors_exempt_headers too in FollowRedirect.
(cherry picked from commit 764b5b79e90d998ef93a34e09b97d62b3b2ac429)
Bug: 973509
Change-Id: Ic44bb7f759ea637a4b25046a42204b60ba4b3cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657854
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668783}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662096
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#338}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Allocate vector of NGOutOfFlowPositionedDescendant in NGPhysicalContainerFragment only unless empty
This patch changes |NGPhysicalContainerFragment| to allocate vector of
|NGOutOfFlowPositionedDescendant| only if it is not empty for reducing memory
usage.
TBR=yosin@chromium.org
Bug: 962108
Change-Id: If807348f4f9842e138a7fe3ae3491094e510ea73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661320
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#337}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Move break_token_ to NGPhysicalContainerFragment from NGPhysicalFragment
This patch moves |NGPhysicalFragment::break_token_| member to
|NGPhysicalContainerFragment| to reduce size of |NGPhysicalTextFragment| since
|NGPhysicalTextFragment| never has break token.
TBR=yosin@chromium.org
Bug: 962108
Change-Id: I9f86c413c01932dfaed5d55933b490deaddbde1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662095
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#336}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Allocate memory for borders and padding members of NGPhysicalBoxFragment if needed
This patch changes memory layout of |NGPhysicalBoxFragment| based on value of
borders and padding as
- No borders and no padding
|NGPhysicalBoxFragment|, children[]
- having both borders no padding
|NGPhysicalBoxFragment|, children[], borders, padding
- borders and no padding
|NGPhysicalBoxFragment|, children[], borders
- no borders and padding
|NGPhysicalBoxFragment|, children[], padding
for reducing memory usage, since borders and padding are frequently zero.
(cherry picked from commit 8318aa75176654769ece376cd71fd9fc5deef823)
TBR=yosin@chromium.org
Bug: 962108
Change-Id: I2af0ed3a3c3f111d2d4cd567073ebcba628c7279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662094
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#335}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add a method to query if an app is installable in the Play Store.
This CL adds a new method on app.mojom that allows Chrome OS to query
ARC for whether a given package name is currently installable.
BUG=969560
(cherry picked from commit 005c16e190882cd9a3e18a36e8f489c4ebae1b38)
Change-Id: Ia525a92944b9b4afb4fd5f6a1ccb150e931a22ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640917
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666171}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660293
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#334}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.33
TBR=mmoss@chromium.org
Change-Id: I0292fcb965bf878ad1f43a454bae08da9265ddf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661258
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#333}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Reland: Add traits to ChainedTasks so we can prioritize accordingly.
The problem with mojo that lead to the revery has been fixed.
Original path: https://chromium-review.googlesource.com/c/chromium/src/+/1517707
Both usages count as bootstrap tasks which will be prioritized by a
subsequent patch.
(cherry picked from commit 8ed84293465fa4eba6a3416729c7a121ff706e96)
TBR: yfriedman@chromium.org
Bug: 863341, 974006
Change-Id: I95cae97d1b8e8d9ed5cdab3b8bd323b5c38d3026
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617771
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666687}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661311
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#332}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.32
TBR=mmoss@chromium.org
Change-Id: I5f25e804d721ff6a46a86dda954d630de0796904
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661550
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#331}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix CopyOutputResult StructTraits.
The CopyOutputResult deserialization code would fail when provided with
an empty RGBA_TEXTURE format result. An empty result is generated if a
CopyOutputRequest isn't satisfied. Fix the Read() function and add a
test for serializing then deserializing an empty RGBA_TEXTURE result.
This is the most likely culprit for CopyOutputResult deserialization
errors on Chrome OS with OOP-D enabled.
(cherry picked from commit f241468eda62431200c20f5fdda7181683e10311)
Bug: 967856
Change-Id: I6d17ba4eb7a0e17e59980c81ad0fa1f94a5cfbd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653033
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668052}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660943
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#330}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add feature flag to control IAudioClient3 support on Windows
This will allow an easy way to enable or disable IAudioClient3 support.
(cherry picked from commit 6109ef51e5f2a4b018a920470e547da46da72159)
Bug: 972579
Change-Id: Ie6658c7c8ef0a002b339b29988df478991078ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651727
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667598}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660658
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#329}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
canvas: Set origin to upper left when using GL_MESA_framebuffer_flip_y
GL_MESA_framebuffer_flip_y extension y flips the framebuffer, so
when transferring to skia make sure the orientation is correct.
(cherry picked from commit 085ea3f6f4852b09fa02d2ba3f82a48e9ed059a7)
BUG: 961791
Change-Id: Idb77c4dcc872ba648415c7823ca40639c7cf27eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644173
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666984}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661081
Cr-Commit-Position: refs/branch-heads/3809@{#328}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
cmaa : Flip internally allocated framebuffer
MESA_framebuffer_flip_y needs the allocated framebuffer
to be setup to the same orientation.
BUG=964010
TEST=https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-size-change.html?webglVersion=2
(cherry picked from commit e78b3019120dd19bcff7d853e89976e9be343146)
Change-Id: If7b7aaec176387e47c46c4f7337d686536375e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641666
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666113}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660785
Cr-Commit-Position: refs/branch-heads/3809@{#327}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.31
TBR=cmasso@chromium.org
Change-Id: I247a526b0b1aef15fe8d3b46e74bb585f2bad029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661368
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#326}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Adjust rectangle for flipped sources in TexImage2D
When the source is a WebGL canvas the rectangle must
be adjusted for flipping with MESA_framebuffer_flip_y.
BUG=964010
TEST=https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html?version=2.0.1
(cherry picked from commit b6ab4acc0ac3a4b2c72bbe92e73f50b067de5d5c)
Change-Id: I20f5ac0a5049b23b3033a6d46f53606886f4e4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627555
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665193}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660960
Cr-Commit-Position: refs/branch-heads/3809@{#325}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
WebUI: cr-slider change event should send value
- cr-slider has never sent the value to cr-slider-value-changed
- When cr-slider replaced paper-slider [1] as the backing for
settings-slider it caused an empty event details to be sent
- Display zoom tries to read the value in onDisplaySizeSliderDrag_
(display.js) [2] and gets undefined.
- This caused calculations with the zoom value to use undefined
which resulted in displaying NaN
- Added test to cr-slider
[1] - https://chromium-review.googlesource.com/c/chromium/src/+/1362245/17/ui/webui/resources/cr_elements/cr_slider/cr_slider.js
[2] - https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/device_page/display.js?q=onDisplaySizeSliderD&sq=package:chromium&g=0&l=729
BUG=chromium:932007
TEST=browser_tests --gtest-filter="CrElementsSliderTest.*"
(cherry picked from commit 3f38f7f9d25d8ae5b161bf99711a5a20e5daa450)
Change-Id: Iac2fb4d63d0df09d95bdcfffd72c329afd30297b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652554
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668495}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661032
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#324}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless]: Update center apps icon title from "All apps" to "Explore apps"
(cherry picked from commit 656e94d7bb292f2f2421cd3d355f71f445a1994a)
Bug: 974122
Change-Id: Ia4ce2d08fc5c6952864ed2667db1bbe03e5ab863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660019
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669282}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661189
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#323}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Revert "Fix module install"
This reverts commit 8be5aea664dd5872079df13b36f34d9aa41a36cb.
Reason for revert: The cherry-picked commit causes crashes on startup (assertion failure) when running on debug builds.
801cc00b4ec4 Fix module install - crashes on startup
05c5bcb74e2a Do not block logon hours for AD accounts - works (parent of 801cc00b4ec4)
Original change's description:
> Fix module install
>
> Previously, we created a SplitInstallManager _before_ calling
> SplitCompat.install(-), which breaks the module install flow on Android
> pre-Q.
>
> (cherry picked from commit 801cc00b4ec48cfcfbbd48a441d59d48892f7c48)
>
> Bug: b/133669491
> Change-Id: I0b317732ed364a592047eeb7387c74dd1ea1b258
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646903
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#668416}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658958
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3809@{#295}
> Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
TBR=tiborg@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: b/133669491
Change-Id: If3273a82806c5117611e56ce18c5de6961728b2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661001
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#322}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Updating XTBs based on .GRDs from branch 3809
TBR=meacer@chromium.org
Change-Id: Ifadeda0244213017efccb84669b75d9df19af8d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660784
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#321}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Mirroring Service] Update capture resolution selection algorithm.
This change updates the capture resolution algorithm to reflect the changes made
in the component extension Javascript. It also refactors the code for
testability and adds the same test cases that were added to the extension.
(cherry picked from commit 9481c8a22142182d10d4a8cb771e7175379a5ed2)
Bug: 969873
Change-Id: I6040c5cf837fb20478d6d1294fe224b505097464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652214
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668123}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660923
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#320}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Make sure 'Android storage' link is always shown when ARC is running
This fixes a problem introduced in CL:1592713. Without this fix,
'storage-android-running-changed' is sent to JS only when either
of the following happens:
- AllowJavascript() is called.
- ARC is fully started.
- ARC shuts down.
However, storage-android-running-changed's listener on the JS side
is registered only after AllowJavascript() is called. Because of
this, if the Settings app is launched in the following way,
|androidRunning_| variable in storage.js remains false and the
'Android storage' link never shows up.
1. Sign in.
2. ARC is fully started.
3. Settings app is launched. |androidRunning_| variable is false
at this point.
4. AllowJavascript() is called.
5. 'storage-android-running-changed' is sent to JS, BUT there's
no listener.
6. The user moves to Devices > Storage management.
7. storage-android-running-changed's listener is registered.
8. The JS sends 'updateStorageInfo' to the C++ side, but the C++
handler doesn't fire storage-android-running-changed.
This CL changes the C++ handler code so that HandleUpdateStorageInfo()
fires storage-android-running-changed with the up to date ARC status.
The C++ handler used to do that, but CL:1592713 removed it by
mistake. This CL restores the code.
BUG=968580
(cherry picked from commit 7068b8ad93d561e3b9cd3d9620cf8066e99d571b)
Change-Id: If1d0a6d1597bffcb37b82c1e4c44746c4c201106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637038
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665170}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661115
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#319}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Ensure JankTracker uses object's PropertyTreeState
Previously, we used the PaintLayer's LayoutObject.
Xianzhu pointed out that there can be cases where a LayoutObject does
not have its own PaintLayer, and that we should instead use the
PropertyTreeState directly associated with the currently painting
object.
(cherry picked from commit 1d53d79569b70f1cf90729814b78ce251d0b58fa)
Change-Id: I4daf0d1f03507ca45f3e78bf2d3f93b4b6848efd
Bug: 971639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644939
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667309}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660699
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#318}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix the case where an element contains both filter and backdrop-filter
Previous to this CL, if an element was styled with both filter and
backdrop-filter, the filter effect was not properly applied to the
filtered backdrop contents, because a separate filter property node
gets created for the filter, and the backdrop-filter effect node
does not contain the filters. With this CL, paint_layer appends
the filters to the backdrop-filters list, so that Viz has access
to those.
TBR=masonfreed@chromium.org
(cherry picked from commit 1ff21a43a07257ccc2f56da17e03c0c74b2f070c)
Bug: 973907
Change-Id: I255b73433d75e0551d817134fa50d5e0e35b87df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658654
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#669006}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660944
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#317}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Remove expansion of backdrop-filter input for pixel-moving filters
See [1] for the PR for the spec change. Essentially, with this CL,
the input to the filter will be the bounding box of the element
with backdrop-filter. The bounds will not be expanded for pixel-
moving filters, and will not include extra border for children.
Note that the rebaselined layout tests are all for very small
single-pixel errors, except for backdrop_filter_blur_outsets.png
and backdrop-filter-boundary-expected.png, which change because
of this new behavior.
This needs a (small) spec change, but it will be beneficial in
these four ways:
- It agrees more closely with existing Safari behavior.
- It improves performance, by filtering fewer pixels in the
case of pixel-moving filters.
- Developers have been disappointed with the existing behavior
of bringing in pixels from outside the bounds of the
element, and have requested a way to turn this behavior off.
See the discussion starting at [2].
- It eliminates the problem of crbug.com/972173, where content
outside the renderer viewport can get dragged into the filter.
[1] https://github.com/w3c/fxtf-drafts/pull/342
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=497522#c196
TBR=masonfreed@chromium.org
(cherry picked from commit 16f5c5ac41dcf6415c1e1a4ab916f693ba850a25)
Bug: 972173,497522
Change-Id: I18cc6d08cf9fde263b9e166b5e96ea57a1c41973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650418
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668894}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660122
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#316}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[css-flexbox] Make sure to layout overflow:auto elements
For overflow: auto, we need to layout before running the flex algorithm
if layout is dirty, so we can up-to-date scrollbar information, because
scrollbar size is included in the intrinsic size.
(cherry picked from commit 408ad4e0f177e8f6116963387576edd3f33c6e45)
Bug: 972227
Change-Id: I58b5c0590575c5babc505b2927d8464f3f540775
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652198
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668199}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660788
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#315}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Rounded images and transition animations for Entity Suggestions.
This change addresses styling issues with Entity suggestions:
- introduces rounded corners and
- transition animation for Entity suggestions.
Bug: 973986
Change-Id: I3151a6b5718bf5324dba844c62dc19ca34f71819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659617
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#314}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.30
TBR=mmoss@chromium.org
Change-Id: I0a96802be006d255b981eb3163adc35f79d98d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660710
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#313}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Support ad block infobar for touchless
TBR=mdjones@chromium.org
(cherry picked from commit f54b27814f5656232ecae5fc5bd5486963cd6a0f)
Bug: 973550
Change-Id: I65db611c07f035d657db1b54de12fe82df347762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656468
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668559}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660199
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#312}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Reland "[Autofill Assistant] Disable Autofill Assistant DFM."
This is a reland of acf2c143afa6ff41b05c7748deb082017b92f653
Original change's description:
> [Autofill Assistant] Disable Autofill Assistant DFM.
>
> This CL disables the Autofill Assistant DFM by default, to make sure
> that the Autofill Assistant will be working once M76 is promoted to
> beta.
>
> Bug: 957582
> Change-Id: I59f79f6abaeeb615818dbec7ae7fbe8148925aa6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642557
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3809@{#67}
> Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Bug: 957582
Bug: 973473
Change-Id: I24bb7cc704ef5cd386e69230fa5dc898735848a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655292
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#311}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Reduce gradient padding of CCA mode selector.
Fix text area of third mode item may be obscure, when mode selector
scroll to topmost position by reducing gradient padding by 8px. And thus
increase original visible text area from 3px to 11px.
Bug: 973724
(cherry picked from commit 9e3a40b90bb64f211ac5e4a613b690000cbec69a)
Change-Id: I9e49112f42759293908a6c5bfcd4e599e77705fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657373
Reviewed-by: Sheng-hao Tsao <shenghao@chromium.org>
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668746}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659656
Reviewed-by: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#310}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge to M-76] Virtual Desks: Fix multi-profile behavior
- Windows from an inactive user should not show in the desk's
mini_view.
- Regardless of the their desks, windows of the inactive user
should remain hidden.
TBR=jamescook@chromium.org
BUG=972765
TEST=Manual, added new test.
(cherry picked from commit 36e697d0e450ad340c119570edade7449011c109)
Change-Id: I0dc3b7b65fce390430b5a4b8c1ae11b74b831311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653839
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668181}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659855
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#309}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.29
TBR=abdulsyed@chromium.org
Change-Id: Ife65e82a5c8ef10054dc3e925e23d88f3f23d621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658683
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#308}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Partial revert "Make IsSyncRequested false by default"
This reverts commit 8c872e02bbc75b817e036ed714ae652e3f638fa8.
Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=973770
Note: This CL does not revert the changes the the test files as
instructed by treib@ who is the author of the original CL.
Original change's description:
> Make IsSyncRequested false by default
>
> Before this CL, the value of IsSyncRequested was essentially undefined
> while Sync was disabled: It was true by default, but false if the user
> had previously enabled Sync and then disabled it again.
> This CL resolves the inconsistency by making it false by default.
>
> Bug: 906034
> Change-Id: I2ce92f5df5ebb38a34ebde43d471839ad1184961
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508453
> Reviewed-by: Jan Krcal <jkrcal@chromium.org>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#642447}
TBR=treib@chromium.org,jkrcal@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 906034, 973770
Change-Id: I501f563cae8ff63de21cd66d933281e0af9542ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658571
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Kariah Davis <kariahda@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#307}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix StreamTexture size
crrev.com/c/1629792 relies on the LevelInfo being properly set even for
GL_TEXTURE_EXTERNAL_OES. This wasn't true for StreamTexture, as while
it sets up the LevelInfo, it does it before it knows the size, and we
end up with a zero-sized level which we consider as unrenderable.
This CL updates the LevelInfo as soon as we know the size.
(cherry picked from commit 2a27c84086b0e81685427feb13f3b466fef0136f)
Bug: 972805
Change-Id: Ie29a05f603f14c3ebd618a864c376533a07e457f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652574
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667889}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658957
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#306}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Preconnect to litepages on Chrome startup
This CL will be merged to 76 and replaced with a more robust prober in
77.
(cherry picked from commit c530348dc61d1e396941e930a02942d48bdb36c5)
Bug: 973916
Change-Id: I0661d99769f018c5b2fd93e22e52f6fc675e4fad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658709
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668917}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658938
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#305}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Don't trigger HTTPS Previews unless there is a chrome-proxy header
(cherry picked from commit b8b8b0aec3606c7c9d4f1934c70e34b25b621e94)
Bug: 972756
Change-Id: I18e4716e31859f171a29edbfd70a19f86f24c708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652422
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668654}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658936
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#304}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Make web apps with a supported related app intent to the store.
This CL allows Chrome OS to query ARC for whether a PWA has a supported
related app available and installable. If it does, the installation
action redirects to the Play Store. A Finch kill-switch to disable the
behaviour is also added.
BUG=969560
(cherry picked from commit 7027a4a8aa691300f97edfaa46834e1aa4bec884)
Change-Id: I7f2d748836400aecec40655e25de0e2f901c4432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642753
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666623}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659548
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#303}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.28
TBR=benmason@chromium.org
Change-Id: I25c65f7086b20e02abc265ad837a2cb29dbd194c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659273
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3809@{#302}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Sync::USS] Properly Untrack password not added to the password store
Before this patch:
Passwords were untracked using their client tag which is wrong.
After this patch:
Passwords are untracked using the has of their client tag.
(cherry picked from commit c76393cc400ac59ec476dfb9ad0168497cacc574)
Bug: 973053
Change-Id: I090f4c357b46cb3a6650594bf53133356da5e72c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652938
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668022}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659408
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#301}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix null dereference in shelf views
Tablet mode controller is destroyed slightly before shelf widget in
Shell destructor. Nullptr check is needed, because IsTabletModeEnabled()
can get called when shelf is being destroyed.
(cherry picked from commit 1b11ca42d8ec3be09f88c70bab2a7784f748ce6e)
Bug: 967149
Change-Id: I42b6abd6cf24902cc1647d03dd813b070d9aec05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637982
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665126}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652217
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#300}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Revert "Give users the option not to auto connect to WiFi networks."
This reverts commit e6926742006fcf847e5f091f89be251a715c6755.
Reason for revert: This feature was not finished before branch point so I'm pushing it back to 77.
Original change's description:
> Give users the option not to auto connect to WiFi networks.
>
> In order to auto connect to hidden Wifi networks, CrOS must broadcast
> the SSID of the network to see if it's available, which leaks
> information about what networks the device is configured to
> auto-connect to. This page gives users the option of whether or not to
> auto connect to a WiFi network when first configuring the network, and
> provides a warning that auto connecting to a hidden network is bad from
> a privacy point of view. A pop up dialog with a longer explanation
> about why auto connecting to a hidden network is bad from a privacy
> point of view will be included in a later cl but is currently blocked
> on a CSS bug (crbug/954202).
>
> Change-Id: I0abd56ff2b3a57ec77f31feb6b66d800cf2ebeb6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476090
> Commit-Queue: Melissa Galonsky <mgalonsky@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656767}
(cherry picked from commit f1a792d5b7a5e56718ae2144a8ea4974d89ff560)
Bug: 903908
Change-Id: I02740cec60bfd0e7a23032d732752cf252616b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655395
Commit-Queue: Melissa Galonsky <mgalonsky@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Melissa Galonsky <mgalonsky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668761}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659015
Cr-Commit-Position: refs/branch-heads/3809@{#299}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[CrOS Network] Fix button focus issue in <internet-detail-dialog>.
Previously, when users who navigated the dialog via the keyboard (i.e.,
using the Tab key) pressed Enter on the connect and/or disconnect
button, focus would be lost. This was due to the fact that the UI
actually had 2 buttons (connect and disconnect), and one is hidden when
the other is visible. Thus, when users would click one button, it would
immediately become hidden and its focus would be lost.
This CL fixes this issue by having both connect and disconnect share a
single button which remains visible and retains focus after the Enter
key is pressed.
(cherry picked from commit 0e03d82ff8aba70e6c8dee0de68c2a2ce2b6298f)
Bug: 971213
Change-Id: Ifd5c29946ab86ce95548fe6d95e5c3c6738f4976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655977
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668537}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659271
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#298}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
cros: Add WindowFocused user action to the applist.
PM and outside teams want to be able to understand launcher usage. One
key metric is the 'click through rate' (CTR) of the launcher. To
accurately calculate this, we need to know how many times the launcher
is shown to the user.
The most dependable way to measure this is to record when the applist
window gains focus.
(cherry picked from commit 61e72dff7876db8c338084f80792e0584006154f)
Bug: 962725
Change-Id: If06fb022c2bf43cd3af9901353bf3bdcc438d197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635361
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Kevin Strohbehn <ginko@google.com>
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667821}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659229
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#297}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Check before removing render pass resource
Replce the DCHECK in SkiaOutputSurfaceImpl::RemoveRenderPassResource()
with a test to see if the render pass has an entry in
|render_pass_image_cache_| before trying to remove it.
There isn't a known repro for this crash, but I suspect that using a
bypass to draw the quad in SkiaRenderer::DrawRenderPassQuad() can cause
the circumstances to arise. An entry for |render_pass_image_cache_| is
created in MakePromiseSkImageFromRenderPass(), but this is skipped if
a bypass quad is used, causing a difference between the render pass maps
in SkiaRenderer and SkiaOutputSurfaceImpl.
(cherry picked from commit a7a1388ba01980a42908b301432262d63879ed60)
Bug: 959071
Change-Id: I4765f57eb30a7b4f14a559722e419ae526f79572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648326
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667291}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658838
Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#296}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix module install
Previously, we created a SplitInstallManager _before_ calling
SplitCompat.install(-), which breaks the module install flow on Android
pre-Q.
(cherry picked from commit 801cc00b4ec48cfcfbbd48a441d59d48892f7c48)
Bug: b/133669491
Change-Id: I0b317732ed364a592047eeb7387c74dd1ea1b258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646903
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668416}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658958
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#295}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
M76 merge [ios] Fix crash when reordering and closing all tabs simultaneously
The reordering gesture must be canceled when closing all tabs in the
tab switcher.
TBR=marq@chromium.org
(cherry picked from commit 30fdec4fa7795a496a6deb7e59b43c112e9d1f9d)
Bug: 961045
Change-Id: I595761b90e9bf896668922c36a9933446b846c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654409
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668457}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658592
Cr-Commit-Position: refs/branch-heads/3809@{#294}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.27
TBR=mmoss@chromium.org
Change-Id: I3f88a9307893329549b80cb21f9c03dea9fc2c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658670
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/3809@{#293}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Disable printer fetching from OOBE in Chrome OS
Resolves a crash from attempting to print from oobe in M76 due to
CupsPrintersManager not being instantiated on the lock screen. This is
a stopgap to prevent the crash. Followup CL's will resolve the
underlying issue to re-enable printing from OOBE.
(cherry picked from commit 00b83546e761c1bdfff55404d371350a5c919749)
Bug: 971185
Change-Id: Iaaf4b57a4c9509d1b54817891c4aebcca8e0ef37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648827
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668248}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658928
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#292}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge to M76] Take a strong ref of SharedContextState.
Take a strong ref of SharedContextState in
AbstractTextureImplOnSharedContext. This is to avoid cases where during
shutdown SharedContextState can be destroyed before
AbstractTextureImplOnSharedContext.
(cherry picked from commit 65656ed3340bf45ceb9d060528bae34e16600fe1)
Bug: 972521
Change-Id: Ifd5be5505351cf0573ebf124014927911b184ff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651491
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668255}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658771
Reviewed-by: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#291}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
start requesting updates to shell apk version 89
includes the following changes:
- add support for WST v2
- fix crash on empty share intent bug
- clear cached data when identity service selects different hosts
- some refactoring
(cherry picked from commit f3349a16272f44bc72ab50214f7bc1c090fe1891)
Change-Id: I5794c6eb1951b22352be7d668db49afdcfd2614f
Bug: 972743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647312
Commit-Queue: Henry Jian <hzjian@google.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667980}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658648
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#290}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
M76 merge [ios] Fix crash when opening a non-supported URL bookmark
This is an obscure crash in which the incognito BVC is destroyed when
opening a non-supported URL bookmark in incognito. (See bug for repro
steps).
This CL ensures that the bubblePresenter is properly released when
the browserState is reset in BVC and thereafter destroyed.
The fix in https://crrev.com/c/1621311 is no longer necessary and is
removed.
TBR=eugenebut@chromium.org
(cherry picked from commit 84f24396fe399ed3eecd0b81b70446399fe2a37f)
Bug: 966372
Change-Id: I37a85a75cf1b7a6b0d6cada4df69938ffad4c8a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650719
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668217}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658509
Cr-Commit-Position: refs/branch-heads/3809@{#289}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Don't tell |frame_evictor_| about empty frames.
Extensions can create empty frames by loading generated_background_page.html,
which count against the number of saved frames FrameEvictionManager will
hold onto. This causes minimized/occluded windows to have their foreground
tab frame evicted, which leads to empty tab previews.
(cherry picked from commit 868f600d9dbb0c7458a2129e96708cdc64006172)
Bug: 969031
Change-Id: Ieb420cc33d0ac70a2df125b8627124edb0233ee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651613
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667699}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658628
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#288}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
ChromeOS media: remove unnecessary FD duplication.
The recent refactoring CL crrev.com/c/1613297 introduced
unnecessary duplication of file descriptors. Worse, those
descriptors could leak, eventually leading to resource
exhaustion. As an added bonus, several legacy uses of
SharedMemory and SharedMemoryHandle are updated to the new
API.
See crbug.com/965455 for a motivating example of leaky
file descriptors.
(cherry picked from commit 842e2a8cb87738c74ca6f95c7173961d0bf5bfe4)
Bug: 849207, 971575
Change-Id: I8b6c06689d99a12c97af19bd3eabdb0918b1ba22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645301
Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org>
Reviewed-by: Wei Lee <wtlee@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666626}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657841
Reviewed-by: Matthew Cary (CET) <mattcary@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#287}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Remove the NOTREACHED for 76
TBR=edcourtney@chromium.org
Bug: 969403
Test: None
Change-Id: Iddc152caa55f3a5195cb0b2f6b2800b50c98500b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654516
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#286}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Autofill Assistant] Allow setting initial terms&conditions state.
This is the client change required to allow scripters to override the default state of the third party terms&conditions checkbox.
This is the M-76 merge for http://crrev/c/1605202.
(cherry picked from commit 7de788205966702ca9d11df8f5e47fc744dfd1b6)
Bug: 973032
Bug: b/131588758
Change-Id: I3e6a970b3e972405a76e0fc8bf505939bc2459ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605202
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666199}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657840
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#285}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[AA] Hideable terms section.
Before this patch the terms section was always shown. There are
occasions where that section does not make sense. This patch introduces
a new flag to hide the T&C section altogether.
This is the M-76 merge for http://crrev/c/1640991.
(cherry picked from commit da20bb471b2c8d3381228ce6fa58e1fe06abb172)
Bug: 973026
Bug: b/134096141
Change-Id: I83dd88f35151934ad4c8c4b8e276582024294441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640991
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#665841}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658020
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#284}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Autofill Assistant] Allow setting top padding for FocusAction.
The top padding can be specified either by the Pixels or ratio
relative to the height of the window.
This is the M-76 merge for http://crrev/c/1640408.
(cherry picked from commit e0949be5a94d0ad61a816563160feb94c638e9c4)
Bug: 973043
Bug: 806868
Bug: b/132758584
Change-Id: I2d3f77b04a9ca319634fe2ec1325d24c0052d100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631607
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Lukasz Suder <lsuder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665878}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657896
Reviewed-by: Lukasz Suder <lsuder@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#283}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Autofill Assistant] Make ConfigureBottomSheetAction wait for resize to
happen.
Before this change, ConfigureBottomSheetAction would return immediately
after asking for the viewport to be resized. Depending on how quickly
that happened, a Focus action following ConfigureBottomSheetAction might
see the window height before the resize and not be able to focus.
The current workaround for that is to wait after resizing the viewport
before focusing on an element, but the time it takes varies a lot.
With this change, ConfigureBottomSheetAction waits until the viewport
resize has been seen from the Javascript side, so we don't wait longer
than strictly necessary. A maximum wait time avoids scripts getting
stuck in this action.
This is the M-76 merge for http://crrev/c/1640408.
(cherry picked from commit fc4d56bbaab6747fe94930f83cb4c3e4da02766c)
Bug: 973038
Bug: b/133665079
Change-Id: Ia37076710634542bb4f15c77f30275c234383cb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640408
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665557}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658008
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#282}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Web MIDI: Update planned schedule to deprecate insecure origin uses
The deprecation was planned to be done at m75, and rescheduled to be
at m76. And we reschedule it again to be at m77.
(cherry picked from commit b36c6fe85bb77ed64f8028f7923a8cc33af5f5ad)
Bug: 973299, 924471
Change-Id: I3fffe56e33c04e36f84afccf7b42faca523f34bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650550
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668304}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657878
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#281}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Autofill Assistant] Make positioning of highlighted area independent of
viewport height.
This change fixes issues with the event filter of the overlay not
adapting to viewport height changes.
With this change, the position of highlighted elements are reported as
CSS pixels, relative to the page, instead of coordinates relative to the
viewport size. The viewport size and position within the page is tracked
and reported separately.
When displaying or comparing against filter coordinates, CSS pixels are
converted into physical pixels using the viewport width, which allows
adapting to zoom.
This change also simplifies the display of the highlighted area by
ignoring the offset reported to the onScroll methods as it was causing
issues. This allows the model to cache the element position and the
visual viewport position independently; when scrolling, unless the
element position is absolute, element position normally stay the same
and only the viewport changes.
This is the M-76 merge for http://crrev/c/1634737.
(cherry picked from commit 553002120f1f5381f2905f26c17e298b75a452b2)
Bug: 973034
Bug: b/133669408
Bug: b/129050125
Change-Id: I745584b496d960a2d73231238dd2006afb3f7eaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634737
Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665536}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657911
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#280}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Autofill Assistant] Fix scrolling for elements within scrollable
containers.
Before this change, when scrolling elements within scrollable container,
the element would be first taken to the desired position within the
screen, *then* scrolled within its container, which could result in the
element not even appearing within the window.
With this change, the element is scrolled into view within its container
before choosing how much to scroll the window vertically. At the end of
the scroll, the top of the element is always at the desired position
within its frame.
This change also switches the browsertest for scrolling to doing
synchronous checks, as we don't use smooth scrolling anymore.
This is the M-76 merge for http://crrev/c/1636138.
(cherry picked from commit b7517fe4d094c623e4c152ac4df1b24fde087f8c)
Bug: 973031
Change-Id: I5bd090988ec8ca5441d15783d2b46ceb3982e57d
Bug: b/129046627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636138
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665523}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657888
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#279}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Autofill Assistant] Report the intent data url.
Before this patch we reported the committed URL to our backend in the
initial request. The committed URL can potentially contain PII and can
therefore not be kept.
This patch changes that and reports the data url from the intent as
passed to chrome by a caller. There is approval for that piece of
information to be logged.
This is the M-76 merge for http://crrev/c/1632252.
(cherry picked from commit e6f8f11b56e7a7f55ce9eeb99042f1dfe409d79d)
Bug: 973025
Bug: b/133732376
Change-Id: Idb98a727d37f2b9e7488f2f84b8fd273c2f4240f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632252
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665489}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657830
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#278}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Disable DMA-buf encoding tests for devices using V4L2 JEA
This CL disables DMA-buf encoding tests for devices using V4L2 JEA since
V4L2 JEA has not supported it yet.
(cherry picked from commit 673682acb3b7cfbafd1b2a4c185d56b54ce7a14a)
Bug: 968924
Test: ./jpeg_encode_accelerator_unittest (on Dru)
Change-Id: I3feb88cb729741602b4674a467b33b4b40232701
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654733
Reviewed-by: Sheng-hao Tsao <shenghao@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668286}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657523
Reviewed-by: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#277}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
MacPWAs: Fix cmd+C and cmd+V with non-English keyboards
The fix for crrev.com/641485 only saved off the event for redispatch
in a single situation where it wasn't handled. This was too
conservative, and didn't address cmd+C and cmd+V.
Save off the event for redispatch whenever it is unhandled.
TBR=ccameron@chromium.org
(cherry picked from commit 3e3966694fe218769ccb8562e1a104d287b7ee50)
Bug: 964052
Change-Id: Iaa9b8d747e396aa1f0a3144c83400ae73dd44a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643732
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666028}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657379
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#276}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.26
TBR=mmoss@chromium.org
Change-Id: I68e7d37c5ee420b86c71798bf485a788324af8f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657250
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#275}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
M76: Do not set utf-8 encoding in OfflinePageURLLoader
Setting it will skip the auto detection of response encoding.
TBR=jianli@chromium.org
(cherry picked from commit 596c71d26d2ee96008c7d38a0102c2b5d54870e4)
Bug: 966094
Change-Id: I601bbc99339a94ec314f52af4d38236cdd457017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650086
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667353}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656782
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#274}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[merge to 3809] Dismiss consent dialog on Android on page navigation
TBR=bsheedy@chromium.org
TBR=mthiesse@chromium.org
Bug: 968802
Change-Id: I934004dcd1b9069d5164b8f6dfccbe184f3f98c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649637
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668168}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657188
Cr-Commit-Position: refs/branch-heads/3809@{#273}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Disable scrolling animation in Tab-to-Grid transition animation
After Grid Tab Switcher (GTS) can be lazily cleared
(added in http://crrev.com/c/1636621), when showing Tab-to-Grid
transition animation while GTS is not cleared yet, a scrolling
animation can be seen.
This CL fixes that by disabling scroll animation when playing
transition animation.
(cherry picked from commit 14670292292d6709923bd0b0e4bd15010c331091)
Bug: 968822
Change-Id: Id067065808dfc40bd608b3b0c6b80ed735e547aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641809
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665808}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657148
Cr-Commit-Position: refs/branch-heads/3809@{#272}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.25
TBR=cmasso@chromium.org
Change-Id: If85ea3f5a6f85c16e5ab659a322950cd0ddd1618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657050
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#271}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[TabGroupModelFilter] Add mergeTabsToGroup API
This CL adds an API mergeTabsToGroup to TabGroupModelFilter. This API
allows users to create group from existed tabs or groups.
BUG=963692
(cherry picked from commit 9772e48e079107ab4931dae5cdafe1c82813c57a)
Change-Id: I04d2610e169d4c68041b9ad542038f384e9cf40e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632838
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665351}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656711
Cr-Commit-Position: refs/branch-heads/3809@{#270}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[heap profiler] Fix a crash on Android.
Make use of acquire memory order to obtain the hash set to ensure its
internal fields have properly initialized values.
BUG=968801
TBR=alph@chromium.org
(cherry picked from commit 4e1dda6dfc46ed4908d4a324acdc3411dfd599b8)
Change-Id: Id93aed0a76ec559a5fe92b4443a94367fafaf2ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643894
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666039}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656968
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#269}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Dark] Fix send tab to self dark mode
Use context of triggering activity to inflate views instead of
application context so that dark mode works properly.
(cherry picked from commit 9b62405e30e8ab0008e8baa2a4a6a794fd5d86c8)
Bug: 972834
Change-Id: I16614056980105726b451f39b3c632fccc75f711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652652
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668174}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656789
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#268}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Do not reset pendingItemIndex to -1 when discarding new pending navigation.
TBR=eugenebut@google.com
(cherry picked from commit 78ad55139d12db4875dd8eccd2a003a876a8aabc)
Bug: 972411
Change-Id: I3c1e76ef81de48e6d33f00c3e504a230a7511585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652114
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667934}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656669
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#267}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[remoting][android] Fix Android client version number
For some reason Android client's version number is not properly set on
the M76 build. It says "Developer Build" even on the official build app.
Maybe the default version number have been changed from Chrome's version
number to the "Developer Build" string.
This CL explicitly sets the version number to Chrome's version number on
the build target.
(cherry picked from commit 7e18d520e9ca510fbe5882b8f4cae83fdb833c19)
Bug: 973196
Change-Id: I8c901042d22dfd87a7f3cc288412d1f21cea6df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653988
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668135}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655387
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#266}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Enforce not launching apps via "open link in a new tab"
Previously "Open link in a new tab/window" via context menu would allow
the user to stay on the web, regardless of whether or not we have
installed apps that are good candidates (because of the url/intent
filters the app exposes) nor if such apps were marked as preferred
before.
This CL aims to fix a regression where the user would escape to an
installed app that was marked as preferred before (it can also be a
verified app) while trying to open a given url on a new tab/window.
new tab via context menu.
(cherry picked from commit a6245bb2d403fbfe8036315438cbc1efbe2dbd70)
(cherry picked from commit f3326a0abd53289fbeebeaa0215de8ae42de14ae)
Bug: 968616
Test: Manual checked yelp app is not opening while clicking open in a
Change-Id: I9ebc76eeef44e73b204b8ac28343643ef584d50d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638144
Reviewed-by: Maggie Cai <mxcai@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#665073}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654353
Cr-Original-Commit-Position: refs/branch-heads/3770@{#1005}
Cr-Original-Branched-From: a9eee1c7c727ef42a15d86e9fa7b77ff0e63840a-refs/heads/master@{#652427}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656114
Reviewed-by: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#265}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[CrOS Network] Fix flash of content when network config dialog loads.
The flash was caused by the fact that separate parts of the
configuration dialog load at different times. To fix this issue, a
spinner is shown in the dialog while the dialog loads its fields. Once
the fields are all loaded, the spinner is removed and the rest of the UI
is shown.
(cherry picked from commit 4b315cc333b822cc66de685bac74574219e8291d)
Bug: 905231
Change-Id: I1ee4306cce945f71ff5ce6c71d3518c4bdd2c70a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649222
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668070}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656378
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#264}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[M76 Merge] Turn off open app support feature flag
(cherry picked from commit 0e2da4262f42fc829e9f5c25d2576c944f2ddaa1)
Bug: b/134962494
Change-Id: I01335a8bc0f9d90f05d188827b92e9492c40527a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652246
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668172}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656307
Reviewed-by: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#263}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Updating XTBs based on .GRDs from branch 3809
TBR=meacer@chromium.org
Change-Id: I80a04f1868785757e92424b080be1e21f71aafe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655084
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#262}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Uprev min env version for rtanalytics-light and rtanalytics-full.
Will merge back to M76 so that we can deploy both packages only to M76
and maintain compatbility with the CrOS side of the package.
(cherry picked from commit 10634a84ff8c86123673ebc496ce7109d418c4df)
Bug: 973058
Test: Not necessary.
Change-Id: I39ec8d671ca1b7502a59954ac567e61442032d2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652543
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Luke Sorenson <lasoren@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667999}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656096
Reviewed-by: Luke Sorenson <lasoren@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#261}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.24
TBR=kariah@chromium.org
Change-Id: I606deb5452ebde0bf8a14e41fec5d64d587d9941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656112
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#260}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[iOS] Don't call [BrowserViewWrangler updateDeviceSharingManager] in shutdown.
Simple fix for the bug, which is caused by accessing the active web state after
the web state list has been torn down.
(cherry picked from commit 2ee3bb09e80dc73db53df12fe0b92f2e86aa462a)
Bug: 968475
Change-Id: Ib450a5ac7123d23dbb03dbdd0130a9a798fb153d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649586
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668377}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656251
Reviewed-by: Kariah Davis <kariahda@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#259}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Checks if delegate is not nil before calling InfobarPresenting
TBR=sczs@chromium.org
(cherry picked from commit 19ea901e4151f5cddf7a3dbce4d5f030aea831be)
Bug: 972634
Change-Id: Ic1925bf36a5b4cdd4a0b769703b802662f1aa30d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653894
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668164}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656208
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#258}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Presents InfobarModal when Banner is tapped.
The Banner is animated to scale down and then back to its original size
before presenting the Modal.
TBR=sczs@chromium.org
(cherry picked from commit c4450e5ac680ff1ff2200df2b611d607bcc2147e)
Bug: 911864, 973168
Change-Id: Iac6f4435b39f188d7f24e2576b7ca429bcbccf0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648534
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668150}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656188
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#257}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ChromeDriver] Allow Is Displayed in W3C mode
The Is Element Displayed command is not part of W3C spec, but is still
used by some APIs, and its functionality can be difficult to replicate
in those APIs. This CL re-enables this command in W3C mode to ease
transition to W3C mode.
(cherry picked from commit 7ad1eb9fcaa397da16033c6d612aee735e3dc5e4)
Bug: 973094, chromedriver:2943
Change-Id: I9a73e98d00e9d6965e7382793cc95b836b8933d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651514
Commit-Queue: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Auto-Submit: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667804}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656033
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#256}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[m76] Ignore FrameHostMsg_SetNeedsOcclusionTracking in inactive frames.
A frame might get deleted (e.g. via its parent/ancestors) while some IPCs
targeting the frame are still in flights. In this case, the IPC should
be dropped. In particular, in this case it is not valid to continue and
assume that GetProxyToParent will return non-null value - the parent
might also be getting deleted and we might have already proactively
removed parent's proxies (see https://crbug.com/950625) and are just
waiting for parent's unload handler to finish.
Note that other 3 places where bad_message::RFH_NO_PROXY_TO_PARENT might
get triggered are already checking |is_active()| first.
TBR=lukasza@chromium.org
(cherry picked from commit 0e067b8d07e4fa74c1bc0982b5cdc5c490674311)
Bug: 972566
Change-Id: If7b1bff8082621621a9f9afc901aedd5e5a259b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651885
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667758}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655971
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#255}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Support form submission from spatial navigation.
When we get to the last non-submit-button element of a form the IME
action should change from Next to Submit.
(cherry picked from commit 18b921a22c85e88c3b7314b3ab8885281f48e5ca)
Bug: 968557
Change-Id: I5e61f184d30e6088fa80f3cdf95bbed1c344f46c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648464
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667156}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655347
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#254}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Remove REQUEST_INSTALL_PACKAGES permission for notouch build
Downloads home isn't supported in notouch builds, so we don't need this
permission.
(cherry picked from commit 0e5c8a211005c4c94ce5bdd349abe9a6febe8f50)
Bug: 972750
Change-Id: I964dbfbc3c8d3a9d0be8b1b03884815a5d7c6bc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652055
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667763}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656010
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#253}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add UMA for available memory when a renderer hangs
(cherry picked from commit c83e90371d9acce84204d7319a2f15d8a7001388)
Bug: 934317
Change-Id: I495d6dd94ede0d56a3619245d2b3866eb03ac718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652430
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667826}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655972
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#252}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[iOS] Fix traitCollection at view creation on iOS 13
On iOS 13, -traitCollectionDidChange isn't necessarily called when the
view is added to the view hierarchy.
This CL fixes the toolbar code which relies on this.
(cherry picked from commit 340e6f300e8931b2f86a36848d0b404598ba1625)
Bug: 973033, 971777
Change-Id: I3befbb8168999404b893c9889ef3dd179d1ea455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653026
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667973}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655317
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#251}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Autofill Assistant] Add content description to profile image.
(cherry picked from commit 4b08b2f4d933af5a1e298c6a45647e634bc0a15f)
Bug: 973037
Change-Id: I72a3fff67c2d916a36fea6ebd93dbab31f86cc8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640984
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665517}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655490
Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#250}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add ProfileMetricsRecorder
...to track and record profile related usage metrics during runtime.
Metrics are recorded per profile, i.e. each profile is assigned an ID
which corresponds to a histogram bucket.
The histogram Profile.BrowserActive.PerProfile is added.
(cherry picked from commit c67ace4a61ef46140193228317a636e7ce19d35c)
Bug: 965469
Change-Id: I2012eb8f3ec1a7ed6ddb54f703453d8d559d0f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625117
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667281}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655788
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#249}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix null deref in BaseJUnit4TestRule
When Cronet tests are run with a different Runner, as is required in
some other test environments,
BaseChromiumAndroidJUnitRunner.sInMemorySharedPreferencesContext is
null which causes crashes. The fix for now is to avoid the null-deref.
Perhaps a longer term fix can be found when agrieve@ returns from OOO.
(cherry picked from commit 62b04055a341d55131ea89251489cde18e1df547)
Bug: 971715
Change-Id: I475115cdce55d4233d93aef55a8516ae5c456f7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651059
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Auto-Submit: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667678}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655670
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#248}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix gestures not being handled
It seems that when the compositor touch action is enabled, the way we
stop timeout monitor is incorrect. This results in two things:
1. Some of the pointer event are not getting acked and hence gesture
events are not handled correctly.
2. There are still quite a lot of gesture events getting timeout out.
In this CL, we have a temporary fix for problem 1 so that some of the
website can be fixed. Then we will have another follow up to solve
problem 2.
(cherry picked from commit 9daafa915a182bb172b8de9d2d88d8cc7223cb4f)
Bug: 971937, 971186
Change-Id: Id3ef77f0772c75895deb291323cd9cd45553204a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650369
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667725}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655090
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#247}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix CCA user facing camera is not used as default bug.
This CL removed the undefined label of FRONT_CAMERA_LABEL used to judge
front camera. And allowed camera facing be distinguished on HALv1 device
with facing configuration so as to be correcly collected by user metrics.
Bug: 969628
Test: On HALv3 and HALv1 device with facing configuration the facing can be
correctly be set and collected by user metrics. On HALv1 device without
facing configuration, the facing is set to empty string as intended.
(cherry picked from commit 2b1f2b73e58abd9080b2dc2148c510ba5130515d)
Change-Id: I5931d11009089790d78a6f4ace284f37beb139aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644526
Reviewed-by: Sheng-hao Tsao <shenghao@chromium.org>
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667513}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652891
Reviewed-by: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#246}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[IndexedDB] Avoiding UAF in IndexedDBConnection list
The IndexedDBDatabase's connection() list can be modified during a call
to FinishAllTransactions. The AbortAllTransactions method didn't protect
against this, so there was a potential UAF. This patch fixes that.
(cherry picked from commit 6be08e8acbe5eaed18a0b9abeb395de5afa2f1aa)
Bug: 969083
Change-Id: I590e3a6c4f978ee6e582394208fb70cbdd9e5347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641625
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666381}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654510
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#245}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.23
TBR=kariah@chromium.org
Change-Id: I6aee78a9555e1d0a678729606a9df7206c759db9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654196
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#244}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SendTabToSelf] add time strings to action sheet
Per the request of the privacy review, we are adding strings to the
self share action sheet that displays how long ago each device was used.
Since ios doesnt allow for subtitles this is being added to the title with
a bullet separator.
(cherry picked from commit b58a30a27e483135e76d976f2caebc47049576b3)
Bug: 971404
Change-Id: I9b518e972613136933f8c47b27f43f04fdf61cac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646314
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668205}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653605
Cr-Commit-Position: refs/branch-heads/3809@{#243}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SendTabToSelf] Added metrics to all Android flows
(cherry picked from commit 5d2de4af31e088410ba0e44331363f82d7875901)
Bug: 942177
Change-Id: I2012b3d192a0772a7fe1057ccc582d44b440937c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648976
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667605}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654388
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#242}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Merge-76 [SendTabToSelf] Record activity sheet metrics on iOS.
TBR=sebsg@chromium.org
(cherry picked from commit a2706906c06b088bbd6e879389a9faf16e47c0f8)
Bug: 963980
Change-Id: Ie2ff8d96a7810974c7f053bc52222573b96b2b76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642684
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Auto-Submit: sebsg <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668222}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654349
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#241}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge to M-76] Overview: Fix a crash when window is long pressed and not moved
TBR=xdai@chromium.org
BUG=972807
TEST=Manual
(cherry picked from commit 8f7ad7a2cc7cb75b0bea05c127a89cdf2742daca)
Change-Id: Ib81da2b88eb2dd4831ce9bcb8192d976974e31e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650956
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667798}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653086
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#240}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fixed exo widget initialization for popup windows.
The bug was introduced when we forced override redirect windows to use
container_ by checking if container_ was a desktop shell. Unfortunately
this does not work for popups which explicitly set a non-desktop
container (kShellWindowId_MenuContainer).
This fix removes the logic to explicitly set the container for popups,
which allows them to use parent_ as the container.
(cherry picked from commit bb64e21dd27185cda3edafb4a668b6d8086c0972)
Bug: 971305, b:133854684
Change-Id: Ie12d38afdb148e8e47d36dee57e3eb55049db19d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647644
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#667813}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653752
Reviewed-by: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/branch-heads/3809@{#239}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix an issue that chrome crashes on startup after resuming a download in reduced mode
We should only check whether a download can open when really opening it.
This CL also fixes an issue that in_progress_downloads_ having a nullptr
during the ImportInProgressDownloads() call.
BUG=972202
(cherry picked from commit 2171e53c69d145f28c55872d19ec5ba0a36bf5f9)
Change-Id: I508654db93c61ddff2919b7dc7fdf3a0a7e65638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648906
Auto-Submit: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667703}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653084
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#238}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Updating XTBs based on .GRDs from branch 3809
TBR=meacer@chromium.org
Change-Id: I1d404bb008790779977517fac15ca175134c80ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653895
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#237}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Merge 3809: [LayoutNG] Fix negative margin in RTL
When there're negative inline margins, |ResolveInlineMargins|
computes incorrect inline-end margin, which affects line
offset in RTL. The inline-end margin computed here is not
used for layout in LTR that the problem was visible only in
RTL.
(cherry picked from commit 39c4a9924378db8c51ab3769a66efa3b1e71f203)
Bug: 971403
Change-Id: I8cfc6e303649d66b91c95ed1f7a30295c67bcad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647907
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667647}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653750
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#236}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Media Keys: Hide the SMTC on the lock screen
This CL adds logic to hide the System Media Transport Controls on the
lock screen unless the media is currently playing. If media is playing
on the lock screen and is then paused, we want to hide the SMTC after 5
seconds.
(cherry picked from commit 79e62ddd9964287cec778684995f086c2e3f4877)
Bug: 970353
Change-Id: I9fae652594381de05338ba0947fd18eed6ff7573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643733
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666544}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653870
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#235}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Idle: Add ScopedSetIdleState to make ui/base/idle more test-friendly
This CL adds a new ScopedSetIdleState class for testing that sets an
overriding idle state in ui/base/idle so that classes depending on
ui/base/idle can be more easily tested.
(cherry picked from commit ecd097eeadf2ba1df20c0c269cedfc80912ebeb7)
Bug: 951560
Change-Id: I4234af0783c7fc053620803b74f0ef6b0fc0ce4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643414
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666444}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653869
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#234}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
ui/gl: Gracefully handle failue to initialize ASurfaceControl.
Creating an ASurfaceControl from an ANativeWindow may fail. Handle that
gracefully by propagating this failure from GLSurface::Initialize which
will make the browser retry with a new window.
R=piman@chromium.org
(cherry picked from commit 28a9ea82b3c7023d2476b748f58027be8e859ba1)
Bug: 972667
Change-Id: Iad04043a0a2ff357157df0539f56af9d3522257b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651486
Commit-Queue: Khushal <khushalsagar@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667675}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653849
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#233}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[M76 Merge] Fix crash when pressing Assistant suggestion chip.
Previously a crash could occur because the Suggestion associated with
the suggestion chip may get destroyed during the OpenUrl sequence,
leaving us with a reference to a bad GURL.
To address this, we now post the OpenUrl to a task when handling
OnSuggestionChipPressed events. In addition to fixing the crash, this
also prevents any other observers of this event in the future from
receiving notification of the event with a bad pointer.
Note that there is potential for a similar crash when handling
notification clicks in the future, so handling that here as well. This
case does not require posting.
(cherry picked from commit c0f7696202f4172cf4683716b4338e86c5041924)
Bug: b:134773721
Change-Id: I0a178fc849c70b3015631ac2d9f7617395f616ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646598
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667766}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653073
Cr-Commit-Position: refs/branch-heads/3809@{#232}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Don't show PWAs on the last tab button
We can detect if a site in Chrome history is from a PWA launched
through webapk by:
* Constructing an intent with the URL of the site.
* Using the queryIntentActivities method to check what intents
launched the given URL.
* Check if the intents that launched the URL have the webapk class
name "org.chromium.webapk.shell_apk".
(cherry picked from commit 48877c8a1a8c7754ce664feaeed4bb6a349c0a06)
Bug: 968570
Change-Id: Ia3a51976f1876d3f21cddaf8c3ee34e34cee6f94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646138
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666803}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652219
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#231}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Respond to lifecycle events and periodcally refresh the last tab button
* Periodically queries the history service and refreshes the last tab
button.
* Responds to tab events to refresh the last tab button.
(cherry picked from commit 65bb962f8227d144c448cea113f57fa1816bb747)
Bug: 959860
Change-Id: Ib4f039c377211e8471267991442ff81318068867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627895
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665278}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652218
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#230}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Reset bindings in DidDetachFrameView
We're already doing cleanup in this function, and with this change
we do our other cleanup here, too.
(cherry picked from commit 07fc424a8cb44bc98d27e52dc460fc861b290d7e)
Bug: 970252
Change-Id: I44748e1bef4941219d447ce22228816bf79dd963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645129
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666713}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653230
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#229}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Ensure OpenVR controllers re-connect properly after suspend
If a user suspends an OpenVR immersive session whether by dropping to
a home environment (like the WMR home), or by pressing the "system"
button on the controller to show the OpenVR/Vive menu, and then
re-enters the session, the controllers would no longer be visualized.
This appears to be occuring because while the controller stayed
connected, the OpenVRRenderLoop was not able to query it's state, and
therefore stopped reporting input information on the controller.
When the controller re-connected, the RenderLoop would resume sending
data about the controller back up, but did not send a new description
because it thought it had been connected all along.
In XRSession, when a new XRInputSource was created, it defaulted to
being created as a "Gaze" source with no handedness. With no override
from the description, it stayed that way; clicks would work on the gaze
target, but no controllers/pointers would be rendered.
The fix here is to simply mark the controller as inactive if it does
not have state, thus ensuring that a new description is sent up when
the controller is again tracked/has state.
While updating this change, it was discovered that the tests report all
devices as connected, and so connecting/disconnecting a controller on
the test side would not prompt the device to be registered in product
code as newly connected (where it's device type is updated), so it
was always ignored if it was ever disconnected. This change modifies
the WaitGetPoses method (where GetInputSources gets it's data), to
properly report the connected state of controllers.
(cherry picked from commit ea496ec7e2bcf29d12541e9733ccefece2cf800d)
Bug: 934355
Change-Id: Ia61c7568916cc9446366e085e74b55c413c5f6f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648654
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667209}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653424
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#228}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ChromeDriver] Rename endpoints for accessing log
In W3C mode, replace non-standard /session/:sessionId/log* endpoints
with /session/:sessionId/se/log*, per agreement with Selenium.
(cherry picked from commit 0b81cefddc6b216fd6300eac855e39747f6f8767)
Bug: 973091, chromedriver:2947
Change-Id: I0c4b9833ace3e7ba5cb7ff0329f28041bf221da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652208
Commit-Queue: John Chen <johnchen@chromium.org>
Auto-Submit: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667761}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653630
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#227}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ChromeDriver] Allow POST with empty body in OSS mode
W3C WebDriver spec requires POST request to always have a non-empty
body. However, some legacy clients send empty POST body in some cases.
Updating ChromeDriver to handle such clients.
(cherry picked from commit e705a095439d0658fb81803396d4dcdb4c368c64)
Bug: 973088, chromedriver:2943
Change-Id: If29dd990dbebc0b4fc7c5df35ac25e4a4bc47f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648893
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667714}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653649
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#226}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless]: Return backup icon if no icon is available for context menu
(cherry picked from commit 0063e7a725af029c3009b13b25895119a9d27b44)
Bug: 970373
Change-Id: I6316993dfa21e73ea5b6e6b46186d4f4c576aab2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652082
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667743}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653417
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#225}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Do not send JavaScript results if they are not needed.
If large enough, they might OOM the IPC.
BUG=971688,972409
(cherry picked from commit 8e3ebe9c79594a3e0f00e5aac452f33a2ca1f2b6)
Change-Id: Icd25172270b1f111bd70b0d23c655d6d65c429d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651058
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667732}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653351
Cr-Commit-Position: refs/branch-heads/3809@{#224}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix flaky DumpAccessibilityTreeTest tests
This change fixes flaky test failures caused by the following CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1591484/22
Flaky behavior is fixed for the following tests:
-DumpAccessibilityTreeTest.AccessibilityIframePostEnable
-DumpAccessibilityTreeTest.AccessibilityIframe
DumpAccessibilityTreeTest.AccessibilityIframePostEnable is also
re-enabled as a revert to the following change:
https://chromium-review.googlesource.com/c/chromium/src/+/1638201
(cherry picked from commit 419aea493217e43ace35f6b0b5c40433592c8d45)
Bug: 969185,972562
Change-Id: I1c961f215936a04ba54b5dd5ca6ba35205567648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638925
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#665944}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650616
Cr-Commit-Position: refs/branch-heads/3809@{#223}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[SendTabToSelf] add strings for new modal dialog on ios
TBR=jeffreycohen@chromium.org
(cherry picked from commit 478c75ac0e3e31689c386be690ae45e49ca6d01c)
Bug: 969239
Change-Id: I90d3d7421394e8801969eda2dbc2bcce8e6832e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641367
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665684}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652546
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#222}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge to M76] Fixes visual bug where autoclick shadow was cropped by widget bounds.
The widget had no insets in which to display the shadow. In this change,
add insets to the widget, and ensure they are taken into account after
calculating the preferred layout for the autoclick menu view.
(cherry picked from commit 93e52146a60312ad697dabdceb33c2b34b0915d4)
TBR=tetsui@chromium.org
Bug: 966153
Change-Id: If43a4f3e91f20261195102018aad90c8427ac9a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636285
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665947}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653311
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#221}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Add "Remove" context menu item for last tab button
Selecting remove will remove last navigation from history and switch
last button to Google logo.
The logic is implemented by remembering timestamp of last removed
history entry in SharedPreferences. Only History items with later
timestamp are displayed on last tab button.
BUG=959317
R=wylieb@chromium.org
(cherry picked from commit bdb43101052c68f1056d7f211d5777bfee507d3b)
Change-Id: I8e67afca631bbc233d90f34791eff146bc1f37dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644155
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666044}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653293
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#220}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Remove bottom padding from list of options in touchless dialog.
This change removes whitespace between list items and bottom navbar.
Screenshot before (with old styling): http://screen/BMAx13oRGeP
Screenshot after: http://screen/4RB0K6kaYTX
BUG=959317
R=mdjones@chromium.org
(cherry picked from commit e670f77e60808b28ca7458404648851979ec47a2)
Change-Id: I33927472dbb7c04639c80dd4314e388a92bd39a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639352
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665679}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653291
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#219}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Context menu for "Last tab" button
In this CL I only add "Add to my apps" item. Remove will be handled by
separate CL.
BUG=959317
R=wylieb@chromium.org
(cherry picked from commit fc3d63a11c6b3e80c37f54d953cd048f1c7c5918)
Change-Id: Idc200d40c3a704b78f5a733485f037819d591dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639521
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665342}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653289
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#218}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Apply ancestor clipping when computing layout shift rect sizes.
(cherry picked from commit 22b784de649dd89b27436a55319563d57e822666)
Change-Id: I7714480b1369877a8164f57c22ab7bd43c9feb3a
Bug: 945963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639742
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666086}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650638
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#217}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Touchless] Add context menu to "More" button on NTP
BUG=959317
R=skym@chromium.org,mdjones@chromium.org
(cherry picked from commit 20db613a72f31b139963764a8678583d74603310)
Change-Id: Icb49eaac8aed5f66fbe16d12d615bb1f8567bbaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636854
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665007}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653308
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#216}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Clear previous visual rects when composited PaintLayer goes away.
This avoids spurious layout shift reports when a static-positioned
element loses its PaintLayer and cc::Layer at the same time (a common
scenario at the end of a transition animation).
(cherry picked from commit 9e33cc0699b9c333d04fea46131c446ef0c1407a)
Bug: 960614
Change-Id: I0ab8b693dbb764880090d1b078cb138f4ca1ddb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636403
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665588}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652614
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#215}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add UMA metrics to track policy atomic groups with conflicts
(cherry picked from commit 92c4a3ed152bf6008ff4cdba7cb06971e1bb7cb0)
Bug: 964013
Change-Id: I284b46b1eda2b27c8c6958afa340af4818a6f6fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628041
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666828}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652542
Reviewed-by: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#214}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Merge M-76][Web Payments] Make PaymentRequest.retry() "experimental"
This patch changes PaymentRequest.retry() from "stable" to
"experimental" as mentioned in the intent-to-ship blink-dev thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/JwSN1yEVvnk/PjC7rkrQCAAJ
After this patch, enabling
chrome://flags/#enable-web-platform-experimental-features will enable
PaymentResponse.retry().
TBR=bcwhite@chromium.org, rouslan@chromium.org
(cherry picked from commit 23287baa006ac9f5036b270d51e0d94f38b11976)
Bug: 861704, 969004
Change-Id: Ib3e8aff7617e5ce3759576faf97e978f26ba82fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638677
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666680}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652538
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#213}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Fix ScrollFocusedEditableIntoView for selections
This method is used to scroll and zoom an editable element into view and
to a legible scale. This generally happens on Android where the
on-screen keyboard appears and the input box is zoomed into the
viewport.
The linked bug occurs because we try to zoom the input box while it has
a selection (e.g Ctrl-A the text) rather than a blinking caret. This
method would then receive an empty rect for the caret_rect which would
cause us to zoom into the maximum possible scale.
The fix here is to fallback to the selection rect if there is no carret.
(cherry picked from commit c5b24f8cb108411a0588b189742cee9b939a7675)
Bug: 968638
Change-Id: I980183bf9843192e694579cf2af4af816b78a090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642248
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666493}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652580
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#212}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[Signin][Android] Disable sign-in promos if MobileIdentityConsistency is on
Adds to SigninManager.isSigninSupported a check for
MobileIdentityConsistency feature to hide sign-in UI surfaces if the
feature is enabled.
(cherry picked from commit b417842184890835c62f61c61a8314857bab39db)
Bug: 968140
Change-Id: I39156d4baf852d65117380bf98a983830d61dd6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645308
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666349}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651807
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#211}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add pre-target handler on the root view to close the menu on press
events that don't happen over the textfield (or the open menu).
(cherry picked from commit 244eedee04eaae48db685649e1ab72ced7b89dd3)
Bug: 953185
Change-Id: I84af8df0ea97da1e3bb1daebc823697523811e0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638126
Commit-Queue: Edin Kadric <edinkadric@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667111}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651051
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#210}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Query camera facing using mojo API in CCA
Fulfill the TODO of judging camera facing from mojo API instead of
device label.
Bug: None
Test: Test resolution switching function works normally on both
builtin and external cameras. On HALv1 device, the resolution
setting is hidden and can capture normally.
(cherry picked from commit b331ef5530c5d87eea09db74aae3282411f13bc2)
Change-Id: I751a378ce94a32df836cafc3f1a786d3745f4fa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638306
Reviewed-by: Sheng-hao Tsao <shenghao@chromium.org>
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665454}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652760
Cr-Commit-Position: refs/branch-heads/3809@{#209}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Replace empty strings with "n/a" in metrics
This CL fixes the bug where data studio filters out empty strings and
make us unable to draw pie chart effectively.
(cherry picked from commit 23555a5eba7785fde3c6c974a0053b135fe65891)
Bug: 969647
Test: Capture some photos
Change-Id: Ie8714b0709a5d040408905df3bb4c62459fd8b3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640933
Commit-Queue: Sheng-hao Tsao <shenghao@chromium.org>
Reviewed-by: Wei Lee <wtlee@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666184}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652632
Reviewed-by: Sheng-hao Tsao <shenghao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#208}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Add capture resolution to user metrics field
Bug: 962834
Test: On both v1, v3 device, the resolution can be logged to GA
dashbarod after capturing under different modes.
(cherry picked from commit 4135587910f082d3d9b884e373b9c7dcd057aaa8)
Change-Id: Ib230863242b1ee38890d8865c89cfa6b5a77f6fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637020
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Reviewed-by: Sheng-hao Tsao <shenghao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665452}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651532
Cr-Commit-Position: refs/branch-heads/3809@{#207}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
media/gpu/v4l2/SupportResolutionChecker: Create only if codec is VP8 and decoder
SupportResolutionChecker is always created because of its Create() bug.
It must be created only for VP8 decoder on go2001 driver device.
(cherry picked from commit 96034b163e6b3e2e1c7ddb9b761ea4cb56c98ab8)
Bug: b:131366944, 971273
Test: tast run video.DecodeAccelH264 on hana
Change-Id: I174f5b1920e06bb578cb52e9ab636666f652c556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646809
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666650}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652750
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#206}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
media/gpu/V4L2VideoDecodeAccelerator: Raise PLATFORM_FAILURE if the resolution is unsupported
The maximum resolution supported by guado is 1080p in video decoding. HW decoder
on guado (V4L2VideoDecoder) won't raise an error when the initial resolution
(e.g. 2K video) is unsupported. It causes chrome to not fallback and make 2k
video decoding undoable. This CL adds workaround to V4L2VideoDecoder for this
issue. It parses every vp8 encoded frame, checks the resolution on key frame and
invokes NotifyError() if the resolution is unsupported.
(cherry picked from commit aa95d92bdf80bcfa94dcfce56251c0e3035d4721)
Bug: b:131366944
Test: run video_decode_accelerator_unittest on guado with 2K video file and get NotifyError
Test: 2K video can be seen on guado
Change-Id: Ic1ba2fa4a281dee6953d1696f991681217364f2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637001
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#665508}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650543
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#205}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Call superclass Layout() from NewTabButton::Layout()
The new NewTabButton::Layout() override stopped the FocusRing from
being laid out. As a result, the focus ring no longer appeared. By
calling the superclass Layout() first we ensure FocusRing::Layout() is
also called.
This also fixes the naming of |ink_drop_container_|.
(cherry picked from commit 4641862d47f048ec0c4d1c2f3519db4b2b248ba9)
Bug: 971860
Change-Id: I8fbc5c01f89d831fd36e3cb87e7d7cca1c85fce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650681
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667393}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652712
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#204}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Incrementing VERSION to 76.0.3809.22
TBR=kariah@chromium.org
Change-Id: If7eab98f18a7b1005b8a9492373470ab527ec481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652553
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#203}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
device/fido: Increase timeout for FIDO connection
(Merge to M76.)
Since CL:1582274, timeout actually worked. This makes Chrome OS hit the
timeout since there is the overhead of GATT services browsing in BlueZ.
This CL increases the timeout from 3 to 10 seconds to accommodate this.
BUG=b:133097385,971898
(cherry picked from commit f0ceb74419c092d727bc0af102788a574ed12835)
Change-Id: Ib8c74a1632897547f3d600b59376d9e31d4d109b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648898
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666960}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652568
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#202}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
ime: Revert MODECHANGE key behaviour back to original.
In a previous patch, we changed the MODECHANGE key behaviour so that
pressing it once will only show the current input method. This was to
follow the UX specs.
However, upon consideration, we're going to change it back to the
original behaviour of switching to next input method on first key press.
The original code used a event rewriter to convert the MODECHANGE key
into Ctrl-Shift-Space (which switches to the next key press). We then
changed the code to be in ash accelerators because of the extra logic
involved. Now that we don't need this extra logic, we could revert back
to event rewriter, but we think it's better to keep it in accelerators
because we still have some extra logic around histogram logging.
TBR=holte@chromium.org
(cherry picked from commit fe901037fd6ae87e8eee4efa17016ea6ca0c503b)
Bug: 953901
Change-Id: I2cf4dc41300b62ee6f57085408e199a2a55062b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642487
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#666233}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647272
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#201}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
[ios] Polish color of Location Bar buttons
Make the share button more transparent and the Messages badge button
darker. This will bring the two into a closer color contrast.
Screenshot: https://drive.google.com/open?id=1rYOLpCxdL39bkFnlDWSgJi_zu21-i7Gm
(cherry picked from commit df37ff22515b2f4cad2532c70d2402c96e09cc45)
Bug: 971708
Change-Id: I17677468660e177edfb896428bf983dbd60594c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647539
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#667473}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652425
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/branch-heads/3809@{#200}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}