commit | b0ddb123dfe60577a3518dfad771ebd520442fc7 | [log] [tgz] |
---|---|---|
author | Majid Valipour <majidvp@chromium.org> | Tue Jun 18 15:01:34 2019 |
committer | Majid Valipour <majidvp@chromium.org> | Tue Jun 18 15:01:34 2019 |
tree | d4f77b213bd7032f58c2ef99fe4e627213f7f06c | |
parent | d6c7f508a4853446c475df24b66b691a2260d128 [diff] |
[scroll-snap] Fix bug where snap area was not being removed Previously we would first check that as area is not a viewport defining element (VDE) before potentially removing it from its snap container. The problem is that VDE can change over the lifetime of a document for example it can initially be HTML and later BODY. This means that it is possible for the existing logic to consider BODY as a snap area first and add it to a container but don't consider it a valid snap area at a later point and thus miss removing it from the map. The fix simply removes the VDE check for snap areas. We don't really need to limit VDE being a snap area. We still keep limitation for VDE becoming a snap container but there removal logic operates regardless so it is safe. (cherry picked from commit 86c95f06d09497cb3ac6810f0900ad58b2ab324f) Bug: 972434 Change-Id: I6d87f8df53f59c58b8302ed7b536b3f6783d98f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657754 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#669128} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664477 Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/branch-heads/3809@{#408} Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .