[go: up one dir, main page]
Google Git
Sign in
chromium / chromium / src / a7b6954e4b7a311d6b815ca59f95621ff6a5892e
commita7b6954e4b7a311d6b815ca59f95621ff6a5892e[log] [tgz]
authoredchin <edchin@chromium.org>Thu Jun 13 16:19:04 2019
committeredchin <edchin@chromium.org>Thu Jun 13 16:19:04 2019
treeb1d4b750133d5f1599f6a314a86162b6a53310f3
parent5f5bc35efed6b6b6c1903ab1790874617ada8b95 [diff]
M76 merge [ios] Fix crash when opening a non-supported URL bookmark

This is an obscure crash in which the incognito BVC is destroyed when
opening a non-supported URL bookmark in incognito. (See bug for repro
steps).

This CL ensures that the bubblePresenter is properly released when
the browserState is reset in BVC and thereafter destroyed.

The fix in https://crrev.com/c/1621311 is no longer necessary and is
removed.

TBR=eugenebut@chromium.org
(cherry picked from commit 84f24396fe399ed3eecd0b81b70446399fe2a37f)

Bug: 966372
Change-Id: I37a85a75cf1b7a6b0d6cada4df69938ffad4c8a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650719
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#668217}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658509
Cr-Commit-Position: refs/branch-heads/3809@{#289}
Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
1 file changed
tree: b1d4b750133d5f1599f6a314a86162b6a53310f3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .