commit | 413be370ab00d4b0b3e09bbce85d01d2250dbcdc | [log] [tgz] |
---|---|---|
author | Sean Gilhuly <sgilhuly@chromium.org> | Thu Jun 13 18:42:35 2019 |
committer | Sean Gilhuly <sgilhuly@chromium.org> | Thu Jun 13 18:42:35 2019 |
tree | bf7331847349a919bde3e07914f6aee7fbcaf633 | |
parent | 8be5aea664dd5872079df13b36f34d9aa41a36cb [diff] |
Check before removing render pass resource Replce the DCHECK in SkiaOutputSurfaceImpl::RemoveRenderPassResource() with a test to see if the render pass has an entry in |render_pass_image_cache_| before trying to remove it. There isn't a known repro for this crash, but I suspect that using a bypass to draw the quad in SkiaRenderer::DrawRenderPassQuad() can cause the circumstances to arise. An entry for |render_pass_image_cache_| is created in MakePromiseSkImageFromRenderPass(), but this is skipped if a bypass quad is used, causing a difference between the render pass maps in SkiaRenderer and SkiaOutputSurfaceImpl. (cherry picked from commit a7a1388ba01980a42908b301432262d63879ed60) Bug: 959071 Change-Id: I4765f57eb30a7b4f14a559722e419ae526f79572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648326 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#667291} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658838 Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/branch-heads/3809@{#296} Cr-Branched-From: d82dec1a818f378c464ba307ddd9c92133eac355-refs/heads/master@{#665002}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .