[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rework low level message stream retries, add debugging #1713

Merged
merged 6 commits into from Apr 16, 2023
Merged

feat: rework low level message stream retries, add debugging #1713

merged 6 commits into from Apr 16, 2023

Conversation

feywind
Copy link
Collaborator
@feywind feywind commented Apr 15, 2023

Adjusts stream retries to standard exponential backoff behaviour, adds a few knobs for tweaking the settings of the backoff, and adds some 'debug' events on the subscription object for seeing when disconnects and reconnects happen.

Fixes #1712

@feywind feywind requested review from a team as code owners April 15, 2023 20:36
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Apr 15, 2023
@feywind feywind added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: l Pull request size is large. labels Apr 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2023
kamalaboulhosn
kamalaboulhosn requested changes Apr 15, 2023
View reviewed changes
src/message-stream.ts Outdated Show resolved Hide resolved
src/message-stream.ts Outdated Show resolved Hide resolved
src/message-stream.ts Outdated Show resolved Hide resolved
src/message-stream.ts Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 15, 2023
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 16, 2023
@feywind feywind merged commit c1cc6e0 into googleapis:main Apr 16, 2023
14 checks passed
@feywind feywind deleted the gh1712-stream-retry branch April 16, 2023 01:00
@release-please release-please bot mentioned this pull request Apr 16, 2023
Merged
@nguyen-vo nguyen-vo mentioned this pull request May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve streaming pull stream retry behaviour
2 participants
@feywind @kamalaboulhosn