[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve streaming pull stream retry behaviour #1712

Closed
feywind opened this issue Apr 15, 2023 · 0 comments · Fixed by #1713
Closed

Improve streaming pull stream retry behaviour #1712

feywind opened this issue Apr 15, 2023 · 0 comments · Fixed by #1713
Assignees
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@feywind
Copy link
Collaborator
feywind commented Apr 15, 2023

There are several potentially problematic behaviours with streaming pull stream retries that may have been making some of the known issues worse (or causing them).

  • The minimum retry time is too high
  • The default maximum retry time is too high (5 minutes)
  • The back-off behaviour could result in very long retry times with long-term streams
  • Streams within the stream pool are retried all at once, which might increase lag

In order to better get debugging information on these in the future, we also want to add some more stream logging messages for when things disconnect and reconnect. These will go out to the 'debug' channel of the subscription.

@feywind feywind added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 15, 2023
@feywind feywind self-assigned this Apr 15, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant