[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rework low level message stream retries, add debugging #1713

Merged
merged 6 commits into from
Apr 16, 2023
Merged

feat: rework low level message stream retries, add debugging #1713

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c75a7cb
feat: rework how subscriber streams are retried and generally managed
feywind Apr 15, 2023
fc364b7
feat: add debug logging from the low level message stream for reconnects
feywind Apr 15, 2023
944fe4b
chore: rename retryBackoff
feywind Apr 15, 2023
1d42965
chore: update retry max backoff
feywind Apr 15, 2023
5407338
feat: clarify 'debug' channel a bit, add explicit debug message class
feywind Apr 15, 2023
5c16274
chore: push stream retries to full individual retry
feywind Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: add debug logging from the low level message stream for reconnects
  • Loading branch information
@feywind
feywind committed Apr 15, 2023
commit fc364b791578ac6014db746cf275eabbe664d7ad
13 changes: 13 additions & 0 deletions src/message-stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,13 +357,26 @@ export class MessageStream extends PassThrough {
this._removeStream(index);

if (PullRetry.retry(status)) {
this.emit(
'debug',
new Error(
feywind marked this conversation as resolved.
Show resolved Hide resolved
`Subscriber stream ${index} has ended with status ${status.code}; will be retried.`
)
);
if (PullRetry.resetFailures(status)) {
this._retrier.reset(this._streams[index]);
}
this._retrier.retryLater(this._streams[index], () => {
this._fillStreamPool();
feywind marked this conversation as resolved.
Show resolved Hide resolved
});
} else if (this._activeStreams() === 0) {
this.emit(
'debug',
new Error(
`Subscriber stream ${index} has ended with status ${status.code}; will not be retried.`
)
);

// No streams left, and nothing to retry.
this.destroy(new StatusError(status));
}
Expand Down