[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog entry for experimental extensions #3017

Merged
merged 6 commits into from
Jan 12, 2021

Conversation

i14h
Copy link
Member
@i14h i14h commented Jan 11, 2021

Add changelog entry for experimental extensions

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Jan 11, 2021
CHANGELOG.md Outdated
@@ -1,3 +1,4 @@
- Add warning when a developer is using yarn@2 PnP (#2198).
- Fixes incorrect URLs reported inside emulated HTTPS functions (#1862).
- Updates underlying timeout handler when proxying through the Hosting emulator.
- Add support for deploying [experimental extensions](https://github.com/FirebaseExtended/experimental-extensions) (#2398)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add support for deploying [experimental extensions](https://github.com/FirebaseExtended/experimental-extensions) (#2398)
- Add support for installing [experimental extensions](https://github.com/FirebaseExtended/experimental-extensions) (#2398)

suggesting this to match the language we use in the docs

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -1,3 +1,4 @@
- Add warning when a developer is using yarn@2 PnP (#2198).
- Fixes incorrect URLs reported inside emulated HTTPS functions (#1862).
- Updates underlying timeout handler when proxying through the Hosting emulator.
- Add support for deploying [experimental extensions](https://github.com/FirebaseExtended/experimental-extensions) (#2398)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add support for deploying [experimental extensions](https://github.com/FirebaseExtended/experimental-extensions) (#2398)
- Add support for deploying [experimental extensions](https://github.com/FirebaseExtended/experimental-extensions) (#2830)

I believe #2830 is correct. #2398 seems like a different PR

i14h and others added 2 commits January 11, 2021 15:35
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
@i14h
Copy link
Member Author
i14h commented Jan 11, 2021

@jhuleatt @rachelsaunders fixed

@coveralls
Copy link
coveralls commented Jan 12, 2021

Coverage Status

Coverage increased (+0.01%) to 65.558% when pulling 03f0ee8 on ir-changelog-entry-for-experimental-extensions into fca0381 on master.

@i14h i14h merged commit f03c486 into master Jan 12, 2021
@bkendall bkendall deleted the ir-changelog-entry-for-experimental-extensions branch August 4, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants