[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support experimental extensions in CLI #2830

Merged
merged 12 commits into from Jan 7, 2021
Merged

Conversation

i14h
Copy link
Member
@i14h i14h commented Nov 16, 2020

Description

Allow the CLI to show a warning message when the user is installing an experimental extension.

Scenarios Tested

npm test

@i14h i14h requested a review from joehan November 16, 2020 23:53
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Nov 16, 2020
@i14h
Copy link
Member Author
i14h commented Nov 16, 2020

@kevinthecheung can you check the copy please?

src/extensions/resolveSource.ts Outdated Show resolved Hide resolved
i14h and others added 2 commits November 30, 2020 07:30
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
@i14h
Copy link
Member Author
i14h commented Nov 30, 2020

@huangjeff5 Can you also take a look and see if this fits well with the backend?

@huangjeff5
Copy link
Contributor

@huangjeff5 Can you also take a look and see if this fits well with the backend?

Looks good to me, although the concept of varying "audiences" only exists on the official extensions currently. We plan to add an "audience" field to extensions stored on the backend in Q1 sometime, so that we can migrate official extensions to use the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants