fix: remove usage in including_default_value_fields to prepare for pr…

…otobuf 5.x (#866) Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>
googleapis · Mar 13, 2024 · 66a534d · 66a534d
1 parent e998a21
commit 66a534d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/google/cloud/logging_v2/_gapic.py b/google/cloud/logging_v2/_gapic.py
@@ -271,7 +271,6 @@ def sink_create(
         return MessageToDict(
             LogSink.pb(created_pb),
             preserving_proto_field_name=False,
-            including_default_value_fields=False,
         )
 
     def sink_get(self, sink_name):
@@ -298,7 +297,6 @@ def sink_get(self, sink_name):
         return MessageToDict(
             LogSink.pb(sink_pb),
             preserving_proto_field_name=False,
-            including_default_value_fields=False,
         )
 
     def sink_update(
@@ -351,7 +349,6 @@ def sink_update(
         return MessageToDict(
             LogSink.pb(sink_pb),
             preserving_proto_field_name=False,
-            including_default_value_fields=False,
         )
 
     def sink_delete(self, sink_name):
@@ -459,7 +456,6 @@ def metric_get(self, project, metric_name):
         return MessageToDict(
             LogMetric.pb(metric_pb),
             preserving_proto_field_name=False,
-            including_default_value_fields=False,
         )
 
     def metric_update(
@@ -496,7 +492,6 @@ def metric_update(
         return MessageToDict(
             LogMetric.pb(metric_pb),
             preserving_proto_field_name=False,
-            including_default_value_fields=False,
         )
 
     def metric_delete(self, project, metric_name):
@@ -530,7 +525,6 @@ def _parse_log_entry(entry_pb):
         return MessageToDict(
             entry_pb,
             preserving_proto_field_name=False,
-            including_default_value_fields=False,
         )
     except TypeError:
         if entry_pb.HasField("proto_payload"):
@@ -539,7 +533,6 @@ def _parse_log_entry(entry_pb):
             entry_mapping = MessageToDict(
                 entry_pb,
                 preserving_proto_field_name=False,
-                including_default_value_fields=False,
             )
             entry_mapping["protoPayload"] = proto_payload
             return entry_mapping

diff --git a/tests/unit/test__gapic.py b/tests/unit/test__gapic.py
@@ -595,7 +595,6 @@ def test_non_registry_failure(self, msg_to_dict_mock):
         msg_to_dict_mock.assert_called_once_with(
             entry_pb,
             preserving_proto_field_name=False,
-            including_default_value_fields=False,
         )
 
     def test_unregistered_type(self):