[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds timer decorator to facilitate debugging #1917

Merged
merged 3 commits into from
May 16, 2024
Merged

feat: adds timer decorator to facilitate debugging #1917

merged 3 commits into from
May 16, 2024
+37 −0

Conversation

chalmerlowe
Copy link
Contributor

This PR adds a calculation_duration function to figure out how long each of the nox sessions takes to complete.

This allows us to troubleshoot issues if a session seems to be taking longer than expected.

@chalmerlowe chalmerlowe requested review from a team as code owners May 15, 2024 14:26
@chalmerlowe chalmerlowe requested a review from Linchin May 15, 2024 14:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 15, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
shollyman
shollyman approved these changes May 15, 2024
View reviewed changes
noxfile.py Show resolved Hide resolved
@chalmerlowe chalmerlowe merged commit ea750e0 into main May 16, 2024
21 checks passed
@chalmerlowe chalmerlowe deleted the clowe-adds-timer-decorator branch May 16, 2024 12:02
@release-please release-please bot mentioned this pull request May 16, 2024
Merged
This was referenced May 21, 2024
Closed
Closed
Closed
@tswast
Copy link
Contributor
tswast commented May 29, 2024

FYI: This showed up in the public release notes because of the use of feat: in the commit. chore: may have been more appropriate since users of google-cloud-bigquery shouldn't care about this change.

@chalmerlowe
Copy link
Contributor Author

@tswast
I was unaware of the downstream effects of choosing feat: vs chore:. Thanks for this heads up.
Oops.
Will keep that in mind for the future.

CC: @Linchin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@Linchin Linchin Awaiting requested review from Linchin Linchin is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@leahecole leahecole

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chalmerlowe @tswast @shollyman @leahecole @yoshi-kokoro