[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to SignedURL Function has broken CNAME compatability #210

Closed
AJCStriker opened this issue May 30, 2018 · 1 comment
Closed

Improvements to SignedURL Function has broken CNAME compatability #210

AJCStriker opened this issue May 30, 2018 · 1 comment
Assignees
@stephenplusplus
Labels
api: storage Issues related to the googleapis/nodejs-storage API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@AJCStriker
Copy link
AJCStriker commented May 30, 2018 •
edited

Environment details

  • OS: Alpine Linux
  • Node.js version:
  • npm version: 9.4.0
  • @google-cloud/storage version: 1.7.0

Steps to reproduce

  1. Attempt to use File.getSignedURL with a CNAME'd bucket
  2. Visit the URL and receive and error with code: "SignatureDoesNotMatch"

This is distinct from previously reported errors that are similar in name in that the URL worked prior to the change shipped in 1.7.0 (#169). It appears superficially that the bucket name should not be included in the URL, that is to say:

Correct Value:
https://cname.mygcloudproject.google/myfileuuid?GoogleAccessId=etc

Erroneous value generated by 1.7.0 release: https://cname.mygcloudproject.google/cname.mygcloudproject.google/myfileuuid?GoogleAccessId=etc

I'm happy to submit a PR if the maintenance team would prefer but the original author may have better insight into how to repair this functionality.

Thanks!
@JustinBeckwith JustinBeckwith added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 1, 2018
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 8, 2018
@stephenplusplus
Copy link
Contributor

Yes, that does indeed look like an accident. Thank you for catching it. A PR would be awesome :)

@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 18, 2018
kevinnorris added a commit to kevinnorris/nodejs-storage that referenced this issue Jun 19, 2018
@kevinnorris
fix: signedURL cname (googleapis#210)
73275ee
@kevinnorris kevinnorris mentioned this issue Jun 19, 2018
Merged
3 tasks
stephenplusplus pushed a commit that referenced this issue Jun 20, 2018
@kevinnorris @stephenplusplus
fix: signedURL cname (#210) (#234)
cdbcb4a 
Fixes #210
@ghost ghost removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Jun 20, 2018
@google-cloud-label-sync google-cloud-label-sync bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 31, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: storage Issues related to the googleapis/nodejs-storage API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JustinBeckwith @stephenplusplus @AJCStriker @yoshi-automation