[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Custom Part Metadata Decorator to ParallelCompositeUploadConfig #2434

Merged
merged 24 commits into from Mar 15, 2024
Merged

feat: Add Custom Part Metadata Decorator to ParallelCompositeUploadConfig #2434

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
33122ad
feat: Custom Time Part Metadata Strategy
sydney-munro Mar 4, 2024
fe168d6
set customtime directly instead of via metadata builder
sydney-munro Mar 4, 2024
d14d141
lint and change null to IllegalStateException
sydney-munro Mar 4, 2024
9f12759
Add in version to javadoc
sydney-munro Mar 5, 2024
71ec5cf
removing unnecessary override
sydney-munro Mar 5, 2024
8b64aa6
removing unnecessary tag
sydney-munro Mar 5, 2024
15a29dc
address pr comments
sydney-munro Mar 13, 2024
b1bc015
add in ability to set a specific clock
sydney-munro Mar 13, 2024
19297a0
chore: refactor and separate lifecycle of config from customer and wh…
BenWhitehead Mar 13, 2024
4a51be1
chore: add pool size validation
BenWhitehead Mar 13, 2024
2a98f6c
IT test to ensure customtime is updated
sydney-munro Mar 14, 2024
746b581
lint
sydney-munro Mar 14, 2024
4acfa8c
Adding in more tests
sydney-munro Mar 14, 2024
f4e7fa8
lint
sydney-munro Mar 14, 2024
e88574b
more tests
sydney-munro Mar 14, 2024
57597dd
lint
sydney-munro Mar 14, 2024
80c747d
add missing null check
sydney-munro Mar 14, 2024
2adc0e5
address pr comments
sydney-munro Mar 14, 2024
6678349
unit test for offset calculations
sydney-munro Mar 15, 2024
7d39672
fixing docs
sydney-munro Mar 15, 2024
f7c4358
lint
sydney-munro Mar 15, 2024
6762593
Update google-cloud-storage/src/main/java/com/google/cloud/storage/Pa…
sydney-munro Mar 15, 2024
4f51449
Apply suggestions from code review
sydney-munro Mar 15, 2024
4861c85
lint
sydney-munro Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
  • Loading branch information
@sydney-munro @BenWhitehead
sydney-munro and BenWhitehead committed Mar 15, 2024
commit 4f5144944c0b0320b34e2981cf70ee3d414ee2d0
14 changes: 6 additions & 8 deletions ...src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
View file
Open in desktop
Expand Up @@ -251,9 +251,7 @@ public ParallelCompositeUploadBlobWriteSessionConfig withPartCleanupStrategy(
*
* <p><i>Default: </i> {@link PartMetadataFieldDecorator#noOp()}
*
* @since 2.35.1 This new api is in preview and is subject to breaking changes.
* @param partMetadataFieldDecorator
* @return
* @since 2.36.0 This new api is in preview and is subject to breaking changes.
*/
@BetaApi
BenWhitehead marked this conversation as resolved.
Show resolved Hide resolved
public ParallelCompositeUploadBlobWriteSessionConfig withPartMetadataFieldDecorator(
Expand Down Expand Up @@ -674,11 +672,11 @@ protected String fmtFields(String randomKey, String ultimateObjectName, String p
}

/**
* A Decorator which is used to manipulate metadata fields, specifically on the part files used in
* A Decorator which is used to manipulate metadata fields, specifically on the part objects created in
* a Parallel Composite Upload
*
* @see #withPartMetadataFieldDecorator(PartMetadataFieldDecorator)
BenWhitehead marked this conversation as resolved.
Show resolved Hide resolved
* @since 2.35.1 This new api is in preview and is subject to breaking changes.
* @since 2.36.0 This new api is in preview and is subject to breaking changes.
*/
@BetaApi
@Immutable
Expand All @@ -688,16 +686,16 @@ public abstract static class PartMetadataFieldDecorator implements Serializable

/**
* A decorator that is used to manipulate the Custom Time Metadata field of part files. {@link
* com.google.storage.v2.Object#customTime_}
* BlobInfo#getCustomTimeOffsetDateTime()}
*
* <p>When provided with a duration, a time in the future will be calculated for each part file
* <p>When provided with a duration, a time in the future will be calculated for each part object
* upon upload, this new value can be used in OLM rules to cleanup abandoned part files.
*
* <p>See [CustomTime OLM
* documentation](https://cloud.google.com/storage/docs/lifecycle#dayssincecustomtime)
*
* @see #withPartMetadataFieldDecorator(PartMetadataFieldDecorator)
* @since 2.35.1 This new api is in preview and is subject to breaking changes.
* @since 2.36.0 This new api is in preview and is subject to breaking changes.
*/
@BetaApi
public static PartMetadataFieldDecorator setCustomTimeInFuture(Duration timeInFuture) {
Expand Down