[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Custom Part Metadata Decorator to ParallelCompositeUploadConfig #2434

Merged
merged 24 commits into from Mar 15, 2024
Merged

feat: Add Custom Part Metadata Decorator to ParallelCompositeUploadConfig #2434

merged 24 commits into from Mar 15, 2024

Conversation

sydney-munro
Copy link
Collaborator

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Mar 4, 2024
@sydney-munro sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2024
@sydney-munro sydney-munro changed the title feat: Custom Time Part Metadata Strategy feat: Custom Part Metadata Strategy Mar 13, 2024
@sydney-munro sydney-munro marked this pull request as ready for review March 14, 2024 18:10
@sydney-munro sydney-munro requested a review from a team as a code owner March 14, 2024 18:10
frankyn
frankyn reviewed Mar 14, 2024
View reviewed changes
Copy link
Member
@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @BenWhitehead i think is more involved at this point so leaving him to approve.

...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
@sydney-munro sydney-munro requested a review from a team as a code owner March 14, 2024 20:11
BenWhitehead
BenWhitehead requested changes Mar 14, 2024
View reviewed changes
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...rc/test/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfigTest.java Outdated Show resolved Hide resolved
...rc/test/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfigTest.java Show resolved Hide resolved
...e/src/test/java/com/google/cloud/storage/ParallelCompositeUploadWritableByteChannelTest.java Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 14, 2024
@sydney-munro sydney-munro force-pushed the custom-metadata branch 3 times, most recently from 1b963aa to 9bdf885 Compare March 15, 2024 16:22
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Mar 15, 2024
BenWhitehead
BenWhitehead requested changes Mar 15, 2024
View reviewed changes
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java Outdated Show resolved Hide resolved
@sydney-munro sydney-munro changed the title feat: Custom Part Metadata Strategy feat: Add Custom Part Metadata Decorator to ParallelCompositeUploadConfig Mar 15, 2024
sydney-munro and others added 18 commits March 15, 2024 11:16
@sydney-munro
address pr comments
15a29dc
@sydney-munro
add in ability to set a specific clock
b1bc015
@BenWhitehead @sydney-munro
chore: refactor and separate lifecycle of config from customer and wh…
19297a0 
…at we use to run a PCU
@BenWhitehead @sydney-munro
chore: add pool size validation
4a51be1
@sydney-munro
IT test to ensure customtime is updated
2a98f6c
@sydney-munro
lint
746b581
@sydney-munro
Adding in more tests
4acfa8c
@sydney-munro
lint
f4e7fa8
@sydney-munro
more tests
e88574b
@sydney-munro
lint
57597dd
@sydney-munro
add missing null check
80c747d
@sydney-munro
address pr comments
2adc0e5
@sydney-munro
unit test for offset calculations
6678349
@sydney-munro
fixing docs
7d39672
@sydney-munro
lint
f7c4358
@sydney-munro @BenWhitehead
Update google-cloud-storage/src/main/java/com/google/cloud/storage/Pa…
6762593 
…rallelCompositeUploadBlobWriteSessionConfig.java

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@sydney-munro @BenWhitehead
Apply suggestions from code review
4f51449 
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@sydney-munro
lint
4861c85
@sydney-munro sydney-munro merged commit 43b8006 into main Mar 15, 2024
21 of 23 checks passed
@sydney-munro sydney-munro deleted the custom-metadata branch March 15, 2024 18:49
@release-please release-please bot mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn left review comments

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sydney-munro @BenWhitehead @frankyn @yoshi-kokoro