feat(datastore): Return Get, GetMulti, Put and PutMulti errors with enhanced details #7061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
telpirion
suggested changes
Nov 17, 2022
datastore/datastore.go
Outdated
| @@ -114,7 +113,7 @@ func NewClient(ctx context.Context, projectID string, opts ...option.ClientOptio | |||
| } | |||
|
|
|||
| if projectID == "" { | |||
| return nil, errors.New("datastore: missing project/dataset id") | |||
| return nil, fmt.Errorf("datastore: missing project/dataset id") | |||
There was a problem hiding this comment.
In places where no error is being wrapped, you don't need to replace errors.New().
There was a problem hiding this comment.
@telpirion Thank you for the review. I replaced it for consistency, But I've reverted it now. Please take a look!
datastore/datastore.go
Outdated
| @@ -134,19 +133,21 @@ func detectProjectID(ctx context.Context, opts ...option.ClientOption) (string, | |||
| return "", fmt.Errorf("fetching creds: %w", err) | |||
| } | |||
| if creds.ProjectID == "" { | |||
| return "", errors.New("datastore: see the docs on DetectProjectID") | |||
| return "", fmt.Errorf("datastore: see the docs on DetectProjectID") | |||
datastore/datastore.go
Outdated
| } | ||
| return creds.ProjectID, nil | ||
| } | ||
|
|
||
| var ( | ||
| // ErrInvalidEntityType is returned when functions like Get or Next are | ||
| // passed a dst or src argument of invalid type. | ||
| ErrInvalidEntityType = errors.New("datastore: invalid entity type") | ||
| ErrInvalidEntityType = fmt.Errorf("datastore: invalid entity type") |
datastore/datastore.go
Outdated
| // ErrInvalidKey is returned when an invalid key is presented. | ||
| ErrInvalidKey = errors.New("datastore: invalid key") | ||
| ErrInvalidKey = fmt.Errorf("datastore: invalid key") |
datastore/datastore.go
Outdated
| // ErrNoSuchEntity is returned when no entity was found for a given key. | ||
| ErrNoSuchEntity = errors.New("datastore: no such entity") | ||
| ErrNoSuchEntity = fmt.Errorf("datastore: no such entity") |
datastore/datastore.go
Outdated
| ErrNoSuchEntity = errors.New("datastore: no such entity") | ||
| ErrNoSuchEntity = fmt.Errorf("datastore: no such entity") | ||
| // ErrDifferentKeyAndDstLength is returned when the length of dst and key are different. | ||
| ErrDifferentKeyAndDstLength = fmt.Errorf("datastore: keys and dst slices have different length") |
Signed-off-by: Sagar Vakkala <sagarwakawaka@gmail.com>
|
@telpirion The comments have been resolved, Could you check this PR again? |
telpirion
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7060
Changes
checkMultiArgs()logic has been folded inGet()andPut().errors.Newtofmt.Errorf