Fix handling of .pom files with multiple license declarations #88
Conversation
|
Thanks @rfk. We definitely want to see this PR make it into a release. I'll help in any way I can if any fixes are needed. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
dc8593b
to
8712e06
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
(The CLA weirdess above was because I used github's web-based "update branch" merge button, which made a new commit under my default email address that doesn't have a CLA. I've fixed it by rebasing with proper author info). @zhiqiao could you please help us figure out the next steps here? |
|
Thanks Aaron!!! 🎆 |
|
I'll file an issue to release a new version. I'm not familiar with that process, so I'll chat with some team members in the morning! |
|
woooo!! thanks!
…On Thu, Oct 10, 2019, 11:00 Aaron Stacy ***@***.***> wrote:
https://developers.google.com/android/guides/releases#october_10_2019
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#88?email_source=notifications&email_token=AAA7N4YRCF5ADKRA66FTIY3QN47QJA5CNFSM4IUW66X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA4VMUY#issuecomment-540628563>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7N4447USNUO5KJMEOHM3QN47QJANCNFSM4IUW66XQ>
.
|
Fixes #6.
I've included a testcase that failed before the change and passes afterward. I don't really understand all the nuances of the test setup here so please let me know if this could be done better.