[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer newer lazy task configuration gradle api for merge resources #62

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Prefer newer lazy task configuration gradle api for merge resources #62

merged 2 commits into from
Aug 21, 2019

Conversation

jzbrooks
Copy link

Addresses #57

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@jzbrooks
Copy link
Author

Added a new cla for a work email address

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Moritz-David
Moritz-David previously approved these changes Jun 24, 2019
Copy link
@Moritz-David Moritz-David left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@colinrtwhite
Copy link
Contributor
colinrtwhite commented Jun 27, 2019

mergeResources is also used in GoogleServicesPlugin.groovy. Would be good to fix that usage as well.

@jzbrooks
Copy link
Author
jzbrooks commented Jul 9, 2019

@colinrtwhite As requested, the google services plugin has been fixed as well.

@colinrtwhite
Copy link
Contributor

Thanks! Unfortunately, I don't have permissions to merge or I would. I believe @davidmotson and @zhiqiao have access.

Copy link
@Zeuskartik Zeuskartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix this for google play services plugin as well, kindly do the needful.

@jzbrooks
Copy link
Author

Need to fix this for google play services plugin as well, kindly do the needful.

It's fixed in the PR already. It just needs to be merged and shipped.

@colinrtwhite
Copy link
Contributor
colinrtwhite commented Jul 14, 2019

I've forked the Google Play Services Plugin here and merged @jzbrooks's PR.

To use it add JitPack to your list of repositories:

buildscript {
    repositories {
        maven { url 'https://jitpack.io' }
    }
}

And replace the plugin in your list of dependencies:

buildscript {
    dependencies {
        // Replace "classpath 'com.google.gms:google-services:4.3.0'" with:
        classpath 'com.github.colinrtwhite:google-services:9da6686'
    }
}

@jzbrooks
Copy link
Author

@zhiqiao would it be possible to get this merged and in a release soon?

Is there someone I could loop into this review that might be more available for review if you aren't able?

@davidmotson
Copy link
Collaborator

Hi, thank you very much for your work on this. I'll merge it in and release it within the next month.

@jzbrooks
Copy link
Author

Thanks!

@davidmotson davidmotson merged commit 431ed00 into google:master Aug 21, 2019
@jzbrooks jzbrooks deleted the gradle-warning-fix branch August 21, 2019 23:48
@eeVoskos
Copy link
eeVoskos commented Oct 4, 2019

Any news about an upcoming release that includes this fix? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet