Update typing for new TS version (#6365)

firebase · Jun 17, 2022 · d87d3a8 · d87d3a8
1 parent efe2000
commit d87d3a8
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/packages/analytics/src/get-config.ts b/packages/analytics/src/get-config.ts
@@ -188,7 +188,9 @@ async function attemptFetchDynamicConfigWithRetry(
       logger.warn(
         `Timed out fetching this Firebase app's measurement ID from the server.` +
           ` Falling back to the measurement ID ${measurementId}` +
-          ` provided in the "measurementId" field in the local Firebase config. [${e.message}]`
+          ` provided in the "measurementId" field in the local Firebase config. [${
+            (e as Error)?.message
+          }]`
       );
       return { appId, measurementId };
     }
@@ -203,13 +205,14 @@ async function attemptFetchDynamicConfigWithRetry(
 
     return response;
   } catch (e) {
-    if (!isRetriableError(e)) {
+    const error = e as Error;
+    if (!isRetriableError(error)) {
       retryData.deleteThrottleMetadata(appId);
       if (measurementId) {
         logger.warn(
           `Failed to fetch this Firebase app's measurement ID from the server.` +
             ` Falling back to the measurement ID ${measurementId}` +
-            ` provided in the "measurementId" field in the local Firebase config. [${e.message}]`
+            ` provided in the "measurementId" field in the local Firebase config. [${error?.message}]`
         );
         return { appId, measurementId };
       } else {
@@ -218,7 +221,7 @@ async function attemptFetchDynamicConfigWithRetry(
     }
 
     const backoffMillis =
-      Number(e.customData.httpStatus) === 503
+      Number(error?.customData?.httpStatus) === 503
         ? calculateBackoffMillis(
             backoffCount,
             retryData.intervalMillis,

diff --git a/packages/messaging/src/internals/requests.ts b/packages/messaging/src/internals/requests.ts
@@ -141,7 +141,7 @@ export async function requestDeleteToken(
     }
   } catch (err) {
     throw ERROR_FACTORY.create(ErrorCode.TOKEN_UNSUBSCRIBE_FAILED, {
-      errorInfo: err
+      errorInfo: (err as Error)?.toString()
     });
   }
 }

diff --git a/repo-scripts/size-analysis/analyze-all-bundles.ts b/repo-scripts/size-analysis/analyze-all-bundles.ts
@@ -61,7 +61,7 @@ export async function generateReportForBundles(
       input: version ? `${outputDir}/${bundle}` : `${definitionDir}/${bundle}`,
       bundler: Bundler.Rollup,
       mode: version ? Mode.Npm : Mode.Local,
-      output: output,
+      output,
       debug: true
     };
     console.log(`Running for bundle "${bundle}" with mode "${option.mode}".`);
@@ -78,7 +78,7 @@ function overwriteVersion(
   bundle: string,
   temp: string,
   version: string
-) {
+): void {
   const definitions = JSON.parse(
     fs.readFileSync(`${definitionDir}/${bundle}`, { encoding: 'utf-8' })
   );
@@ -93,7 +93,7 @@ function overwriteVersion(
   });
 }
 
-function parseAnalysisOutput(product: string, output: string) {
+function parseAnalysisOutput(product: string, output: string): Report[] {
   const analyses = JSON.parse(fs.readFileSync(output, { encoding: 'utf-8' }));
   const results: Report[] = [];
   for (const analysis of analyses) {

diff --git a/repo-scripts/size-analysis/test/size-analysis.test.ts b/repo-scripts/size-analysis/test/size-analysis.test.ts
@@ -196,7 +196,7 @@ describe('extractExports', () => {
 describe('extractAllTopLevelSymbols', () => {
   let subsetExportsBundleFile: string;
   let extractedDeclarations: MemberList;
-  before(function () {
+  before(() => {
     const start = Date.now();
     subsetExportsBundleFile = getSubsetExportsBundleFilePath();
     extractedDeclarations = extractAllTopLevelSymbols(subsetExportsBundleFile);