[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated API to connect direct channel #2717

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Remove deprecated API to connect direct channel #2717

merged 3 commits into from
Apr 5, 2019

Conversation

charlotteliang
Copy link
Contributor

Should use shouldEstablishDirectChannel property instead.

@charlotteliang charlotteliang added this to the Firebase 6 milestone Apr 3, 2019
ryanwilson
ryanwilson previously requested changes Apr 4, 2019
View reviewed changes
Copy link
Member
@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit then LGTM.

Firebase/Messaging/FIRMMessageCode.h Outdated Show resolved Hide resolved
@paulb777
Copy link
Member
paulb777 commented Apr 4, 2019

Looks like this broke on travis - https://travis-ci.org/firebase/firebase-ios-sdk/builds/515808414

maksymmalyhin
maksymmalyhin approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor
@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlotteliang
Copy link
Contributor Author

@ryanwilson I think the PR needs your approval to be merged.

@paulb777 paulb777 dismissed ryanwilson’s stale review April 5, 2019 01:21

Ryan's nit was addressed

@charlotteliang charlotteliang merged commit f025da1 into master Apr 5, 2019
@charlotteliang charlotteliang deleted the fcm-deprecate-connect branch April 5, 2019 01:22
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@charlotteliang @Corrob
Remove deprecated API to connect direct channel (#2717)
8e32916
@firebase firebase locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@morganchen12 morganchen12 Awaiting requested review from morganchen12

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@charlotteliang @paulb777 @ryanwilson @maksymmalyhin @googlebot