[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare docs for new providers release (August 2022) #25618

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

potiuk
Copy link
Member
@potiuk potiuk commented Aug 9, 2022

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author
potiuk commented Aug 9, 2022

cc: @vincbeck @ferruzzi @alexott @wojsamjan -> please take a look and see if there is anything else we should include

@alexott
Copy link
Contributor
alexott commented Aug 9, 2022

lgtm for Databricks side, only maybe we don't need this one: Databricks: update user-agent string (#25578) - it's covered by the improving telemetry one

@potiuk
Copy link
Member Author
potiuk commented Aug 9, 2022

lgtm for Databricks side, only maybe we don't need this one: Databricks: update user-agent string (#25578) - it's covered by the improving telemetry one

I prefer to keep full list of the "code" changes. that have potential to change behaviours of released code (As opposed to changes that just impact test code/documentation which can be "hidden") - having the PR# in changelog is good way to find out problem reasons when they happen.

@potiuk
Copy link
Member Author
potiuk commented Aug 9, 2022

And mostly they make communication with users easier. Changelog is essenially a "communication" tool with the users - it is easier to explain to user "this change was done, impacted this and actually you can see it there - it was mentioned there in the changelog"

@alexott
Copy link
Contributor
alexott commented Aug 9, 2022

ok

@potiuk
Copy link
Member Author
potiuk commented Aug 9, 2022

cc: @lwyszomi too

@lwyszomi
Copy link
Contributor
lwyszomi commented Aug 9, 2022

@potiuk can we wait for #25587 and include too to the release, pls 🥺

@potiuk
Copy link
Member Author
potiuk commented Aug 9, 2022

Yep. Just approved and merged it.

@ferruzzi
Copy link
Contributor
ferruzzi commented Aug 9, 2022

I was hoping to get #25413 in this one since it'll be a major release for Amazon.

@eladkal
Copy link
Contributor
eladkal commented Aug 9, 2022

I was hoping to get #25413 in this one since it'll be a major release for Amazon.

I'm not sure how this one will be a breaking change?
It should be backward compatible.

@ferruzzi
Copy link
Contributor
ferruzzi commented Aug 9, 2022

It's also removing deprecated code, so I figured this was a good time. I just pushed a change that is passing all local testing, so we'll see. No need to hold up the release if you don't think it's important to get it in before the major.

@eladkal
Copy link
Contributor
eladkal commented Aug 9, 2022

#18896 is probably also in the waiting list for next wave?

@potiuk
Copy link
Member Author
potiuk commented Aug 9, 2022

#18896 is probably also in the waiting list for next wave?

Merged.

@potiuk potiuk force-pushed the prepare-docs-for-new-providers-release branch from 6aadd0f to 6db5c4d Compare August 9, 2022 23:13
@potiuk
Copy link
Member Author
potiuk commented Aug 9, 2022

Updated, and reeady for merging when green.

@potiuk
Copy link
Member Author
potiuk commented Aug 10, 2022

I need +1 here :)

* ``Remove deprecated modules (#25543)``
* ``Resolve Amazon Hook's 'region_name' and 'config' in wrapper (#25336)``
* ``Resolve and validate AWS Connection parameters in wrapper (#25256)``
* ``Standardize AwsLambda (#25100)``
Copy link
Contributor
@eladkal eladkal Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AwsLambda is not a breaking change #25100
It's backward compatible and the deprecation of this class/modules were not removed in Vincent PRs
#25543 (comment) , #25609 (comment)

@potiuk potiuk merged commit e5ac6c7 into apache:main Aug 10, 2022
@potiuk potiuk deleted the prepare-docs-for-new-providers-release branch August 10, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants