-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update type hints to comply with PEP-0585 #9974
Merged
gcf-merge-on-green
merged 23 commits into
GoogleCloudPlatform:main
from
davidcavazos:type-hints
May 17, 2023
Merged
chore: update type hints to comply with PEP-0585 #9974
gcf-merge-on-green
merged 23 commits into
GoogleCloudPlatform:main
from
davidcavazos:type-hints
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
Issues that are directly related to samples.
api: batch
Issues related to the Batch API.
api: cloudsql
api: composer
Issues related to the Cloud Composer API.
api: compute
Issues related to the Compute Engine API.
api: storage
Issues related to the Cloud Storage API.
api: translate
Issues related to the Cloud Translation API.
labels
May 16, 2023
…ples into type-hints
…ples into type-hints
…ples into type-hints
davidcavazos
requested review from
a team,
leahecole,
bradmiro and
chalmerlowe
as code owners
May 17, 2023 18:49
kweinmeister
approved these changes
May 17, 2023
nicain
approved these changes
May 17, 2023
nicain
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
May 17, 2023
gcf-merge-on-green
bot
merged commit May 17, 2023
161448f
into
GoogleCloudPlatform:main
9 of 10 checks passed
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: batch
Issues related to the Batch API.
api: cloudsql
api: composer
Issues related to the Cloud Composer API.
api: compute
Issues related to the Compute Engine API.
api: storage
Issues related to the Cloud Storage API.
api: translate
Issues related to the Cloud Translation API.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the type hints to comply with PEP-0585.
The script covers most cases, but a handful still required manual intervention to normalize them.
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)