[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudsql): format comments into doc strings #8803

Merged
merged 4 commits into from
Dec 30, 2022
Merged

Conversation

jackwotherspoon
Copy link
Contributor

Fixes #8794

@jackwotherspoon jackwotherspoon self-assigned this Dec 14, 2022
@jackwotherspoon jackwotherspoon requested a review from a team December 14, 2022 20:35
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner December 14, 2022 20:35
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 14, 2022
@jackwotherspoon jackwotherspoon changed the title chore: format comments into doc strings chore(cloudsql): format comments into doc strings Dec 14, 2022
Copy link
Collaborator
@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would there be any benefit in documenting the return type (https://google.github.io/styleguide/pyguide.html#doc-function-returns) as well?

@nicain nicain merged commit 8b5ae77 into main Dec 30, 2022
@nicain nicain deleted the csql-docstrings branch December 30, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudsql samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Cloud SQL sample method comments into docstrings
3 participants