[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudsql): add MySQL Auto IAM AuthN sample #8526

Merged
merged 3 commits into from
Dec 7, 2022
Merged

feat(cloudsql): add MySQL Auto IAM AuthN sample #8526

merged 3 commits into from
Dec 7, 2022

Conversation

jackwotherspoon
Copy link
Contributor

Adding code sample for MySQL's automatic IAM Authentication feature that will be rolling out soon.

Blocked on #466

@jackwotherspoon jackwotherspoon added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 17, 2022
@jackwotherspoon jackwotherspoon requested a review from a team November 17, 2022 14:59
@jackwotherspoon jackwotherspoon self-assigned this Nov 17, 2022
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner November 17, 2022 14:59
@snippet-bot
Copy link
snippet-bot bot commented Nov 17, 2022 •
edited

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: cloudsql samples Issues that are directly related to samples. labels Nov 17, 2022
dandhlee
dandhlee reviewed Nov 17, 2022
View reviewed changes
Copy link
Collaborator
@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you be adding tests once unblocked?

cloud-sql/mysql/sqlalchemy/connect_connector_auto_iam_authn.py Show resolved Hide resolved
@jackwotherspoon
Copy link
Contributor Author

Will you be adding tests once unblocked?

I looked into it and I believe there isn't a major value add for the additional test (not worth the additional testing resources being spun up). This feature is only a slight variation of connect_connector.py (additional flag being set) which already is tested as part of connector_test.

@dandhlee Because of this I think it is okay to continue without a test for this addition.

dandhlee
dandhlee approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator
@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, discussed offline that the features are tested from the client library and this sample in general (connect / create_engine) are tested.

@jackwotherspoon jackwotherspoon removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 7, 2022
@jackwotherspoon jackwotherspoon merged commit bcb2b27 into main Dec 7, 2022
@jackwotherspoon jackwotherspoon deleted the cloudsql-mysql-iam-authn branch December 7, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
api: cloudsql samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackwotherspoon @enocom @dandhlee