fix: Clean up Python sample at cloud-sql/postgres/sqlalchemy #10023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelke
approved these changes
May 22, 2023
cloud-sql/postgres/sqlalchemy/app.py
Outdated
| @@ -75,32 +83,44 @@ def migrate_db(db: sqlalchemy.engine.base.Engine) -> None: | |||
| # as the function is loaded. This is primarily to help testing. | |||
| @app.before_first_request | |||
| def init_db() -> sqlalchemy.engine.base.Engine: | |||
| """Initiates connection to database and its' structure.""" | |||
There was a problem hiding this comment.
Nit - no apostrophe for possessive of it. This is one of English's many traps.
rsamborski
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/280881086
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)