[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud DLP integration with auto configuration and starter support #699

Open
mvpzone opened this issue Nov 14, 2021 · 6 comments
Open
Labels
priority: p3 type: enhancement New feature or request

Comments

@mvpzone
Copy link
Contributor
mvpzone commented Nov 14, 2021

Proposed feature request related to an enhancement.
Spring Cloud GCP currently does not have native auto-configuration and starter integration with GCP DLP. Cloud DLP offers java API & client libraries.

Description of the problem
Use of DLP with spring boot is not to the same levels as other apis e.g. Cloud Vision.

Describe the proposed solution
This enhancement is to propose additional support for Cloud DLP similar to other cloud api's. A prototype implementation has been made available in the following GitHub repo.

Describe alternatives you've considered
Alternatives to the native spring boot integration involve the direct use of the DLP Java API (with no auto configure / starter support). The alternative increases bootstrapping effort in code.

Additional context
The prototype implementation does not take into account imminent InfoType versioning support. The final contributions will be enhanced to the new API surface (InfoType versioning).

@mvpzone mvpzone changed the title Add support for Cloud DLP integration along with auto configure and starter support Add support for Cloud DLP integration with auto configuration and starter support Nov 14, 2021
@mvpzone mvpzone changed the title Add support for Cloud DLP integration with auto configuration and starter support Add Cloud DLP integration with auto configuration and starter support Nov 14, 2021
@elefeint elefeint added type: enhancement New feature or request priority: p2 labels Nov 15, 2021
@mvpzone
Copy link
Contributor Author
mvpzone commented Nov 15, 2021

The initial contribution and validation is happening on this repo. When the info type versioning makes it to the API surface a PR will be submitted.

@dzou
Copy link
Contributor
dzou commented Nov 22, 2021

Thank you for your contribution. We're still in the process of discussing this internally regarding how to contribute and maintain this module; I will share any updates as they come.

@elefeint
Copy link
Contributor

@mvpzone I apologize for the delay. I've reviewed the code in your repo, and the approach looks good to me. It would be good to have a sample application, too, but that can be done as a follow-up.
Could you create a pull request in this repository, so we can work out the specifics?

@mvpzone
Copy link
Contributor Author
mvpzone commented Dec 15, 2021

@elefeint Will get started on the PR and will look to include a sample app too (so we have a usage example right from the get go.). I am debating if we should also wait to include the DLP InfoType versioning to make it into the API surface or not prior to the PR?

@elefeint
Copy link
Contributor

@mvpzone Yes, let's wait for the API surface to be stable.

@elefeint
Copy link
Contributor
elefeint commented Aug 8, 2022

@zhumin8 Take a look at https://github.com/mvpzone/spring-cloud-gcp-dlp -- see if this is something that would fit in well with your autoconfig generator.

prash-mi pushed a commit to prash-mi/spring-cloud-gcp that referenced this issue Jun 20, 2023
…latform#699)

Bumps [libraries-bom](https://togithub.com/googleapis/java-cloud-bom) from 26.16.0 to 26.17.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://togithub.com/googleapis/java-cloud-bom/releases">libraries-bom's releases</a>.</em></p>
<blockquote>
<h2>v26.17.0</h2>
<p>GCP Libraries BOM 26.17.0</p>
<p>Here are the differences from the previous version (26.16.0)</p>
<h1>New Addition</h1>
<ul>
<li>com.google.cloud:google-cloud-migrationcenter:0.1.0</li>
</ul>
<p>The group ID of the following artifacts is <code>com.google.cloud</code>.</p>
<h1>Notable Changes</h1>
<h2>google-cloud-bigquerystorage 2.38.0 (prev: 2.37.2)</h2>
<ul>
<li>
<p>Add storage error codes for KMS (<a href="https://togithub.com/googleapis/java-bigquerystorage/commit/5d2d3c6fc6be14a3cb79cf0ce0e82b48699a97c4">5d2d3c6</a>)</p>
</li>
<li>
<p>Add table sampling to ReadAPI v1 (<a href="https://togithub.com/googleapis/java-bigquerystorage/commit/5d2d3c6fc6be14a3cb79cf0ce0e82b48699a97c4">5d2d3c6</a>)</p>
</li>
<li>
<p>Update copyright year in Java license header replacement template (<a href="https://redirect.github.com/googleapis/java-bigquerystorage/issues/1810">#1810</a>) (<a href="https://redirect.github.com/googleapis/java-bigquerystorage/issues/2138">#2138</a>) (<a href="https://togithub.com/googleapis/java-bigquerystorage/commit/af99efe938302e0d09c98308ad081244d9c5633e">af99efe</a>)</p>
</li>
</ul>
<h2>google-cloud-datastore 2.15.0 (prev: 2.14.7)</h2>
<ul>
<li>
<p>Multiple dbs support (<a href="https://redirect.github.com/googleapis/java-datastore/issues/1102">#1102</a>) (<a href="https://togithub.com/googleapis/java-datastore/commit/7887f3255cba4dedd7b4f369d77a3279d903127f">7887f32</a>)</p>
</li>
<li>
<p>Add some missing annotations and fix equals/hashcode for DatastoreOptions (<a href="https://redirect.github.com/googleapis/java-datastore/issues/1106">#1106</a>) (<a href="https://togithub.com/googleapis/java-datastore/commit/c4a79effa83c5fdb7ad8db15ae52e2c70db238bc">c4a79ef</a>)</p>
</li>
</ul>
<h2>google-cloud-firestore 3.13.0 (prev: 3.12.0)</h2>
<ul>
<li>Add toString methods to classes comprising WriteBatch (<a href="https://redirect.github.com/googleapis/java-firestore/issues/1281">#1281</a>) (<a href="https://togithub.com/googleapis/java-firestore/commit/9df80286f350ce35c5ed4b2a44df117b7e241a4a">9df8028</a>)</li>
</ul>
<h2>google-cloud-spanner 6.43.0 (prev: 6.42.3)</h2>
<ul>
<li>Delay transaction start option (<a href="https://redirect.github.com/googleapis/java-spanner/issues/2462">#2462</a>) (<a href="https://togithub.com/googleapis/java-spanner/commit/f1cbd168a7e5f48206cdfc2d782835cf7ccb8b0d">f1cbd16</a>)</li>
<li>Make administrative request retries optional (<a href="https://redirect.github.com/googleapis/java-spanner/issues/2476">#2476</a>) (<a href="https://togithub.com/googleapis/java-spanner/commit/ee6548cfa511d6efc99f508290ed0b1ce025a4cc">ee6548c</a>)</li>
</ul>
<h2>google-cloud-spanner-jdbc 2.11.0 (prev: 2.10.0)</h2>
<ul>
<li>Support untyped NULL value parameters (<a href="https://redirect.github.com/googleapis/java-spanner-jdbc/issues/1224">#1224</a>) (<a href="https://togithub.com/googleapis/java-spanner-jdbc/commit/80d2b9d3e4c3265522bbb20766bff1f164617711">80d2b9d</a>)</li>
</ul>
<h2>Other libraries</h2>
<ul>
<li>[aiplatform] add blocking_operation_ids to ImportFeatureValuesOperationMetadata (<a href="https://redirect.github.com/googleapis/google-cloud-java/issues/9481">#9481</a>) (<a href="https://togithub.com/googleapis/google-cloud-java/commit/ba2c590cc9970be41e5a663004d354b3881a69d9">ba2c590</a>)</li>
<li>[billingbudgets] Add resource_ancestors field to support filtering by folders &amp; organizations (<a href="https://redirect.github.com/googleapis/google-cloud-java/issues/9501">#9501</a>) (<a href="https://togithub.com/googleapis/google-cloud-java/commit/0c3b6772868828a429f5f5010483567afe58db54">0c3b677</a>)</li>
<li>[clouddeploy] Add support for disabling Pod overprovisioning in the progressive deployment strategy configuration for a Kubernetes Target (<a href="https://redirect.github.com/googleapis/google-cloud-java/issues/9499">#9499</a>) (<a href="https://togithub.com/googleapis/google-cloud-java/commit/b7890c57859116d1f6033af9f485598d84428f44">b7890c5</a>)</li>
<li>[contactcenterinsights] Add the resource definition of a STT recognizer (<a href="https://redirect.github.com/googleapis/google-cloud-java/issues/9492">#9492</a>) (<a href="https://togithub.com/googleapis/google-cloud-java/commit/f2baa928c4f4d9959591ea905d7c9042320dbc71">f2baa92</a>)</li>
<li>[migrationcenter] new module for migrationcenter (<a href="https://redirect.github.com/googleapis/google-cloud-java/issues/9514">#9514</a>) (<a href="https://togithub.com/googleapis/google-cloud-java/commit/a268c8016262a7a5a13be6a9983294f83d1ecc3f">a268c80</a>)</li>
</ul>
<h1>Version Upgrades</h1>
<h2>Minor Version Upgrades</h2>
<ul>
<li>google-cloud-beyondcorp-appgateways:0.17.0 (prev:0.16.0; Release Notes: <a href="https://togithub.com/googleapis/google-cloud-java/releases/tag/v1.13.0">v0.17.0</a>)</li>
<li>google-cloud-apigee-registry:0.19.0 (prev:0.18.0; Release Notes: <a href="https://togithub.com/googleapis/google-cloud-java/releases/tag/v1.13.0">v0.19.0</a>)</li>
<li>google-cloud-video-intelligence:2.18.0 (prev:2.17.0; Release Notes: <a href="https://togithub.com/googleapis/google-cloud-java/releases/tag/v1.13.0">v2.18.0</a>)</li>
<li>google-cloud-cloudsupport:0.3.0 (prev:0.2.0; Release Notes: <a href="https://togithub.com/googleapis/google-cloud-java/releases/tag/v1.13.0">v0.3.0</a>)</li>
<li>google-cloud-assured-workloads:2.19.0 (prev:2.18.0; Release Notes: <a href="https://togithub.com/googleapis/google-cloud-java/releases/tag/v1.13.0">v2.19.0</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://togithub.com/googleapis/java-cloud-bom/blob/main/CHANGELOG.md">libraries-bom's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://togithub.com/googleapis/java-cloud-bom/compare/v26.16.0...v26.17.0">26.17.0</a> (2023-06-13)</h2>
<h3>Dependencies</h3>
<ul>
<li>update dependency com.google.cloud:first-party-dependencies to v3.11.0 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6028">#6028</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/23aa58f7721ac4181d13e33491c1ba134bf1841a">23aa58f</a>)</li>
<li>update dependency com.google.cloud:gapic-libraries-bom to v1.13.0 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6040">#6040</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/4a276a507a91dbc4db9f9765ad3f7eafc6ea6a61">4a276a5</a>)</li>
<li>update dependency com.google.cloud:google-cloud-bigquery to v2.27.1 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6044">#6044</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/bef12add57a7ad7a7f4ecd81436e031303e607df">bef12ad</a>)</li>
<li>update dependency com.google.cloud:google-cloud-bigquerystorage-bom to v2.38.0 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6041">#6041</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/ed484e601feafb93ba4559fc63d10043a56836e8">ed484e6</a>)</li>
<li>update dependency com.google.cloud:google-cloud-bigtable-bom to v2.23.3 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6033">#6033</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/2b5673668683abcd9ef599cff793af6061d7693a">2b56736</a>)</li>
<li>update dependency com.google.cloud:google-cloud-datastore-bom to v2.15.0 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6042">#6042</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/a988f92dce1502990e026ea294d473a367cfb6af">a988f92</a>)</li>
<li>update dependency com.google.cloud:google-cloud-firestore-bom to v3.13.0 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6024">#6024</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/47f4f640bd8c2a6d32f29f348b4824db36dd849d">47f4f64</a>)</li>
<li>update dependency com.google.cloud:google-cloud-logging-bom to v3.15.3 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6036">#6036</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/4a48f41e558f395d095d0dfaeef8c5fe0c9079d2">4a48f41</a>)</li>
<li>update dependency com.google.cloud:google-cloud-logging-logback to v0.130.14-alpha (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6034">#6034</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/1af8b72a30dad680444bee9e1a6493b31a39ff0b">1af8b72</a>)</li>
<li>update dependency com.google.cloud:google-cloud-logging-logback to v0.130.15-alpha (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6035">#6035</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/ca65ce561152f0c71247e7d4165d982590ccfff6">ca65ce5</a>)</li>
<li>update dependency com.google.cloud:google-cloud-nio to v0.126.17 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6037">#6037</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/fa1ebf66050edd8d657bd650e610478dcb9a1261">fa1ebf6</a>)</li>
<li>update dependency com.google.cloud:google-cloud-pubsub-bom to v1.123.14 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6038">#6038</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/1be40ff79a699c8e3e267ab9474145c27c6d4cb1">1be40ff</a>)</li>
<li>update dependency com.google.cloud:google-cloud-pubsublite-bom to v1.12.8 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6039">#6039</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/33d292a8af9bcdd2bcddd593fe59f19771a3ea4d">33d292a</a>)</li>
<li>update dependency com.google.cloud:google-cloud-spanner-bom to v6.43.0 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6029">#6029</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/7f8df1eacf15f7cfd42cf034dfcd0d30be0e41b6">7f8df1e</a>)</li>
<li>update dependency com.google.cloud:google-cloud-spanner-jdbc to v2.11.0 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6043">#6043</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/0f152e73e9cd2b46afca848067d374b56069ed02">0f152e7</a>)</li>
<li>update dependency com.google.cloud:google-cloud-storage-bom to v2.22.4 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6031">#6031</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/f85721fdbb6ec2b7083676d74fc3e9244ea72525">f85721f</a>)</li>
<li>update dependency commons-io:commons-io to v2.12.0 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/5994">#5994</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/14f8655132e91778f9675f524989519841dfeaeb">14f8655</a>)</li>
<li>update dependency commons-io:commons-io to v2.13.0 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6030">#6030</a>) (<a href="https://togithub.com/googleapis/java-cloud-bom/commit/5b7a0d3b3a8b3db9f41befbd16b2de0831c3c48a">5b7a0d3</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://togithub.com/googleapis/java-cloud-bom/commit/7e0b034512098d3983815c363831a279f4077950"><code>7e0b034</code></a> chore: release main (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6025">#6025</a>)</li>
<li><a href="https://togithub.com/googleapis/java-cloud-bom/commit/bef12add57a7ad7a7f4ecd81436e031303e607df"><code>bef12ad</code></a> deps: update dependency com.google.cloud:google-cloud-bigquery to v2.27.1 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6">#6</a>...</li>
<li><a href="https://togithub.com/googleapis/java-cloud-bom/commit/33d292a8af9bcdd2bcddd593fe59f19771a3ea4d"><code>33d292a</code></a> deps: update dependency com.google.cloud:google-cloud-pubsublite-bom to v1.12...</li>
<li><a href="https://togithub.com/googleapis/java-cloud-bom/commit/1be40ff79a699c8e3e267ab9474145c27c6d4cb1"><code>1be40ff</code></a> deps: update dependency com.google.cloud:google-cloud-pubsub-bom to v1.123.14...</li>
<li><a href="https://togithub.com/googleapis/java-cloud-bom/commit/4a276a507a91dbc4db9f9765ad3f7eafc6ea6a61"><code>4a276a5</code></a> deps: update dependency com.google.cloud:gapic-libraries-bom to v1.13.0 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6040">#6040</a>)</li>
<li><a href="https://togithub.com/googleapis/java-cloud-bom/commit/ed484e601feafb93ba4559fc63d10043a56836e8"><code>ed484e6</code></a> deps: update dependency com.google.cloud:google-cloud-bigquerystorage-bom to ...</li>
<li><a href="https://togithub.com/googleapis/java-cloud-bom/commit/0f152e73e9cd2b46afca848067d374b56069ed02"><code>0f152e7</code></a> deps: update dependency com.google.cloud:google-cloud-spanner-jdbc to v2.11.0...</li>
<li><a href="https://togithub.com/googleapis/java-cloud-bom/commit/a988f92dce1502990e026ea294d473a367cfb6af"><code>a988f92</code></a> deps: update dependency com.google.cloud:google-cloud-datastore-bom to v2.15....</li>
<li><a href="https://togithub.com/googleapis/java-cloud-bom/commit/fa1ebf66050edd8d657bd650e610478dcb9a1261"><code>fa1ebf6</code></a> deps: update dependency com.google.cloud:google-cloud-nio to v0.126.17 (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/6037">#6037</a>)</li>
<li><a href="https://togithub.com/googleapis/java-cloud-bom/commit/3257ce81e9e9b497bf425d1450b44a701ca8c3e1"><code>3257ce8</code></a> build(deps): bump requests from 2.27.1 to 2.31.0 in /.kokoro (<a href="https://redirect.github.com/googleapis/java-cloud-bom/issues/5999">#5999</a>)</li>
<li>Additional commits viewable in <a href="https://togithub.com/googleapis/java-cloud-bom/compare/v26.16.0...v26.17.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.google.cloud:libraries-bom&package-manager=maven&previous-version=26.16.0&new-version=26.17.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants