[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vertexai): Add non-stream multimodality basic #4143

Closed
wants to merge 2 commits into from
Closed

feat(vertexai): Add non-stream multimodality basic #4143

wants to merge 2 commits into from

Conversation

ianlewis
Copy link
@ianlewis ianlewis commented May 22, 2024 •
edited

Description

Go version of the Python sample at
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/inference/non_stream_multimodality_basic.py

Region tag generativeaionvertexai_non_stream_multimodality_basic

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ianlewis ianlewis requested a review from a team as a code owner May 22, 2024 06:10
@snippet-bot Snippet Bot
Copy link
snippet-bot bot commented May 22, 2024 •
edited

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 22, 2024
@ianlewis ianlewis force-pushed the non-stream-multimodality-basic branch 2 times, most recently from d386f7c to 9a5d9d3 Compare May 22, 2024 06:22
@ianlewis
feat(vertexai): Add non-stream multimodality basic
0e60449 
Go version of the Python sample at
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/inference/non_stream_multimodality_basic.py

Region tag `generativeaionvertexai_non_stream_multimodality_basic`

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis force-pushed the non-stream-multimodality-basic branch from 9a5d9d3 to 0e60449 Compare May 22, 2024 23:09
@grayside grayside self-requested a review May 24, 2024 16:38
grayside
grayside reviewed May 24, 2024
View reviewed changes
Copy link
Contributor
@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample is LGTM, but holding off on approval to confirm the reuse question.

vertexai/non-stream-multimodality-basic/nonstreammultimodalitybasic.go

package nonstreammultimodalitybasic

// [START generativeaionvertexai_stream_multimodality_basic]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question:

Is this sample duplicative of https://github.com/GoogleCloudPlatform/golang-samples/blob/main/vertexai/multimodal-all/multimodalall.go or another sample?

If so, should we reuse instead of adding code?

@ianlewis
Copy link
Author

Closing. Will submit a change to the docs to reuse existing samples.

@ianlewis ianlewis closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayside grayside grayside left review comments

Assignees
No one assigned
Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ianlewis @grayside @muncus