[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compute): compute_ip_address_reserve_new_external sample #4141

Merged
merged 1 commit into from
May 29, 2024
Merged

feat(compute): compute_ip_address_reserve_new_external sample #4141

merged 1 commit into from
May 29, 2024

Conversation

irudykss
Copy link
Collaborator

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 21, 2024
@irudykss irudykss force-pushed the samples/compute_ip_address_reserve_new_external branch 3 times, most recently from 22c4602 to f475e7c Compare May 22, 2024 07:55
@irudykss irudykss changed the title [samples][compute_ip_address_reserve_new_external] feat(compute): compute_ip_address_reserve_new_external sample May 22, 2024
@irudykss irudykss added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 22, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 22, 2024
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label May 22, 2024
@irudykss irudykss force-pushed the samples/compute_ip_address_reserve_new_external branch from f475e7c to efc1ac3 Compare May 22, 2024 10:06
@irudykss irudykss added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 22, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 22, 2024
@irudykss irudykss marked this pull request as ready for review May 22, 2024 13:11
@irudykss irudykss requested review from a team as code owners May 22, 2024 13:11
@snippet-bot Snippet Bot
Copy link
snippet-bot bot commented May 22, 2024 •
edited

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@irudykss irudykss force-pushed the samples/compute_ip_address_reserve_new_external branch from efc1ac3 to 9039424 Compare May 24, 2024 07:56
@irudykss irudykss added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 24, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 24, 2024
@irudykss irudykss force-pushed the samples/compute_ip_address_reserve_new_external branch from 9039424 to 1a6da62 Compare May 29, 2024 13:50
@irudykss irudykss added kokoro:run Add this label to force Kokoro to re-run the tests. labels May 29, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2024
@irudykss irudykss merged commit bf7f3de into main May 29, 2024
11 checks passed
@irudykss irudykss deleted the samples/compute_ip_address_reserve_new_external branch May 29, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees

@msampathkumar msampathkumar

Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@irudykss @m-strzelczyk @msampathkumar @kokoro-team