Add detect for passive event listeners #1982
Conversation
|
@patrickkettner This is my first naive attempt at modifying modernizr - let me what I'm missing. Eg. do I need to do add anything specific for testing? I verified that the test page shows 'true' in Chrome 52 and false in Firefox and that the existing tests pass on my machine. |
|
Autobahning my way to Berlin, I'll check it out when I arrive in few hours Thanks!
|
|
@paulirish, Patrick is travelling, can you review / merge? |
| /*! | ||
| { | ||
| "async": false, | ||
| "authors": ["Rick Byers"], |
There was a problem hiding this comment.
we only mark async when true, you can pull this out
|
just the one tiny nit, otherwise lgtm! |
|
Great, thanks Patrick, and thanks for fixing the nit too! |
|
|
||
| define(['Modernizr'], function(Modernizr) { | ||
| Modernizr.addTest('passiveeventlisteners', function() { | ||
| var supportsPassiveOption = false; |
There was a problem hiding this comment.
Should this not be cached? Why running this over and over again?
There was a problem hiding this comment.
Modernizr caches all results by default
There was a problem hiding this comment.
Actually I do not get how to access the result of this test. Cannot find it in the docs either.
Fixes #1894