[go: up one dir, main page]

Closed Bug 1986533 Opened 1 month ago Closed 1 month ago

- OneDrive “For You” Section Fails to Render in Firefox (Gray Screen)

Categories

(Core :: Layout: Text and Fonts, defect)

Firefox 142
defect

Tracking

()

VERIFIED FIXED
145 Branch
Webcompat Score 6
Webcompat Priority P1
Tracking Status
firefox144 --- fixed
firefox145 --- fixed

People

(Reporter: peterstevenson3, Assigned: emilio)

References

(Regressed 1 open bug, )

Details

(Keywords: webcompat:platform-bug, webcompat:site-report, Whiteboard: [necko-triaged][necko-priority-review], [wptsync upstream])

User Story

platform:windows,mac,linux,android
impact:feature-broken
configuration:general
affects:all
branch:release
user-impact-score:450

Attachments

(4 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:142.0) Gecko/20100101 Firefox/142.0

Steps to reproduce:

  • Open Firefox (latest stable build).
  • Navigate to https://onedrive.live.com/?view=8.
  • Click on “Photos” > “For You”.
  • Attempt to view any auto-generated collection.

Actual results:

Gray screen appears; content does not load.

Expected results:

Curated photo collections should render as they do in Edge.

The Bugbug bot thinks this bug should belong to the 'Core::Networking' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Networking
Product: Firefox → Core

Hello Peter,
Thanks for reporting the issue.
I could not reproduce this. I initially saw grey screen for couple of seconds and then they appeared.
It could be that we are loading slowly as the image size could be large? How long did you wait?

If you see this issue consistenly, could you please capture http logs for the issue?

Kindly select logging output to a file and send. use networking preset please
If you’re concerned about privacy and prefer not to share the logs through the tool, you can email them directly to necko@mozilla.com.

If this was working before, could you please try to use mozregression tool to help us identify which patch would have caused this breakage. Thanks a lot for supporting Firefox.

Flags: needinfo?(peterstevenson3)

Any errors in the devtools console?

I (In reply to Sunil Mayya from comment #2)

I could not reproduce this. I initially saw grey screen for couple of seconds and then they appeared.
It could be that we are loading slowly as the image size could be large? How long did you wait?

I see the same. Granted I don't have that many pictures in onedrive, but the section is empty and then quickly goes away.

I've looked at the logs, and I didn't notice any requests failing.

(In reply to Krzysztof from comment #4)

Any errors in the devtools console?

Could you open devtools and let us know if there are any failures?
Additionally, could you change Firefox's User Agent (you can use https://webextension.org/listing/useragent-switcher.html) to Edge and see if you see a different behaviour? Thanks!

Flags: needinfo?(peterstevenson3)
Severity: -- → S3
Points: --- → ?
Rank: 2
Priority: -- → P2
Whiteboard: [necko-triaged][necko-priority-review]

This is the sort of bug which could get flagged as a webcompat issue. (To a user, it works in Chrome, not in Firefox)

I can repro
Here are the console logs:

Source map error: Error: NetworkError when attempting to fetch resource.
Resource URL: https://res.cdn.office.net/admincenter/admin-main/2025.9.4.3/floodgate.en.bundle.js
Source Map URL: https://localcdn.centro-dev.com:5555/floodgate.bundle.js.map

WEBGL_debug_renderer_info is deprecated in Firefox and will be removed. Please use RENDERER. 236.js:238:9886
BJS - [11:00:25]: Babylon.js v8.3.1 - WebGL2 236.js:258:887
AudioContext is suspended, calling resume. This may cause a delay in playback. 236.js:191:9405
Attempt to set a forbidden header was denied: Origin 2 236.js:190:6986
WebGL warning: drawElementsInstanced: Tex image TEXTURE_2D level 0 is incurring lazy initialization.
Uncaught (in promise) DOMException: An invalid or illegal string was specified
    pollUpdate https://res-1.cdn.office.net/files/odsp-web-prod_2025-08-29.009/odbspartan/236.js:274
    pollFonts https://res-1.cdn.office.net/files/odsp-web-prod_2025-08-29.009/odbspartan/236.js:274
    wake https://res-1.cdn.office.net/files/odsp-web-prod_2025-08-29.009/odbspartan/236.js:274
    wake https://res-1.cdn.office.net/files/odsp-web-prod_2025-08-29.009/odbspartan/236.js:275
    wake https://res-1.cdn.office.net/files/odsp-web-prod_2025-08-29.009/odbspartan/236.js:275
    f https://res-1.cdn.office.net/files/odsp-web-prod_2025-08-29.009/odbspartan/236.js:272
236.js:274

I suspect the DOMException is the most likely cause.

Profile: https://share.firefox.dev/3VPqmaf

Component: Networking → DOM: Core & HTML
Severity: S3 → --
Points: ? → ---
Rank: 2
Priority: P2 → --

What string are they passing to document.fonts.load?

Flags: needinfo?(rjesup)

I believe the element is created with something like:

              'hidden' !== Vt ? M().createElement(
                'div',
                {
                  'aria-label': Mt,
                  className: (0, o.a) (
                    bn.flexColumn,
                    mn.forYouAnimated,
                    'animateOut' === Vt &&
                    mn.foryouHidden
                  ),
                  onTransitionEnd: 'animateOut' === Vt ? la : void 0,
                  role: 'complementary'
                }

Actually, I can't reproduce the problem because the "For you" section goes away in Chrome and Firefox for me.

new FontFace('content:Segou', 'https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100..900;1,100..900&display=swap') shows the problem. In Firefox family ends up as "" but in Chrome and Safari it's "content:Segou"

User Story: (updated)
Webcompat Priority: --- → P1
Webcompat Score: --- → 8
Flags: needinfo?(rjesup) → needinfo?(emilio)
Status: UNCONFIRMED → NEW
Component: DOM: Core & HTML → Layout: Text and Fonts
Ever confirmed: true
User Story: (updated)

With this patch, something like:

let ff = new FontFace("content:Segoe", "https://foo.com");
ff.load();

Generates an exception like:

Uncaught (in promise) DOMException: Invalid font descriptor font-family: content:Segoe

Rather than the error in the bug.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

Existing tests will be modified as needed for this, and a WPT added for
this edge case.

Flags: needinfo?(emilio)

I can confirm this fixes the bug

Flags: needinfo?(peterstevenson3)
User Story: (updated)
Webcompat Score: 8 → 6

The previous patch exposes some assertion failures in
test_font_loading_api, but it's pre-existing because font-family: ""
and new FontFace('""', ...) is totally valid.

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54929 for changes under testing/web-platform/tests
Whiteboard: [necko-triaged][necko-priority-review] → [necko-triaged][necko-priority-review], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
Duplicate of this bug: 1987565

Comment on attachment 9513797 [details]
Bug 1986533 - Improve font face error reporting. r=#layout

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Relatively high profile compat issue.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It makes us more tolerant to invalid input. It is rather unlikely that other sites could depend on us rejecting it (not totally impossible, but reverting the behavior change would be a one-liner).
  • String changes made/needed: none
  • Is Android affected?: Yes
Attachment #9513797 - Flags: approval-mozilla-beta?
Flags: qe-verify+
User Story: (updated)
Flags: in-testsuite+

Comment on attachment 9513797 [details]
Bug 1986533 - Improve font face error reporting. r=#layout

Approved for 144.0b7.

Attachment #9513797 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-ver-needed-c145/b144][uplift]

I am attempting to verify this fix, but I can't seem to be able to reproduce it using the steps in comment 0.

I've made sure that the OneDrive application is installed in Windows , I've logged into a test account. Furthermore, I made sure I had a substancial amount of photos uploaded to cloud.

The "For you" section from the Onedrive Photos area is not being displayed in either of my browsers: Firefox Release v143.0.3, Nightly v145.0a1 (2025-09-22), Chrome V141.0.7390.55, EDGE v140.0.3485.94 in Windows 10 with a generic Outlook account and a generic MS account.
A Cognizant MS business account uses a different URL address, has a different UI and does not have a Photos section at all.
A different MS business account uses the same URL (as personal accounts), but still has a different UI, while Photos section is available.

I suspect that the the "For you" section from the Photos area of OneDrive is only shown under specific circumstances, or maybe it has been completely disabled.

On a specific MS Business account, after logging in, if the Photos option is clicked (from the left-side nav menu), while the Photos section would load, the "For you" section would show up as grayed-out/loading, but then it would disappear, only showing the Photos uploaded, after loading completed. This behavior is also observed in Chrome, EDGE, Fx Nightly and Fx Release.

Having tried this using multiple accounts with no reproduction, I believe the issue is either not fixed, not an issue anymore or a very specific account would be neccesary to verify.

@Emilio, can you help us clear this up? Thank you!

Flags: needinfo?(emilio)

Randell, can you help?

Flags: needinfo?(emilio) → needinfo?(rjesup)

The UI seems to have totally changed since I reproed this bug 3 weeks ago. I did verify that the patch landing fixed this.

Status: RESOLVED → VERIFIED
Flags: needinfo?(rjesup)
QA Whiteboard: [qa-ver-needed-c145/b144][uplift] → [qa-ver-blocked-c145/b144][uplift]
Flags: qe-verify+

Comment on attachment 9513798 [details]
Bug 1986533 - Quote invalid font-family descriptors in FontFace constructor and family setter. r=#layout

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: See above. This patch should've been uplifted but wasn't (my fault)
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): See above
  • String changes made/needed: none
  • Is Android affected?: Yes
Attachment #9513798 - Flags: approval-mozilla-beta?
Attachment #9514009 - Flags: approval-mozilla-release?

Comment on attachment 9513798 [details]
Bug 1986533 - Quote invalid font-family descriptors in FontFace constructor and family setter. r=#layout

Guess it's release now...

Attachment #9513798 - Flags: approval-mozilla-beta? → approval-mozilla-release?

Comment on attachment 9513798 [details]
Bug 1986533 - Quote invalid font-family descriptors in FontFace constructor and family setter. r=#layout

Approved for 144.0.2

Attachment #9513798 - Flags: approval-mozilla-release? → approval-mozilla-release+

Comment on attachment 9514009 [details]
Bug 1986533 - Remove an invalid assertion. r=#layout

Approved for 144.0.2

Attachment #9514009 - Flags: approval-mozilla-release? → approval-mozilla-release+
Regressions: 1996062
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: