[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Boot 3 does not provide a configuration property for configuring red metrics custom tag keys #34194

Closed
ttddyy opened this issue Feb 15, 2023 · 4 comments
Closed

Spring Boot 3 does not provide a configuration property for configuring red metrics custom tag keys #34194

ttddyy opened this issue Feb 15, 2023 · 4 comments
Assignees
@mhalbritter
Labels
theme: observability Issues related to observability type: bug A general bug
Milestone
3.0.4

Comments

@ttddyy
Copy link
Contributor
ttddyy commented Feb 15, 2023

In WavefrontTracingAutoConfiguration, it defines a WavefrontSpanHandler bean.
This passes an empty collection to the redMetricsCustomTagKeys in the constructor.

spring-boot/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/wavefront/WavefrontTracingAutoConfiguration.java

Lines 62 to 69 in 0e67fbc

@Bean
@ConditionalOnMissingBean
@ConditionalOnBean(WavefrontSender.class)
WavefrontSpanHandler wavefrontSpanHandler(WavefrontProperties properties, WavefrontSender wavefrontSender,
SpanMetrics spanMetrics, ApplicationTags applicationTags) {
return new WavefrontSpanHandler(properties.getSender().getMaxQueueSize(), wavefrontSender, spanMetrics,
properties.getSourceOrDefault(), applicationTags, Collections.emptySet());
}

Per this documentation in Wavefront, the redMetricsCustomTagKeys should be populated by the wavefront.tracing.red-metrics-custom-tag-keys property.
I believe this bean definition is the corresponding part for the property.

So, what the doc mentioned to work, I think populated values need to be passed to redMetricsCustomTagKeys rather than an empty set.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 15, 2023
@mhalbritter mhalbritter added type: enhancement A general enhancement theme: observability Issues related to observability and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 17, 2023
@mhalbritter mhalbritter added this to the 3.1.x milestone Feb 17, 2023
@wilkinsona wilkinsona removed this from the 3.1.x milestone Feb 27, 2023
@wilkinsona
Copy link
Member

We can't proceed with this until we've got some input from the Wavefront team.

@wilkinsona wilkinsona added the status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team label Feb 27, 2023
@oppegard
Copy link
Contributor
oppegard commented Feb 27, 2023 •
edited
Loading

We (Wavefront team) recommend a new property be added to WavefrontProperties.java: management.wavefront.trace-derived-custom-tag-keys.

While the above property name is different from the Spring Boot 2 property (wavefront.tracing.red-metrics-custom-tag-keys), it matches the name used in other Wavefront Tracing usages documented at https://docs.wavefront.com/tracing_customize_spans_and_alerts.html.

This would be wired into the WavefrontSpanHandler that @ttddyy linked to.

@wilkinsona wilkinsona removed the status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team label Feb 27, 2023
@wilkinsona
Copy link
Member

Thanks, @oppegard.

Given that this was supported with Spring Boot 2 and the separate starter (albeit with a different property name), I think we should consider it to be a bug of omission in Spring Boot 3.0.

@wilkinsona wilkinsona changed the title Populate WavefrontSpanHandler#redMetricsCustomTagKeys defined in WavefrontTracingAutoConfiguration Spring Boot 3 does not provide a configuration property for configuring red metrics custom tag keys Feb 27, 2023
@wilkinsona wilkinsona added type: bug A general bug and removed type: enhancement A general enhancement labels Feb 27, 2023
@wilkinsona wilkinsona added this to the 3.0.x milestone Feb 27, 2023
@oppegard
Copy link
Contributor

@wilkinsona that makes sense to me too. Thank you.

@mhalbritter mhalbritter self-assigned this Mar 1, 2023
@mhalbritter mhalbritter mentioned this issue Mar 1, 2023
Closed
@mhalbritter mhalbritter modified the milestones: 3.0.x, 3.0.4 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
theme: observability Issues related to observability type: bug A general bug
Projects
None yet
Milestone
3.0.4
Development

No branches or pull requests
5 participants
@oppegard @ttddyy @wilkinsona @spring-projects-issues @mhalbritter