[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change retry multiplier from 1.3 to 4, for requests that retry Resour… #971

Merged
merged 4 commits into from Aug 7, 2023
Merged

fix: Change retry multiplier from 1.3 to 4, for requests that retry Resour… #971

merged 4 commits into from Aug 7, 2023

Conversation

amfisher-404
Copy link
Contributor

…ceExhausted.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #970 🦕

@amfisher-404 amfisher-404 requested review from a team as code owners August 1, 2023 21:32
@conventional-commit-lint-gcf
Copy link
conventional-commit-lint-gcf bot commented Aug 1, 2023 •
edited

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Aug 1, 2023
@amfisher-404 amfisher-404 changed the title Change retry multiplier from 1.3 to 4, for requests that retry Resour… fix: Change retry multiplier from 1.3 to 4, for requests that retry Resour… Aug 2, 2023
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2023
@hongalex hongalex added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 4, 2023
@liuyunnnn liuyunnnn merged commit e4364d2 into googleapis:main Aug 7, 2023
24 checks passed
@release-please release-please bot mentioned this pull request Aug 7, 2023
Merged
@amfisher-404 amfisher-404 deleted the retry-policy branch August 7, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuyunnnn liuyunnnn liuyunnnn approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default retry settings are too aggressive for Resource Exhausted errors
5 participants
@amfisher-404 @liuyunnnn @hongalex @yoshi-kokoro @feywind