[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set timeout to infinite for publishing with ordering keys enabled #1134

Merged
merged 1 commit into from Apr 4, 2024
Merged

fix: Set timeout to infinite for publishing with ordering keys enabled #1134

merged 1 commit into from Apr 4, 2024

Conversation

mukund-ananthu
Copy link
Contributor
@mukund-ananthu mukund-ananthu commented Apr 3, 2024 •
edited
  1. Setting timeout to be infinite when publishing with ordering keys enabled.
  2. This is required to retry infinitely when the client library receives retriable error codes from the backend.
  3. Note that there is another test test_publish_with_ordering_key_with_no_retry that currently does not test the retry behavior or settings because the kwargs for commit_retry would be None and commit_timeout would be _MethodDefault._DEFAULT_VALUE when no retries are specified. This test will be improved in a subsequent PR.

Fixes #1084 🦕

@mukund-ananthu mukund-ananthu requested review from a team as code owners April 3, 2024 18:12
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Apr 3, 2024
@mukund-ananthu mukund-ananthu self-assigned this Apr 3, 2024
@mukund-ananthu mukund-ananthu changed the title Set timeout to infinite for publishing with ordering keys enabled fix: Set timeout to infinite for publishing with ordering keys enabled Apr 3, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link
conventional-commit-lint-gcf bot commented Apr 3, 2024 •
edited

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2024
@mukund-ananthu mukund-ananthu enabled auto-merge (squash) April 4, 2024 01:02
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2024
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2024
@mukund-ananthu mukund-ananthu merged commit 67daf3c into main Apr 4, 2024
28 checks passed
@mukund-ananthu mukund-ananthu deleted the infiniteRetryOrderingEnabled branch April 4, 2024 03:18
@release-please release-please bot mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

@kamalaboulhosn kamalaboulhosn Awaiting requested review from kamalaboulhosn

Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publishing sometimes fails when ordering key is enabled
3 participants
@mukund-ananthu @pradn @yoshi-kokoro