[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: json fields dictionary has modification side effect #654

Merged
merged 4 commits into from
Oct 25, 2022
Merged

fix: json fields dictionary has modification side effect #654

merged 4 commits into from
Oct 25, 2022

Conversation

daniel-sanche
Copy link
Contributor

Fixes #652

Based on this original PR, with some unit tests added (thanks @mat105!)

@daniel-sanche daniel-sanche requested review from a team as code owners October 24, 2022 20:40
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 24, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Oct 24, 2022
losalex
losalex approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor
@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@losalex losalex changed the title fix: json fields dictionary has modification side eddect fix: json fields dictionary has modification side effect Oct 25, 2022
@daniel-sanche daniel-sanche merged commit a62a0d6 into main Oct 25, 2022
@daniel-sanche daniel-sanche deleted the fix_json_fields_sideeffects branch October 25, 2022 16:13
@release-please release-please bot mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losalex losalex losalex approved these changes

Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/python-logging API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate a copy of json_fields before adding message
2 participants
@daniel-sanche @losalex