[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyword rendering and docstring improvements #1829

Merged
merged 5 commits into from Feb 27, 2024

Conversation

kiraksi
Copy link
Contributor
@kiraksi kiraksi commented Feb 25, 2024

This PR:

  • Removes "Keyword Arguments" section and adds arguments to "Arguments" to fix rendering on public docs
  • Adds types to docstring arguments missing it for clarity

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1662 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 25, 2024
@kiraksi kiraksi marked this pull request as ready for review February 26, 2024 18:42
@kiraksi kiraksi requested review from a team as code owners February 26, 2024 18:54
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
Copy link
Contributor
@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 4dfb920 into googleapis:main Feb 27, 2024
19 checks passed
@kiraksi kiraksi deleted the keyword-rendering branch February 27, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyword rendering in hosted docs
3 participants