feat: add support for Dataset.isCaseInsensitive #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates a property named is_case_insensitive (in dataset.py) that allows the usage of the isCaseSensitive field in the Dataset REST API. Fixes: googleapis#1670
Linchin
reviewed
Oct 9, 2023
google/cloud/bigquery/dataset.py
Outdated
| @@ -764,6 +765,25 @@ def default_encryption_configuration(self, value): | |||
| api_repr = value.to_api_repr() | |||
| self._properties["defaultEncryptionConfiguration"] = api_repr | |||
|
|
|||
| @property | |||
| def is_case_insensitive(self): | |||
| """Optional[bool]: TRUE if the dataset and its table names are case-insensitive, otherwise FALSE. | |||
There was a problem hiding this comment.
nit: use True and False, following Python convention
There was a problem hiding this comment.
Changed to True and False
Linchin
reviewed
Oct 9, 2023
tests/system/test_client.py
Outdated
| _make_dataset_id("create_table"), is_case_insensitive=False | ||
| ) | ||
| table_arg = Table(ci_dataset.table("test_table3"), schema=SCHEMA) | ||
| tablemc_arg = Table(ci_dataset.table("Test_taBLe3")) |
There was a problem hiding this comment.
another nit: what does mc stand for in the variable tablemc_arg? Could we use something easier to understand?
There was a problem hiding this comment.
mc = mixed case; added a comment about that
|
The PR seems good to me except for a few nits. Also, it needs some additional test coverage for kokoro test to pass. Please let us know if you need any help resolving it :) |
Linchin
reviewed
Oct 19, 2023
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
|
Ping @Linchin & @chalmerlowe :) |
|
I have been out with COVID. Still recovering and trying to catch up on all the things. I will look at this as soon as possible. Thanks for being patient. |
Linchin
reviewed
Nov 1, 2023
|
Thank you @joseignaciorc! |
Linchin
approved these changes
Nov 1, 2023
This was referenced Dec 5, 2023
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits add the the
is_case_insensitiveproperty to theDatasetclass.This property uses the
isCaseInsensitivefield of the Dataset REST API, allowing the configuration of the case-sensitivity of the BigQuery datasets.Fixes: #1670