[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix invalid version specification of pyarrow #1403

Merged
merged 3 commits into from Dec 14, 2022

Conversation

mamo3gr
Copy link
@mamo3gr mamo3gr commented Nov 9, 2022

Make version specification of pyarrow fulfill PEP404.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1402 🦕

busunkim96 and others added 2 commits December 8, 2020 11:52
* ci: skip docfx in main 'Kokoro' presubmit

* fix: specify default sessions in noxfile

* add conditional for cd to project root
* ci: skip docfx in main 'Kokoro' presubmit

* fix: specify default sessions in noxfile

* fix: use python3 instead of 3.6

* fix: add NOX_SESSION to pass down envvars

* fix: remove quotes arround sessions

Co-authored-by: Tim Swast <swast@google.com>
@mamo3gr mamo3gr requested review from a team and Neenu1995 November 9, 2022 03:12
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 9, 2022
@mamo3gr mamo3gr force-pushed the fix-invalid-version-specification branch from 44e13e2 to cc76951 Compare November 9, 2022 03:14
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@mamo3gr mamo3gr force-pushed the fix-invalid-version-specification branch from cc76951 to f104aff Compare November 9, 2022 03:46
@mamo3gr mamo3gr changed the title Fix invalid version specification of pyarrow fix: fix invalid version specification of pyarrow Nov 13, 2022
@aribray aribray added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 15, 2022
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2022
@mamo3gr mamo3gr force-pushed the fix-invalid-version-specification branch from f104aff to 9d5f481 Compare December 2, 2022 13:07
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 2, 2022
@mamo3gr mamo3gr force-pushed the fix-invalid-version-specification branch from 9d5f481 to bb4d5f8 Compare December 2, 2022 13:09
@mamo3gr
Copy link
Author
mamo3gr commented Dec 5, 2022

@aribray @chalmerlowe There seems to be something wrong with the build process. Could you tell me how to rerun kokoro in this PR and/or debug it on my local computer? I cherry-picked some commits from the main branch and they might solve the problem.

Many thanks for considering my request.

@chalmerlowe
Copy link
Contributor

@mamo3gr

we have been doing some other changes in other PRs related to pyarrow, etc.
let me take a look at this PR and make sure everything lines up.

@chalmerlowe
Copy link
Contributor

@mamo3gr @tswast

Looking at the the current file on main, it looks like pyarrow was moved out of the extras category at some point and was listed as a simple dependency: https://github.com/googleapis/python-bigquery/blob/main/setup.py

Am I missing something? Is this PR still relevant?

@tswast
Copy link
Contributor
tswast commented Dec 6, 2022

@chalmerlowe Note that this is targeting the v1 branch. We have intentionally kept that branch alive for potential support for high priority fixes. Up to us if this qualifies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants