[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): table variable fix #1287

Merged
merged 21 commits into from Jan 24, 2023
Merged

docs(samples): table variable fix #1287

merged 21 commits into from Jan 24, 2023

Conversation

adhiggs
Copy link
Contributor
@adhiggs adhiggs commented Jul 7, 2022 •
edited by shollyman

Updated table variable in "# Print row data in tabular format." to point at the correct table_id.

Fixes #1286

@adhiggs adhiggs requested a review from a team July 7, 2022 00:47
@adhiggs adhiggs requested review from a team as code owners July 7, 2022 00:47
@adhiggs adhiggs requested review from GaoleMeng and engelke July 7, 2022 00:47
@conventional-commit-lint-gcf
Copy link
conventional-commit-lint-gcf bot commented Jul 7, 2022 •
edited

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jul 7, 2022
@adhiggs adhiggs changed the title Table variable fix Variable fix Jul 7, 2022
@adhiggs adhiggs changed the title Variable fix fix: table variable fix Jul 7, 2022
@adhiggs
fix: table variable fix
ddb26c8 
Updated table variable in "# Print row data in tabular format." to point at the correct table_id.
@parthea parthea changed the title fix: table variable fix docs(samples): table variable fix Jul 7, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 7, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 7, 2022
@adhiggs
Copy link
Contributor Author
adhiggs commented Jul 7, 2022 •
edited

Not sure how to get these checks to pass. Thoughts?
(And thanks for the assist so far!)

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 8, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 10, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 10, 2022
@steffnay
Copy link
Contributor

Hey, @adhiggs, the Client.list_rows method accepts type Union[Table, TableListItem, TableReference, str] for this parameter, so I am not recognizing the reason for this change.

@adhiggs
Copy link
Contributor Author
adhiggs commented Jul 16, 2022

Hi @steffnay, looping you in on bugs related, stay tuned.

@Vadoid
Copy link
Vadoid commented Jul 18, 2022

Hi @steffnay this change is for clarity and consistency. In other code samples in https://cloud.google.com/bigquery/docs/samples/bigquery-browse-table the table variable passed to methods is 'table_id', except for the last example under "# Print row data in tabular format." where it's 'table', so the last code block wouldn't run while table variable is defined as 'table_id'.

@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@aribray aribray added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2022
@adhiggs
Copy link
Contributor Author
adhiggs commented Dec 1, 2022

Hi team! Is there anything blocking this item from being merged in?

@aribray aribray added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2023
@shollyman shollyman added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 23, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 23, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit a71888a into googleapis:main Jan 24, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 24, 2023
@release-please release-please bot mentioned this pull request Jan 24, 2023
Merged
This was referenced Feb 7, 2023
Closed
Closed
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@adhiggs @abdelmegahedgoogle
docs(samples): table variable fix (googleapis#1287)
5918ea5 
Updated table variable in "# Print row data in tabular format." to point at the correct table_id.


Fixes https://togithub.com/googleapis/python-bigquery/issues/1286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@parthea parthea parthea approved these changes

@GaoleMeng GaoleMeng Awaiting requested review from GaoleMeng

@engelke engelke Awaiting requested review from engelke engelke is a code owner automatically assigned from googleapis/python-samples-owners

@steffnay steffnay Awaiting requested review from steffnay

@aribray aribray Awaiting requested review from aribray

Assignees

@steffnay steffnay

@aribray aribray

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table variable correction in browse_table_data.py
9 participants
@adhiggs @steffnay @Vadoid @shollyman @parthea @meredithslota @yoshi-kokoro @aribray @dandhlee