[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to configure and utilize soft-delete and restore #2425

Merged
merged 1 commit into from Mar 18, 2024
Merged

feat: add ability to configure and utilize soft-delete and restore #2425

merged 1 commit into from Mar 18, 2024

Conversation

ddelgrosso1
Copy link
Contributor
@ddelgrosso1 ddelgrosso1 commented Mar 14, 2024 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2401 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners March 14, 2024 13:40
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. labels Mar 14, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@ddelgrosso1 ddelgrosso1 merged commit 7da5a7d into googleapis:main Mar 18, 2024
16 checks passed
@ddelgrosso1 ddelgrosso1 deleted the soft-delete branch March 18, 2024 17:11
@release-please release-please bot mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement soft delete
2 participants
@ddelgrosso1 @JesseLovelace