[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update types and generation script #1336

Merged
merged 4 commits into from Feb 16, 2024
Merged

feat: update types and generation script #1336

merged 4 commits into from Feb 16, 2024

Conversation

alvarowolfx
Copy link
Contributor

Update types generation script to handle new Discovery changes and handle a case where the discovery-tsd tool doen't handle fields with dots, like formatOptions.useInt64Timestamp.

Also regenerate types with latest changes.

@alvarowolfx alvarowolfx requested review from a team as code owners February 13, 2024 17:18
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Feb 13, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 13, 2024
shollyman
shollyman approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor
@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it worth filing a FR to push the escaping logic down into the template processor, or is discovery-tsd not long for this world here?

@alvarowolfx
Copy link
Contributor Author

LGTM. Is it worth filing a FR to push the escaping logic down into the template processor, or is discovery-tsd not long for this world here?

I'll create an issue on the discovery-tsd project and maybe push a PR to fix it. But as in parallel I'm evaluating moving away from it, this temporary fix is good enough for the time being to push the discovery updates that we have now.

@alvarowolfx alvarowolfx merged commit 496f52c into googleapis:main Feb 16, 2024
15 checks passed
@release-please release-please bot mentioned this pull request Feb 16, 2024
Merged
This was referenced Mar 5, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@Linchin Linchin Awaiting requested review from Linchin Linchin is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alvarowolfx @shollyman