[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add set client endpoint sample #1170

Merged
merged 9 commits into from Jan 25, 2023
Merged

feat: add set client endpoint sample #1170

merged 9 commits into from Jan 25, 2023

Conversation

alvarowolfx
Copy link
Contributor

Towards internal b/254876447

@alvarowolfx alvarowolfx requested a review from a team as a code owner November 9, 2022 21:15
@alvarowolfx alvarowolfx requested a review from a team November 9, 2022 21:15
@snippet-bot
Copy link
snippet-bot bot commented Nov 9, 2022 •
edited

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 9, 2022
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/nodejs-bigquery API. samples Issues that are directly related to samples. labels Nov 9, 2022
loferris
loferris suggested changes Nov 22, 2022
View reviewed changes
samples/setClientEndpoint.js Show resolved Hide resolved
samples/setClientEndpoint.js Outdated Show resolved Hide resolved
@loferris loferris self-requested a review December 6, 2022 22:10
loferris
loferris suggested changes Dec 6, 2022
View reviewed changes
Copy link
Contributor
@loferris loferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just needs a bit of tweaking for the developer values to be in line with other samples!

samples/setClientEndpoint.js Outdated Show resolved Hide resolved
samples/setClientEndpoint.js Outdated Show resolved Hide resolved
samples/setClientEndpoint.js Outdated Show resolved Hide resolved
@loferris loferris self-requested a review December 6, 2022 22:27
loferris
loferris suggested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor
@loferris loferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just resolve the failing checks, the one showing up right now: "samples/setClientEndpoint.js should have a copyright year of 2023"

@alvarowolfx alvarowolfx added the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 13, 2023
@loferris loferris added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 24, 2023
@loferris loferris merged commit df1dcd3 into googleapis:main Jan 25, 2023
@release-please release-please bot mentioned this pull request Jan 25, 2023
Merged
This was referenced Jan 31, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loferris loferris loferris approved these changes

Assignees

@loferris loferris

Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alvarowolfx @loferris