[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test throwing Deadline Exceeded Error instead of Unimplemented error #18275

Open
NivedhaSenthil opened this issue May 17, 2022 · 1 comment
Open

Fix test throwing Deadline Exceeded Error instead of Unimplemented error #18275

NivedhaSenthil opened this issue May 17, 2022 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@NivedhaSenthil
Copy link
Member
NivedhaSenthil commented May 17, 2022 •
edited

Pubsub client library test that check for Error message UnimplementedError when a wrong domain is given fails giving DeadlineExceededError due to a regression in GRPC 1.46.2. grpc/grpc#29706

Skipping the test for now to unblock other PRs. Update the test back when the dependencies issue is fixed.
@NivedhaSenthil NivedhaSenthil changed the title Fix test throwing Deadline Fix test throwing Deadline Exceeded Error instead of Unimplemented error May 17, 2022
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 17, 2022
@bajajneha27 bajajneha27 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels May 19, 2022
@bajajneha27 bajajneha27 mentioned this issue May 19, 2022
Merged
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels May 19, 2022
@NivedhaSenthil NivedhaSenthil added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. 🚨 This issue needs some love. labels May 26, 2022
@NivedhaSenthil
Copy link
Member Author

Updating to internal cleanup, as this is not a bug in repo

@NivedhaSenthil NivedhaSenthil added type: cleanup An internal cleanup or hygiene concern. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 23, 2023
@NivedhaSenthil NivedhaSenthil removed their assignment Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NivedhaSenthil @bajajneha27 @yoshi-automation