[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pubsub): check for nil responses for receive examples #9516

Merged
merged 2 commits into from Mar 6, 2024
Merged

docs(pubsub): check for nil responses for receive examples #9516

merged 2 commits into from Mar 6, 2024

Conversation

hongalex
Copy link
Member
@hongalex hongalex commented Mar 6, 2024

Closes #9045

@hongalex hongalex requested review from shollyman and a team as code owners March 6, 2024 00:46
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the Pub/Sub API. labels Mar 6, 2024
noahdietz
noahdietz approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor
@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the syntax and you're golden

@hongalex hongalex enabled auto-merge (squash) March 6, 2024 01:46
@hongalex hongalex merged commit 6deb969 into main Mar 6, 2024
12 of 13 checks passed
@hongalex hongalex deleted the docs-pubsub-nil-receive branch March 6, 2024 01:50
@release-please release-please bot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub: docs example for Subscription.Receive is incorect
2 participants
@hongalex @noahdietz