[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigquery): Add support for AllowNonIncrementalDefinition and Staleness on MaterializedView #8673

Merged
merged 4 commits into from Jan 16, 2024
Merged

feat(bigquery): Add support for AllowNonIncrementalDefinition and Staleness on MaterializedView #8673

merged 4 commits into from Jan 16, 2024
+42 −17

Conversation

alvarowolfx
Copy link
Contributor

Fixes #8668

@alvarowolfx alvarowolfx requested review from a team as code owners October 11, 2023 18:28
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the BigQuery API. labels Oct 11, 2023
shollyman
shollyman reviewed Oct 12, 2023
View reviewed changes
bigquery/table.go Outdated

// MaxStaleness of data that could be returned when materialized view
// is queried (formatted as Google SQL Interval type).
MaxStaleness string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just use https://pkg.go.dev/cloud.google.com/go/bigquery#IntervalValue here and convert?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes much more sense, thanks for the tip

@alvarowolfx alvarowolfx added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 12, 2023
@derekperkins
Copy link
Contributor

Thanks for adding this. Is there anything preventing this from getting merged?

@shollyman
Copy link
Contributor

TODO: verify the behavior for maxStaleness at the table and within the MVD message. We may want to simply expose the top level message instead.

@bnaul bnaul mentioned this pull request Nov 8, 2023
Open
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Nov 11, 2023
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Dec 11, 2023
@derekperkins
Copy link
Contributor

Following up on this, hoping to get it in a release sooner than later

@alvarowolfx alvarowolfx removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 15, 2024
@alvarowolfx alvarowolfx merged commit 6ec2bb2 into googleapis:main Jan 16, 2024
9 checks passed
@release-please release-please bot mentioned this pull request Jan 16, 2024
Merged
@derekperkins
Copy link
Contributor

Thanks!!

This was referenced Jan 23, 2024
Closed
Closed
Closed
@nonmanager nonmanager mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigquery: support max staleness and non-incremental materialized views
3 participants
@alvarowolfx @derekperkins @shollyman