[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (secretmanaer) readd legacy path templates #5290

Merged
merged 58 commits into from
May 2, 2024
Merged

fix: (secretmanaer) readd legacy path templates #5290

merged 58 commits into from
May 2, 2024

Conversation

sofisl
Copy link
Contributor
@sofisl sofisl commented Apr 29, 2024 •
edited

Fixes #5289

@sofisl sofisl requested review from yoshi-approver and a team as code owners April 29, 2024 20:13
@sofisl sofisl changed the title fix: readd legacy path templates fix: (secretmanaer) readd legacy path templates Apr 30, 2024
sofisl and others added 23 commits April 29, 2024 22:38
@sofisl
Update secret_manager_service_client.ts
a70ff4e
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
2fafc38 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
011120c 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@sofisl
Update owlbot.py
b451056
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
fb47742 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…
387b80a 
…ogle-cloud-node into secretManagerFixes
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
d0f9904 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…
65a892e 
…ogle-cloud-node into secretManagerFixes
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
0520b03 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…
a13ecd0 
…ogle-cloud-node into secretManagerFixes
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
a2b78d7 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…
6580dfe 
…ogle-cloud-node into secretManagerFixes
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
e74c459 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…
780e88e 
…ogle-cloud-node into secretManagerFixes
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
eba82e4 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…
b226113 
…ogle-cloud-node into secretManagerFixes
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
135ffb7 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…
bd1f5b1 
…ogle-cloud-node into secretManagerFixes
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
a2ffac0 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…
7baa97c 
…ogle-cloud-node into secretManagerFixes
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
fd81e29 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…
64808bd 
…ogle-cloud-node into secretManagerFixes
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
851519a 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
gcf-owl-bot bot and others added 17 commits April 30, 2024 03:53
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
8d72fef 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
9c3c1f3 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
d11b8d5 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@sofisl
chore: remove extra functions
564ff04
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
4046666 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
52c24d2 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
f078b02 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
657ceb6 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
65adf9b 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@sofisl
Update owlbot.py
45b50c3
@sofisl
chore revert change to index
17c2b09
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
9286250 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…
7d1eceb 
…ogle-cloud-node into secretManagerFixes
@sofisl
Update owlbot.py
6c4c49d
@sofisl
Update owlbot.py
f1a5f8e
@sofisl
Update owlbot.py
304f77b
@sofisl
chore: update owlbot file
aeea9d3
@sofisl sofisl added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 30, 2024
@sofisl sofisl removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 1, 2024
@sofisl sofisl merged commit 5e14553 into main May 2, 2024
13 checks passed
@sofisl sofisl deleted the secretManagerFixes branch May 2, 2024 16:36
@release-please release-please bot mentioned this pull request May 2, 2024
Merged
@flovouin
Copy link
flovouin commented May 17, 2024 •
edited

This does not seem to work:

TypeError: Cannot read properties of undefined (reading 'render')
    at SecretManagerServiceClient.secretVersionPath (node_modules/@google-cloud/secret-manager/build/src/v1/secret_manager_service_client.js:1161:61)

And indeed, secretVersionPathTemplate does not exist in pathTemplates.

EDIT: Saw that this could be fixed by #5333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking change in minor release of @google-cloud/secret-manager 5.4.0
3 participants
@sofisl @flovouin @alexander-fenster