[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serviceName template substituted with an empty string in quickstart sample test template #4990

Open
alexander-fenster opened this issue Jan 26, 2024 · 0 comments
Open

serviceName template substituted with an empty string in quickstart sample test template #4990

alexander-fenster opened this issue Jan 26, 2024 · 0 comments
Assignees
@sofisl
Labels
samples Issues that are directly related to samples.

Comments

@alexander-fenster
Copy link
Contributor

In this snippet:

google-cloud-node/packages/gapic-node-templating/templates/bootstrap-templates/samples/test/quickstart.js

Lines 21 to 22 in e6f43fa

const { {{serviceName}}Client } = require('{{distributionName}}').{{version}};
const {{name}}Client = new {{serviceName}}Client();

the generated code looks like const { Client } = ... as if the serviceName template does not get substituted properly.

Repro: bootstrap any library according to the instructions, check samples/test/quickstart.js.
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sofisl sofisl

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexander-fenster @sofisl