[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tsconfig.dev.json to extensions templates #3220

Merged
merged 3 commits into from Mar 18, 2021
Merged

Adding tsconfig.dev.json to extensions templates #3220

merged 3 commits into from Mar 18, 2021

Conversation

joehan
Copy link
Contributor
@joehan joehan commented Mar 18, 2021 •
edited

Description

Adding tsconfig.dev.json to the extensions/init templates folder.

We might want to make a 'shared' folder for some of the files that are common between extensions and functions, but I'd like to just get this fixed for now.

Scenarios Tested

firebase ext:dev:init, choose Typescript:
Screen Shot 2021-03-18 at 1 01 41 PM

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Mar 18, 2021
@joehan joehan requested review from mbleigh and bkendall March 18, 2021 20:06
bkendall
bkendall approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor
@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for consolidating templates into one directory, especially if they're identical (or adding a placeholder for changes - you know, like a template hah)

@joehan joehan merged commit 718e5a7 into master Mar 18, 2021
@joehan joehan deleted the jh-fix-init branch March 18, 2021 20:39
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@joehan @devpeerapong
Adding tsconfig.dev.json to extensions templates (firebase#3220)
930a310 
* Adding tsconfig.dev.json to extensions templates

* Changelog

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkendall bkendall bkendall approved these changes

@mbleigh mbleigh Awaiting requested review from mbleigh

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joehan @bkendall