-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Closure Compiler does not support 'Wildcard export' #369
Comments
Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight. |
Hey @Doehl thanks so much for the issue (and the associated fix) If you can get me a gist or something small to repro this then let's get your fix implemented. |
Great! I will put together a repo asap. |
Here you have a repo: |
Perfect, thanks @Doehl! I'll take a look. |
Sorry for the delay @Doehl. Confirmed the issue and the fix. |
Fixed in #370 |
[REQUIRED] Describe your environment
[REQUIRED] Describe the problem
Closure compiler does not support ES6 Wildcard export.
The file at /node_modules/@firebase/util/dist/esm/index.js, does at the moment use Wildcard export.
As a Google product, it may be a good ideer to support the Google Closure Compiler.
This could maybe be solved easily by using the angular/tsickle project, when compiling TS to JS.
Another quick fix could be to declare alle the export manually.
index.ts
Closure Compiler output message:
Steps to reproduce:
All I have done in my Angular project is to import 'firebase/app' and initialize.
In Closure Compiler config have I added all the needed files (package.json and js).
See: #370 for possible fix
The text was updated successfully, but these errors were encountered: