[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions and Storage deprecated Error variables #9569

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Functions and Storage deprecated Error variables #9569

merged 5 commits into from
Apr 6, 2022

Conversation

paulb777
Copy link
Member
@paulb777 paulb777 commented Apr 4, 2022 •
edited

Deprecate Error variables in advance of Swift-first implementations that do not support globals.

API review internally at go/storage-function-error-variable-deprecations

@paulb777 paulb777 requested a review from ryanwilson April 4, 2022 22:46
@google-oss-bot
Copy link
google-oss-bot commented Apr 5, 2022 •
edited

Size Report 1

Affected Products

  • FirebaseStorage

    TypeBase (3271081)Merge (8287ec9)Diff
    CocoaPods605 kB605 kB+8 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lClnOkCyIH.html

@google-oss-bot
Copy link
google-oss-bot commented Apr 5, 2022 •
edited

Coverage Report 1

Affected Products

  • FirebaseStorage-iOS-FirebaseStorage.framework

    Overall coverage changed from 59.67% (3271081) to 59.70% (8287ec9) by +0.03%.

    FilenameBase (3271081)Merge (8287ec9)Diff
    FIRStorageErrors.m55.30%55.97%+0.67%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/H7AgO5JQmv.html

@paulb777 paulb777 added this to the 8.15.0 - M114 milestone Apr 5, 2022
@ryanwilson ryanwilson merged commit 111d8d6 into master Apr 6, 2022
@ryanwilson ryanwilson deleted the pb-deprecated branch April 6, 2022 12:56
@sipersso
Copy link

I was confused when I saw this after upgrading. So FunctionsErrorDetailsKey is deprecated, but what I am supposed to replace it with? There is no mention in the deprecation message, just that it will go away.

@paulb777
Copy link
Member Author

Thanks for the report and sorry about the confusion.

The next release will add back public let FunctionsErrorDetailsKey: String = "details" at https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseFunctions/Sources/FunctionsError.swift#L21.

The workaround and Objective C path forward is to use the string "details"/@"details" instead.

@sipersso
Copy link

Thanks for the clarification @paulb777

@firebase firebase locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
api: functions api: storage public-api-change
Projects
None yet
Milestone
8.15.0 - M114
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulb777 @google-oss-bot @sipersso @ryanwilson