-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in Firebase 5.20.0 #2682
Comments
This comment has been minimized.
This comment has been minimized.
I'm sorry to hear that and sorry for the trouble. Can you think of anything interesting about the query you're running or the data you're running it against? We might get some clues if you enable logging and post the results (or send them to michael@firebase.com). |
Similar issue after a manual update using Carthage. |
@AlexisBarreyat Thanks for chiming in. We're still looking for details on what kind of query triggers the error, and ideally debug logs (see #2682 (comment)). |
Experiencing this crash as well. Seems to be happening across document snapshot listeners, get document calls, and possibly more. Nearly positive this query is one such throwing call:
Stack trace:
|
We think we've isolated the issue. The problem is a lifetime issue in the underlying C++, where if the snapshot listener outlives the document reference, the callback can read memory that's been freed. I'm currently working on a fix. For now, pin to 5.19. |
@yusuftor, @AlexisBarreyat, @ccfriden: We have a fix available in #2686. You can use it without waiting for an official release by adding the following to your Podfile:
I'm hoping we can spin a new release of the Firebase pod shortly, but if this works for you, let us know. |
That didn't work for me. To fetch 5.19 I had to specify the 5.19.0 version:
May I propose to keep this issue open until a new version is released? People probably shouldn't have to dig into closed issues for crashes that are still relevant for the most recent version 🤔 |
To get the fix now, try
Note there are no slashes in the pod names. I'll make an exception to our usual policy and keep this issue open after the fix and until the release to increase findability. |
Ouch, big bug. Yea crashing for me too on @paulb777 your commits fixed the issue. Thanks! |
Thanks for the confirmation @nitrag. We're working on publishing the fix today. |
We've now published a Firebase 5.20.1 release to CocoaPods that includes version 1.2.1 of FirebaseFirestore with the fix. There is also a Firestore version 5.20.1 Carthage update. (All other Carthage versions remain at 5.20.0) The zip file package is available for download at https://github.com/firebase/firebase-ios-sdk/releases/tag/5.20.1 The web site release notes and zip link will be updated later this week. |
Having just updated to Firebase 5.20.0, the app now crashes when I run it.Here is the stack track for the thread that it crashes in:
It didn't crash in the previous version, all I've done is update Pods to the latest versions.
The text was updated successfully, but these errors were encountered: