[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading between minor releases #238

Closed
ct-dh opened this issue Jul 13, 2020 · 2 comments
Closed

Upgrading between minor releases #238

ct-dh opened this issue Jul 13, 2020 · 2 comments
Labels
question Further information is requested

Comments

@ct-dh
Copy link
ct-dh commented Jul 13, 2020

Hi, looking at the upgrade docs (https://cloud.google.com/config-connector/docs/how-to/install-upgrade-uninstall#manual-upgrade) for manual installs (in our case we used the YAML definition to deploy for a workload identity based setup) we have to delete various things and then perform the regular install as below:

1. Remove the system components:

kubectl delete sts,deploy,po,svc,roles,clusterroles,clusterrolebindings --all-namespaces -l cnrm.cloud.google.com/system=true --wait=true
kubectl delete validatingwebhookconfiguration abandon-on-uninstall.cnrm.cloud.google.com --ignore-not-found --wait=true
kubectl delete validatingwebhookconfiguration validating-webhook.cnrm.cloud.google.com --ignore-not-found --wait=true
kubectl delete mutatingwebhookconfiguration mutating-webhook.cnrm.cloud.google.com --ignore-not-found --wait=true

2. Run the manual install steps

I saw in a comment on an issue somewhere that upgrades for minor versions of CC, such as 1.9 -> 1.10 should be fine to just apply without the deletes first, so just kubectl apply the new 0-cnrm-system.yaml), is this a valid statement, if so could it be added to the docs to make it clearer?
@ct-dh ct-dh added the question Further information is requested label Jul 13, 2020
@ct-dh ct-dh mentioned this issue Jul 13, 2020
Closed
@jcanseco
Copy link
Member

Hi @ct-dh, our recommendation is to follow the whole upgrade procedure as documented, including the deletions. We do not recommend just kubectl apply-ing the new system YAMLs without performing the deletions, since it is possible for system components to be renamed/removed across minor version bumps.

@ct-dh
Copy link
Author
ct-dh commented Jul 14, 2020

Okay, thanks for the answer :)

@ct-dh ct-dh closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcanseco @ct-dh